From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pzlG5-0007II-KC for mharc-qemu-trivial@gnu.org; Thu, 18 May 2023 17:34:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzlG3-0007I0-KH for qemu-trivial@nongnu.org; Thu, 18 May 2023 17:33:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzlG2-0006hT-8F for qemu-trivial@nongnu.org; Thu, 18 May 2023 17:33:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684445637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7s09xnxpexVz0QYNy4nSoOKMhOyh8D0WhQK8jBI3lIo=; b=ZIwuE1T3CASoYS+K4JOfLXgzxCHKayFGjkqXMTQfrvI00/TV1RUHwFaCkPLSQ8mvbh5afS wBL/NandwQPG6Nnw3tl2gn2ZvKsqLO50nVs/Kk2mQ4CbW6JYMZnu1wFXeQvHBBuuIh5dOU 7kF+KEJnCvXz1dCWwIqn3ZE5qv1TaSM= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-2yn3wmuRMxihZbos9A_dKw-1; Thu, 18 May 2023 17:33:53 -0400 X-MC-Unique: 2yn3wmuRMxihZbos9A_dKw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2af17f626e3so6800291fa.0 for ; Thu, 18 May 2023 14:33:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684445632; x=1687037632; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7s09xnxpexVz0QYNy4nSoOKMhOyh8D0WhQK8jBI3lIo=; b=Md8iO/NpCEKdNGQ5rcLOhn8/wWZovM4K3uR6XAJXaFQ5HAmcgSm4/PB7C57xh8CbrL I7tt8hCDaKEdupHAyhZhOc7kfl+gfp5h4/Xn38EWaVoCVglbOeGhfxbPgrTu3W7TPYTt WyLz/jHbFinS2azXtr3rXv6BnFH1vL+ZNESvS+pssWDd0otLqUXNmSI6tg7Tqecs+0rp qEoHy7cy+ekfZWMXHhSE7gBdSj03G3M6lVB2qKyHkTZ2XJuLirjzcyYwl1cyh4PyovmG FwkEZqd72BwX1g2FY84Nlwy9oEFLAWvQBbQgl0rKbuaq7xy+Kw1a1LKXoh/r0JsHc5Gu CVrw== X-Gm-Message-State: AC+VfDzcapUrVwY0BWBplJav03XzmKyebLnKouXB7SujAeJ+ilUAymtI 2giETDKyDnxUUzScIEX4xFTcjAi+qFe6ADnkC5VWoc5FiAp7zkyQ8nxuufgAoZzTyWUv77eQmYg mJAeYNifRGKbCGUfFNA== X-Received: by 2002:ac2:5973:0:b0:4f3:98b4:e45a with SMTP id h19-20020ac25973000000b004f398b4e45amr84463lfp.21.1684445632284; Thu, 18 May 2023 14:33:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4sMtsQeLWYHS8w2u2HTrJaY0tRujQqwnc+ABZBXbJxykRl6QHF7DhYZcwyFWMDb3fxkMxHCQ== X-Received: by 2002:ac2:5973:0:b0:4f3:98b4:e45a with SMTP id h19-20020ac25973000000b004f398b4e45amr84451lfp.21.1684445631892; Thu, 18 May 2023 14:33:51 -0700 (PDT) Received: from redhat.com ([2a02:14f:175:3e4d:6703:27b9:6f74:5282]) by smtp.gmail.com with ESMTPSA id s18-20020ac25fb2000000b004edb8fac1cesm363730lfe.215.2023.05.18.14.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 14:33:51 -0700 (PDT) Date: Thu, 18 May 2023 17:33:44 -0400 From: "Michael S. Tsirkin" To: Bernhard Beschow Cc: qemu-devel@nongnu.org, Paolo Bonzini , Richard Henderson , qemu-arm@nongnu.org, Marcel Apfelbaum , =?iso-8859-1?Q?Herv=E9?= Poussineau , Michael Tokarev , Laurent Vivier , Eduardo Habkost , qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Peter Maydell Subject: Re: [PATCH 0/4] Trivial cleanups Message-ID: <20230518173332-mutt-send-email-mst@kernel.org> References: <20230513100906.46672-1-shentey@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230513100906.46672-1-shentey@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 May 2023 21:33:59 -0000 On Sat, May 13, 2023 at 12:09:02PM +0200, Bernhard Beschow wrote: > This series: > * Removes dead code from omap_uart and i82378 > * Resolves redundant code in the i8254 timer devices > * Replaces string literals by macro usage for TYPE_ISA_PARALLEL devices > > Bernhard Beschow (4): > hw/timer/i8254_common: Share "iobase" property via base class > hw/arm/omap: Remove unused omap_uart_attach() > hw/char/parallel: Export TYPE_ISA_PARALLEL macro > hw/isa/i82378: Remove unused "io" attribute Acked-by: Michael S. Tsirkin > include/hw/arm/omap.h | 1 - > include/hw/char/parallel.h | 2 ++ > hw/char/omap_uart.c | 9 --------- > hw/char/parallel-isa.c | 2 +- > hw/char/parallel.c | 1 - > hw/i386/kvm/i8254.c | 1 - > hw/isa/i82378.c | 1 - > hw/isa/isa-superio.c | 3 ++- > hw/timer/i8254.c | 6 ------ > hw/timer/i8254_common.c | 6 ++++++ > 10 files changed, 11 insertions(+), 21 deletions(-) > > -- > 2.40.1 >