[meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Rahul T R]

Enable building kmssink plugin in gstreamer1.0-plugins-bad

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
---
 meta-arago-distro/conf/distro/arago.conf | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
index 379b1d44..e32259a9 100644
--- a/meta-arago-distro/conf/distro/arago.conf
+++ b/meta-arago-distro/conf/distro/arago.conf
@@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
 # Enable GST_TRACER logging in gstreamer
 PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
 
+# Enable kmssink in gstreamer
+PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
+
 # Disable pulseaudio routing in alsa by default
 PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
 RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
-- 
2.17.1

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Denys Dmytriyenko]

On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
> Enable building kmssink plugin in gstreamer1.0-plugins-bad
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
>  meta-arago-distro/conf/distro/arago.conf | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> index 379b1d44..e32259a9 100644
> --- a/meta-arago-distro/conf/distro/arago.conf
> +++ b/meta-arago-distro/conf/distro/arago.conf
> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
>  # Enable GST_TRACER logging in gstreamer
>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
>  
> +# Enable kmssink in gstreamer
> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"

FWIW, corresponding bbappend also sets this option, but it needs updating to 
the current gstreamer version:

https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3


>  # Disable pulseaudio routing in alsa by default
>  PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
> -- 
> 2.17.1

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Ryan Eatmon]

On 5/18/2023 1:01 PM, Denys Dmytriyenko wrote:
> On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
>> Enable building kmssink plugin in gstreamer1.0-plugins-bad
>>
>> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
>> ---
>>   meta-arago-distro/conf/distro/arago.conf | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
>> index 379b1d44..e32259a9 100644
>> --- a/meta-arago-distro/conf/distro/arago.conf
>> +++ b/meta-arago-distro/conf/distro/arago.conf
>> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
>>   # Enable GST_TRACER logging in gstreamer
>>   PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
>>   
>> +# Enable kmssink in gstreamer
>> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> 
> FWIW, corresponding bbappend also sets this option, but it needs updating to
> the current gstreamer version:
> 
> https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3

Agreed.  This patch does not add much since the settings it already in 
place in the targetted recipe in arago.

The real issue is that the recipe that adds the kms setting is not being 
used because of the outdated version.  We really need to get the 
gstreamer stuff updated in order for this to work.


>>   # Disable pulseaudio routing in alsa by default
>>   PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
>>   RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
>> -- 
>> 2.17.1

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Brnich, Brandon]

> -----Original Message-----
> From: Eatmon, Ryan <reatmon@ti.com>
> Sent: Thursday, May 18, 2023 2:42 PM
> To: Denys Dmytriyenko <denis@denix.org>; Ravikumar, Rahul <r-
> ravikumar@ti.com>
> Cc: meta-arago@lists.yoctoproject.org; Choudhary, Jayesh <j-
> choudhary@ti.com>; Bhatia, Aradhya <a-bhatia1@ti.com>; Brnich, Brandon
> <b-brnich@ti.com>; Thakkar, Devarsh <devarsht@ti.com>
> Subject: Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to
> enable kmssink plugin
> 
> 
> 
> On 5/18/2023 1:01 PM, Denys Dmytriyenko wrote:
> > On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via
> lists.yoctoproject.org wrote:
> >> Enable building kmssink plugin in gstreamer1.0-plugins-bad
> >>
> >> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> >> ---
> >>   meta-arago-distro/conf/distro/arago.conf | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta-arago-distro/conf/distro/arago.conf
> >> b/meta-arago-distro/conf/distro/arago.conf
> >> index 379b1d44..e32259a9 100644
> >> --- a/meta-arago-distro/conf/distro/arago.conf
> >> +++ b/meta-arago-distro/conf/distro/arago.conf
> >> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = "
> cryptodev-linux"
> >>   # Enable GST_TRACER logging in gstreamer
> >>   PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
> >>
> >> +# Enable kmssink in gstreamer
> >> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> >
> > FWIW, corresponding bbappend also sets this option, but it needs
> > updating to the current gstreamer version:
> >
> > https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes
> > -multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3
> 
> Agreed.  This patch does not add much since the settings it already in place in
> the targetted recipe in arago.
> 
> The real issue is that the recipe that adds the kms setting is not being used
> because of the outdated version.  We really need to get the gstreamer stuff
> updated in order for this to work.

Apologies - just saw this response after I sent my response to this patch. I am working on cleaning
up gstreamer for kirkstone. Should have patch in by end of this week or early next week.

> 
> 
> >>   # Disable pulseaudio routing in alsa by default
> >>   PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
> >>   RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
> >> --
> >> 2.17.1
> 
> --
> Ryan Eatmon                reatmon@ti.com
> -----------------------------------------
> Texas Instruments, Inc.  -  LCPD  -  MGTS

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Devarsh Thakkar]

Hi Denys,

We have a query on location of gstreamer bbappends actually as below :

As I understand meta-ti is TI's BSP layer and meta-arago is arago distro
layer, if someone want to use TI's BSP with some other distro in place of
arago like poky, then I assume they should be able to take meta-ti and poky
yocto layers. In that case to give them same base, shouldn't the gstreamer
bbappends be present in meta-ti layer itself ?

Could you please share your opinion on this.

Regards
Devarsh

On 18/05/23 23:31, Denys Dmytriyenko wrote:
> On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
>> Enable building kmssink plugin in gstreamer1.0-plugins-bad
>>
>> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
>> ---
>>  meta-arago-distro/conf/distro/arago.conf | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
>> index 379b1d44..e32259a9 100644
>> --- a/meta-arago-distro/conf/distro/arago.conf
>> +++ b/meta-arago-distro/conf/distro/arago.conf
>> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
>>  # Enable GST_TRACER logging in gstreamer
>>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
>>  
>> +# Enable kmssink in gstreamer
>> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> 
> FWIW, corresponding bbappend also sets this option, but it needs updating to 
> the current gstreamer version:
> 
> https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3
> 
> 
>>  # Disable pulseaudio routing in alsa by default
>>  PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
>>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
>> -- 
>> 2.17.1

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Denys Dmytriyenko]

https://patchwork.yoctoproject.org/project/arago/patch/20230522175821.510236-1-b-brnich@ti.com/

If you plan to make major changes to gstreamer or other upstream components, 
I'd recommend submitting them upstream to freedesktop. That's the best long 
term approach!

As meta-ti is a BSP layer, it must avoid heavily modifying generic upstream 
components. If there are HW-specific changes necessary, those must be done in 
a Yocto Project compliant way - see everything related to Mesa PVR changes 
done lately.


On Mon, May 22, 2023 at 11:39:31AM +0530, Devarsh Thakkar wrote:
> Hi Denys,
> 
> We have a query on location of gstreamer bbappends actually as below :
> 
> As I understand meta-ti is TI's BSP layer and meta-arago is arago distro
> layer, if someone want to use TI's BSP with some other distro in place of
> arago like poky, then I assume they should be able to take meta-ti and poky
> yocto layers. In that case to give them same base, shouldn't the gstreamer
> bbappends be present in meta-ti layer itself ?
> 
> Could you please share your opinion on this.
> 
> Regards
> Devarsh
> 
> On 18/05/23 23:31, Denys Dmytriyenko wrote:
> > On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
> >> Enable building kmssink plugin in gstreamer1.0-plugins-bad
> >>
> >> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> >> ---
> >>  meta-arago-distro/conf/distro/arago.conf | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> >> index 379b1d44..e32259a9 100644
> >> --- a/meta-arago-distro/conf/distro/arago.conf
> >> +++ b/meta-arago-distro/conf/distro/arago.conf
> >> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
> >>  # Enable GST_TRACER logging in gstreamer
> >>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
> >>  
> >> +# Enable kmssink in gstreamer
> >> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> > 
> > FWIW, corresponding bbappend also sets this option, but it needs updating to 
> > the current gstreamer version:
> > 
> > https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3
> > 
> > 
> >>  # Disable pulseaudio routing in alsa by default
> >>  PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
> >>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
> >> -- 
> >> 2.17.1

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Devarsh Thakkar]

Hi Denys,

Thanks for the reply.
On 23/05/23 04:56, Denys Dmytriyenko wrote:
> https://patchwork.yoctoproject.org/project/arago/patch/20230522175821.510236-1-b-brnich@ti.com/
> 
> If you plan to make major changes to gstreamer or other upstream components, 
> I'd recommend submitting them upstream to freedesktop. That's the best long 
> term approach!
>
> As meta-ti is a BSP layer, it must avoid heavily modifying generic upstream 
> components. If there are HW-specific changes necessary, those must be done in 
> a Yocto Project compliant way - see everything related to Mesa PVR changes 
> done lately.
> 

Upstream looks like a long pole and I suggested this since I see some vendors
having this in BSP layer [1]

Although some vendors do that in distro layer too  and using gstreamer fork
repos [2] as you suggested.

I am not aware of mesa PVR changes if you/someone could share some reference
link for the same it would help.

[1]
https://git.yoctoproject.org/meta-raspberrypi/tree/recipes-multimedia/gstreamer?h=kirkstone

[2] https://github.com/Xilinx/meta-petalinux/tree/rel-v2023.1/recipes-multimedia

Regards
Devarsh
> 
> On Mon, May 22, 2023 at 11:39:31AM +0530, Devarsh Thakkar wrote:
>> Hi Denys,
>>
>> We have a query on location of gstreamer bbappends actually as below :
>>
>> As I understand meta-ti is TI's BSP layer and meta-arago is arago distro
>> layer, if someone want to use TI's BSP with some other distro in place of
>> arago like poky, then I assume they should be able to take meta-ti and poky
>> yocto layers. In that case to give them same base, shouldn't the gstreamer
>> bbappends be present in meta-ti layer itself ?
>>
>> Could you please share your opinion on this.
>>
>> Regards
>> Devarsh
>>
>> On 18/05/23 23:31, Denys Dmytriyenko wrote:
>>> On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
>>>> Enable building kmssink plugin in gstreamer1.0-plugins-bad
>>>>
>>>> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
>>>> ---
>>>>  meta-arago-distro/conf/distro/arago.conf | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
>>>> index 379b1d44..e32259a9 100644
>>>> --- a/meta-arago-distro/conf/distro/arago.conf
>>>> +++ b/meta-arago-distro/conf/distro/arago.conf
>>>> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
>>>>  # Enable GST_TRACER logging in gstreamer
>>>>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
>>>>  
>>>> +# Enable kmssink in gstreamer
>>>> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
>>>
>>> FWIW, corresponding bbappend also sets this option, but it needs updating to 
>>> the current gstreamer version:
>>>
>>> https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3
>>>
>>>
>>>>  # Disable pulseaudio routing in alsa by default
>>>>  PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
>>>>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
>>>> -- 
>>>> 2.17.1

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Denys Dmytriyenko]

On Tue, May 23, 2023 at 12:12:01PM +0530, Devarsh Thakkar wrote:
> Hi Denys,
> 
> Thanks for the reply.
> On 23/05/23 04:56, Denys Dmytriyenko wrote:
> > https://patchwork.yoctoproject.org/project/arago/patch/20230522175821.510236-1-b-brnich@ti.com/
> > 
> > If you plan to make major changes to gstreamer or other upstream components, 
> > I'd recommend submitting them upstream to freedesktop. That's the best long 
> > term approach!
> >
> > As meta-ti is a BSP layer, it must avoid heavily modifying generic upstream 
> > components. If there are HW-specific changes necessary, those must be done in 
> > a Yocto Project compliant way - see everything related to Mesa PVR changes 
> > done lately.
> > 
> 
> Upstream looks like a long pole and I suggested this since I see some vendors
> having this in BSP layer [1]
> 
> Although some vendors do that in distro layer too  and using gstreamer fork
> repos [2] as you suggested.
> 
> I am not aware of mesa PVR changes if you/someone could share some reference
> link for the same it would help.
> 
> [1]
> https://git.yoctoproject.org/meta-raspberrypi/tree/recipes-multimedia/gstreamer?h=kirkstone
> 
> [2] https://github.com/Xilinx/meta-petalinux/tree/rel-v2023.1/recipes-multimedia

Well, [1] is a community-driven layer for a vendor platform, but said vendor 
is not at all involved or has any control over it.

Unlike meta-ti, neither [1] nor [2] are certified "Yocto Project Compatible" 
layers, AFAIK.

There are 2 levels of branding and compliance - "Yocto Project Participant" 
and "Yocto Project Compatible" with the latter one requiring more formal 
review and validation process. There are guidelines to follow, and BSP layers 
have the most strict set of rules in order to gain the "Compatible" status - 
meta-ti is among the few of such layers from the very beginning...


> > On Mon, May 22, 2023 at 11:39:31AM +0530, Devarsh Thakkar wrote:
> >> Hi Denys,
> >>
> >> We have a query on location of gstreamer bbappends actually as below :
> >>
> >> As I understand meta-ti is TI's BSP layer and meta-arago is arago distro
> >> layer, if someone want to use TI's BSP with some other distro in place of
> >> arago like poky, then I assume they should be able to take meta-ti and poky
> >> yocto layers. In that case to give them same base, shouldn't the gstreamer
> >> bbappends be present in meta-ti layer itself ?
> >>
> >> Could you please share your opinion on this.
> >>
> >> Regards
> >> Devarsh
> >>
> >> On 18/05/23 23:31, Denys Dmytriyenko wrote:
> >>> On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
> >>>> Enable building kmssink plugin in gstreamer1.0-plugins-bad
> >>>>
> >>>> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> >>>> ---
> >>>>  meta-arago-distro/conf/distro/arago.conf | 3 +++
> >>>>  1 file changed, 3 insertions(+)
> >>>>
> >>>> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> >>>> index 379b1d44..e32259a9 100644
> >>>> --- a/meta-arago-distro/conf/distro/arago.conf
> >>>> +++ b/meta-arago-distro/conf/distro/arago.conf
> >>>> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
> >>>>  # Enable GST_TRACER logging in gstreamer
> >>>>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
> >>>>  
> >>>> +# Enable kmssink in gstreamer
> >>>> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> >>>
> >>> FWIW, corresponding bbappend also sets this option, but it needs updating to 
> >>> the current gstreamer version:
> >>>
> >>> https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3
> >>>
> >>>
> >>>>  # Disable pulseaudio routing in alsa by default
> >>>>  PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
> >>>>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
> >>>> -- 
> >>>> 2.17.1

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Rahul T R]

Hi Denys,

On 18/05/23 23:31, Denys Dmytriyenko wrote:
> On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
>> Enable building kmssink plugin in gstreamer1.0-plugins-bad
>>
>> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
>> ---
>>   meta-arago-distro/conf/distro/arago.conf | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
>> index 379b1d44..e32259a9 100644
>> --- a/meta-arago-distro/conf/distro/arago.conf
>> +++ b/meta-arago-distro/conf/distro/arago.conf
>> @@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
>>   # Enable GST_TRACER logging in gstreamer
>>   PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
>>   
>> +# Enable kmssink in gstreamer
>> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> FWIW, corresponding bbappend also sets this option, but it needs updating to
> the current gstreamer version:
>
> https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3

Since the gst-plugins-bad bbappend is to be removed as per the 
discussion in below thread
https://lists.yoctoproject.org/g/meta-arago/message/14441
Can this patch be merged

>>   # Disable pulseaudio routing in alsa by default
>>   PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
>>   RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
>> -- 
>> 2.17.1

Regards

Rahul T R

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Denys Dmytriyenko]

On Thu, Jun 01, 2023 at 12:28:11AM +0530, Rahul T R wrote:
> Hi Denys,
> 
> On 18/05/23 23:31, Denys Dmytriyenko wrote:
> >On Thu, May 18, 2023 at 06:56:36PM +0530, Rahul T R via lists.yoctoproject.org wrote:
> >>Enable building kmssink plugin in gstreamer1.0-plugins-bad
> >>
> >>Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> >>---
> >>  meta-arago-distro/conf/distro/arago.conf | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >>diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> >>index 379b1d44..e32259a9 100644
> >>--- a/meta-arago-distro/conf/distro/arago.conf
> >>+++ b/meta-arago-distro/conf/distro/arago.conf
> >>@@ -113,6 +113,9 @@ PACKAGECONFIG:append:pn-openssl = " cryptodev-linux"
> >>  # Enable GST_TRACER logging in gstreamer
> >>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
> >>+# Enable kmssink in gstreamer
> >>+PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> >FWIW, corresponding bbappend also sets this option, but it needs updating to
> >the current gstreamer version:
> >
> >https://git.yoctoproject.org/meta-arago/tree/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.%25.bbappend#n3
> 
> Since the gst-plugins-bad bbappend is to be removed as per the
> discussion in below thread
> https://lists.yoctoproject.org/g/meta-arago/message/14441

Not sure what the conclusion of that discussion was, as changes haven't been 
merged - GST DRM allocator is still required, so gst-plugins-bad bbappend may 
have to stay.


> Can this patch be merged
> 
> >>  # Disable pulseaudio routing in alsa by default
> >>  PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
> >>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
> >>-- 

Re: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to enable kmssink plugin

[Brnich, Brandon]

Hi Rahul,


> -----Original Message-----
> From: Ravikumar, Rahul <r-ravikumar@ti.com>
> Sent: Thursday, May 18, 2023 8:27 AM
> To: meta-arago@lists.yoctoproject.org; Eatmon, Ryan <reatmon@ti.com>
> Cc: Choudhary, Jayesh <j-choudhary@ti.com>; Bhatia, Aradhya <a-
> bhatia1@ti.com>; Brnich, Brandon <b-brnich@ti.com>; Thakkar, Devarsh
> <devarsht@ti.com>; Ravikumar, Rahul <r-ravikumar@ti.com>
> Subject: [meta-arago][master/kirkstone][PATCH] conf: arago: Add flag to
> enable kmssink plugin
> 
> Enable building kmssink plugin in gstreamer1.0-plugins-bad
> 
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> ---
>  meta-arago-distro/conf/distro/arago.conf | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-
> distro/conf/distro/arago.conf

I do not think this is the proper place to enable this plugin. We have a bbapend file 
that is located in meta-arago-extras/recipes-multimedia/gstreamer/ where we are 
updating the package config to build kmssink. 

I have a patch that is responsible for updating these bbapend files as the multimedia
and graphics team is cleaning up gstreamer for kirkstone.

>  PACKAGECONFIG:append:pn-gstreamer1.0 = " tracer-hooks"
> 
> +# Enable kmssink in gstreamer
> +PACKAGECONFIG:append:pn-gstreamer1.0-plugins-bad = " kms"
> +
>  # Disable pulseaudio routing in alsa by default
> PACKAGECONFIG:remove:pn-alsa-plugins = "pulseaudio"
>  RDEPENDS:pulseaudio-server:remove = "alsa-plugins-pulseaudio-conf"
> --
> 2.17.1