From: Christoph Hellwig <hch@lst.de>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Christoph Hellwig <hch@lst.de>, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
xen-devel@lists.xenproject.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org
Subject: Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling
Date: Fri, 19 May 2023 06:04:05 +0200 [thread overview]
Message-ID: <20230519040405.GA10818@lst.de> (raw)
In-Reply-To: <ZGZr/xgbUmVqpOpN@mail-itl>
On Thu, May 18, 2023 at 08:18:39PM +0200, Marek Marczykowski-Górecki wrote:
> On Thu, May 18, 2023 at 03:42:51PM +0200, Christoph Hellwig wrote:
> > Remove the dangerous late initialization of xen-swiotlb in
> > pci_xen_swiotlb_init_late and instead just always initialize
> > xen-swiotlb in the boot code if CONFIG_XEN_PCIDEV_FRONTEND is enabled.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Doesn't it mean all the PV guests will basically waste 64MB of RAM
> by default each if they don't really have PCI devices?
If CONFIG_XEN_PCIDEV_FRONTEND is enabled, and the kernel's isn't booted
with swiotlb=noforce, yes.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
nouveau@lists.freedesktop.org,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, Ben Skeggs <bskeggs@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel@lists.xenproject.org,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [Nouveau] [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling
Date: Fri, 19 May 2023 06:04:05 +0200 [thread overview]
Message-ID: <20230519040405.GA10818@lst.de> (raw)
In-Reply-To: <ZGZr/xgbUmVqpOpN@mail-itl>
On Thu, May 18, 2023 at 08:18:39PM +0200, Marek Marczykowski-Górecki wrote:
> On Thu, May 18, 2023 at 03:42:51PM +0200, Christoph Hellwig wrote:
> > Remove the dangerous late initialization of xen-swiotlb in
> > pci_xen_swiotlb_init_late and instead just always initialize
> > xen-swiotlb in the boot code if CONFIG_XEN_PCIDEV_FRONTEND is enabled.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Doesn't it mean all the PV guests will basically waste 64MB of RAM
> by default each if they don't really have PCI devices?
If CONFIG_XEN_PCIDEV_FRONTEND is enabled, and the kernel's isn't booted
with swiotlb=noforce, yes.
next prev parent reply other threads:[~2023-05-19 4:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 13:42 unexport swiotlb_active Christoph Hellwig
2023-05-18 13:42 ` [Nouveau] " Christoph Hellwig
2023-05-18 13:42 ` [PATCH 1/4] x86: move a check out of pci_xen_swiotlb_init Christoph Hellwig
2023-05-18 13:42 ` [Nouveau] " Christoph Hellwig
2023-05-18 13:42 ` [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling Christoph Hellwig
2023-05-18 13:42 ` [Nouveau] " Christoph Hellwig
2023-05-18 18:18 ` Marek Marczykowski-Górecki
2023-05-18 18:18 ` [Nouveau] " Marek Marczykowski-Górecki
2023-05-19 4:04 ` Christoph Hellwig [this message]
2023-05-19 4:04 ` Christoph Hellwig
2023-05-19 10:10 ` Marek Marczykowski-Górecki
2023-05-19 10:10 ` [Nouveau] " Marek Marczykowski-Górecki
2023-05-19 12:41 ` Christoph Hellwig
2023-05-19 12:41 ` [Nouveau] " Christoph Hellwig
2023-05-19 12:49 ` Andrew Cooper
2023-05-19 12:49 ` [Nouveau] " Andrew Cooper
2023-05-19 12:58 ` Christoph Hellwig
2023-05-19 12:58 ` [Nouveau] " Christoph Hellwig
2023-05-20 6:21 ` Christoph Hellwig
2023-05-20 6:21 ` [Nouveau] " Christoph Hellwig
2023-05-22 7:52 ` Petr Tesařík
2023-05-22 7:52 ` [Nouveau] " Petr Tesařík
2023-05-22 7:54 ` Petr Tesařík
2023-05-22 7:54 ` [Nouveau] " Petr Tesařík
2023-05-22 8:37 ` Juergen Gross
2023-05-22 8:37 ` [Nouveau] " Juergen Gross
2023-06-07 13:12 ` Christoph Hellwig
2023-06-07 13:12 ` [Nouveau] " Christoph Hellwig
2023-06-09 15:38 ` Juergen Gross
2023-06-09 15:38 ` [Nouveau] " Juergen Gross
2023-06-12 6:47 ` Christoph Hellwig
2023-06-12 6:47 ` [Nouveau] " Christoph Hellwig
2023-06-12 8:08 ` Juergen Gross
2023-06-12 8:08 ` [Nouveau] " Juergen Gross
2023-06-12 8:23 ` Christoph Hellwig
2023-06-12 8:23 ` [Nouveau] " Christoph Hellwig
2023-05-18 13:42 ` [PATCH 3/4] drm/nouveau: stop using is_swiotlb_active Christoph Hellwig
2023-05-18 13:42 ` [Nouveau] " Christoph Hellwig
2023-05-18 20:30 ` Lyude Paul
2023-05-18 20:30 ` [Nouveau] " Lyude Paul
2023-06-07 13:11 ` Christoph Hellwig
2023-06-07 13:11 ` [Nouveau] " Christoph Hellwig
2023-05-18 13:42 ` [PATCH 4/4] swiotlb: unexport is_swiotlb_active Christoph Hellwig
2023-05-18 13:42 ` [Nouveau] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519040405.GA10818@lst.de \
--to=hch@lst.de \
--cc=bp@alien8.de \
--cc=bskeggs@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=jgross@suse.com \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marmarek@invisiblethingslab.com \
--cc=mingo@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.