From: Uday Shankar <ushankar@purestorage.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Costa Sapuntzakis <costa@purestorage.com>,
Randy Jennings <randyj@purestorage.com>,
Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 3/3] nvme: improve handling of long keep alives
Date: Fri, 19 May 2023 11:42:24 -0600 [thread overview]
Message-ID: <20230519174224.GA3577629@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <4fcc801e-b680-a60b-f7e1-99a59edc5109@grimberg.me>
On Thu, May 18, 2023 at 12:01:33PM +0300, Sagi Grimberg wrote:
> > + /* Subtract off the keepalive RTT so nvme_keep_alive_work runs
> > + * at the desired frequency. */
> > + if (rtt <= delay)
> > + delay -= rtt;
> > + else
> > + delay = 0;
> This should probably log a warning or something... The controller has
> such a slow response time to keep-alive that it exceeds the delay...
Good idea. Added it in v3.
next prev parent reply other threads:[~2023-05-19 17:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 23:22 [PATCH v2 0/3] keepalive bugfixes Uday Shankar
2023-04-24 23:22 ` [PATCH v2 1/3] nvme: double KA polling frequency to avoid KATO with TBKAS on Uday Shankar
2023-05-18 8:45 ` Sagi Grimberg
2023-04-24 23:22 ` [PATCH v2 2/3] nvme: check IO start time when deciding to defer KA Uday Shankar
2023-05-18 8:52 ` Sagi Grimberg
2023-04-24 23:22 ` [PATCH v2 3/3] nvme: improve handling of long keep alives Uday Shankar
2023-05-18 9:01 ` Sagi Grimberg
2023-05-19 17:42 ` Uday Shankar [this message]
2023-05-17 22:08 ` [PATCH v2 0/3] keepalive bugfixes Uday Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519174224.GA3577629@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=axboe@fb.com \
--cc=costa@purestorage.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.