From: Christoph Hellwig <hch@lst.de>
To: Tatsuki Sugiura <sugi@nemui.org>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
Date: Sat, 20 May 2023 06:22:46 +0200 [thread overview]
Message-ID: <20230520042246.GA31780@lst.de> (raw)
In-Reply-To: <20230519175603.169196-1-sugi@nemui.org>
On Sat, May 20, 2023 at 02:56:03AM +0900, Tatsuki Sugiura wrote:
> HIKSEMI FUTURE M.2 SSD uses the same dummy nguid and eui64.
> I confirmed it with my two devices.
>
> This patch marks the controller as NVME_QUIRK_BOGUS_NID.
>
> ---------------------------------------------------------
> sugi@tempest:~% sudo nvme id-ctrl /dev/nvme0
> NVME Identify Controller:
> vid : 0x1e4b
> ssvid : 0x1e4b
> sn : 30096022612
> mn : HS-SSD-FUTURE 2048G
> fr : SN10542
> rab : 0
> ieee : 000000
> cmic : 0
> mdts : 7
> cntlid : 0
> ver : 0x10400
> rtd3r : 0x7a120
> rtd3e : 0x1e8480
> oaes : 0x200
> ctratt : 0x2
> rrls : 0
> cntrltype : 1
> fguid : 00000000-0000-0000-0000-000000000000
> <snip...>
> ---------------------------------------------------------
>
> ---------------------------------------------------------
> sugi@tempest:~% sudo nvme id-ns /dev/nvme0n1
> NVME Identify Namespace 1:
> <snip...>
> nguid : 00000000000000000000000000000000
> eui64 : 0000000000000002
> lbaf 0 : ms:0 lbads:9 rp:0 (in use)
> ---------------------------------------------------------
>
> Signed-off-by: Tatsuki Sugiura <sugi@nemui.org>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 7f25c0fe3a0b..dae0f8ed0af9 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3422,6 +3422,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_BOGUS_NID, },
> { PCI_DEVICE(0x1e4B, 0x1202), /* MAXIO MAP1202 */
> .driver_data = NVME_QUIRK_BOGUS_NID, },
> + { PCI_DEVICE(0x1e4B, 0x1602), /* MAXIO MAP1602 like HIKSEMI FUTURE NVMe SSD */
It seems like the vendor ID is MAXIO, so I'd remove the
˝like HIKSEMI FUTURE NVMe SSD" here.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-05-20 4:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 17:56 [PATCH] NVMe: Add MAXIO 1602 to bogus nid list Tatsuki Sugiura
2023-05-20 4:22 ` Christoph Hellwig [this message]
2023-05-20 11:27 ` Tatsuki Sugiura
2023-05-20 12:23 ` Tatsuki Sugiura
2023-05-23 6:14 ` Christoph Hellwig
2023-05-25 15:31 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520042246.GA31780@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sugi@nemui.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.