From: Sam Edwards <cfsworks@gmail.com>
To: u-boot@lists.denx.de
Cc: "Sam Edwards" <CFSworks@gmail.com>,
"Tom Rini" <trini@konsulko.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Marek Behún" <kabel@kernel.org>, "Pali Rohár" <pali@kernel.org>,
"Quentin Schulz" <quentin.schulz@theobroma-systems.com>,
"Simon Glass" <sjg@chromium.org>
Subject: [RFC PATCH 01/10] makefile: Fix symbol typo in binary_size_check
Date: Sat, 20 May 2023 14:55:38 -0600 [thread overview]
Message-ID: <20230520205547.1009254-2-CFSworks@gmail.com> (raw)
In-Reply-To: <20230520205547.1009254-1-CFSworks@gmail.com>
The start-of-image marker symbol is `__image_copy_start`; by
searching for `_image_copy_start` instead, this check can
accidentally match `_image_copy_start_ofs`.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a5ab5e3da9..19017cbfa0 100644
--- a/Makefile
+++ b/Makefile
@@ -1262,7 +1262,7 @@ OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
binary_size_check: u-boot-nodtb.bin FORCE
@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
map_size=$(shell cat u-boot.map | \
- awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
+ awk '/__image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
| sed 's/0X//g' \
| bc); \
if [ "" != "$$map_size" ]; then \
--
2.39.2
next prev parent reply other threads:[~2023-05-21 12:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 20:55 [RFC PATCH 00/10] Improve ARM target's support for LLVM toolchain Sam Edwards
2023-05-20 20:55 ` Sam Edwards [this message]
2023-05-20 20:55 ` [RFC PATCH 02/10] arm: set alignment properly for asm funcs Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 03/10] arm: exclude eabi_compat from LTO Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 04/10] arm: add __aeabi_memclr in eabi_compat Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 05/10] arm: add aligned-memory aliases to eabi_compat Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 06/10] arm: discard .gnu.version* sections Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 07/10] arm: efi_loader: discard hash, unwind information Sam Edwards
2023-05-22 7:00 ` Ilias Apalodimas
2023-05-22 19:25 ` Sam Edwards
2023-05-22 20:28 ` Ilias Apalodimas
2023-05-23 5:08 ` Heinrich Schuchardt
2023-05-20 20:55 ` [RFC PATCH 08/10] arm: efi_loader: move .dynamic out of .text in EFI Sam Edwards
2023-05-22 7:30 ` Ilias Apalodimas
2023-05-22 8:10 ` Heinrich Schuchardt
2023-05-22 17:13 ` Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 09/10] arm: discard all .dyn* sections Sam Edwards
2023-05-20 20:55 ` [RFC PATCH 10/10] arm: migrate away from sections.c Sam Edwards
2023-05-23 6:56 ` Ilias Apalodimas
2023-05-21 4:26 ` [RFC PATCH 00/10] Improve ARM target's support for LLVM toolchain Heinrich Schuchardt
2023-05-21 4:59 ` Sam Edwards
2023-05-22 6:52 ` Ilias Apalodimas
2023-05-22 19:37 ` Sam Edwards
2023-05-22 20:15 ` Heinrich Schuchardt
2023-05-23 6:54 ` Ilias Apalodimas
2023-05-22 10:39 ` Michal Simek
2023-05-22 15:30 ` Tom Rini
2023-05-22 19:59 ` Sam Edwards
2023-05-22 21:13 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230520205547.1009254-2-CFSworks@gmail.com \
--to=cfsworks@gmail.com \
--cc=kabel@kernel.org \
--cc=kever.yang@rock-chips.com \
--cc=pali@kernel.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.