All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Leon Romanovsky <leon@kernel.org>,
	David Ahern <dsahern@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Kees Cook <keescook@chromium.org>,
	Christian Brauner <brauner@kernel.org>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	Lennart Poettering <mzxreary@0pointer.de>,
	Luca Boccassi <bluca@debian.org>,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH net-next v6 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD
Date: Mon, 22 May 2023 13:34:09 -0700	[thread overview]
Message-ID: <20230522133409.5c6e839a@kernel.org> (raw)
In-Reply-To: <20230522132439.634031-2-aleksandr.mikhalitsyn@canonical.com>

On Mon, 22 May 2023 15:24:37 +0200 Alexander Mikhalitsyn wrote:
> v6:
> 	- disable feature when CONFIG_UNIX=n/m (pidfd_prepare API is not exported to modules)

IMHO hiding the code under #if IS_BUILTIN(CONFIG_UNRELATED) is
surprising to the user and.. ugly?

Can we move scm_pidfd_recv() into a C source and export that?
That should be less controversial than exporting pidfd_prepare()
directly?

  reply	other threads:[~2023-05-22 20:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 13:24 [PATCH net-next v6 0/3] Add SCM_PIDFD and SO_PEERPIDFD Alexander Mikhalitsyn
2023-05-22 13:24 ` [PATCH net-next v6 1/3] scm: add SO_PASSPIDFD and SCM_PIDFD Alexander Mikhalitsyn
2023-05-22 20:34   ` Jakub Kicinski [this message]
2023-05-23  9:49     ` Christian Brauner
2023-05-23 10:44       ` Luca Boccassi
2023-05-23 21:08         ` Jakub Kicinski
2023-05-24 10:43           ` Aleksandr Mikhalitsyn
2023-05-24 10:47             ` Luca Boccassi
2023-05-24 15:19               ` Jakub Kicinski
2023-05-24 15:45                 ` Aleksandr Mikhalitsyn
2023-06-04 18:02                   ` Jakub Kicinski
2023-06-04 18:07                     ` Aleksandr Mikhalitsyn
2023-06-08 20:28                       ` Aleksandr Mikhalitsyn
2023-05-22 13:24 ` [PATCH net-next v6 2/3] net: core: add getsockopt SO_PEERPIDFD Alexander Mikhalitsyn
2023-05-22 13:24 ` [PATCH net-next v6 3/3] selftests: net: add SCM_PIDFD / SO_PEERPIDFD test Alexander Mikhalitsyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522133409.5c6e839a@kernel.org \
    --to=kuba@kernel.org \
    --cc=aleksandr.mikhalitsyn@canonical.com \
    --cc=arnd@arndb.de \
    --cc=bluca@debian.org \
    --cc=brauner@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=keescook@chromium.org \
    --cc=kuniyu@amazon.com \
    --cc=leon@kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mzxreary@0pointer.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.