All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Shay Drory <shayd@nvidia.com>
Cc: Saeed Mahameed <saeed@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Saeed Mahameed <saeedm@nvidia.com>, <netdev@vger.kernel.org>,
	Tariq Toukan <tariqt@nvidia.com>,
	Moshe Shemesh <moshe@nvidia.com>
Subject: Re: [PATCH net-next] net/mlx5: Introduce SF direction
Date: Mon, 22 May 2023 14:15:45 -0700	[thread overview]
Message-ID: <20230522141545.408f61b0@kernel.org> (raw)
In-Reply-To: <89831a73-89c5-c5b6-d345-72908d8db304@nvidia.com>

On Mon, 22 May 2023 15:47:15 +0300 Shay Drory wrote:
> > What does it mean that an SF is "facing" the network?  
> 
> Facing the physical wire, like an UPLINK vport.
> 
> > Why can't the device automatically "optimize" the hairpin?  
> 
> Our FW/HW can do steering optimization if we know the direction in advance.
> 
> > Or SF1 / SF2 will be uni-directional after this patch?  
> 
> No. every SF will continue to be bi-directional. the change will only 
> affect steering optimization.

I'm not going to claw the details out of you. AFAICT this sounds like
a lazy knob forcing the user to configure something that could be done
automatically. Consider it rejected.

      reply	other threads:[~2023-05-22 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 18:30 [PATCH net-next] net/mlx5: Introduce SF direction Saeed Mahameed
2023-05-20  4:41 ` Jakub Kicinski
2023-05-22 12:47   ` Shay Drory
2023-05-22 21:15     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230522141545.408f61b0@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=moshe@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeed@kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=shayd@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.