From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C935DC7EE23 for ; Mon, 22 May 2023 19:04:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 48076400D2; Mon, 22 May 2023 19:04:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 48076400D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1684782295; bh=RsUCjZ9l/0P7Xsrv7hnXDrjHXdzDJpKYl6hDa79e+6A=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=OYh3W8n9Jx445w4f7T5+tHRxX55LIBAtNIV/ZFDdz87YrHTblFwhhXmpdEZ+kkmPx SGGH9lOxDXtLtNy1nkAkHVwSqIxKV7qUOsSwDepOlrCiyM/UDVAxPKf8lIDkzGuE/P YxsmisENHR8OdVAljBmykBXGImYOQs9dIN/k0HSmQVYJCmt765W7nFIYU81YOXts0K jdTuXJ0DEW49qUrHgFGIQwD8Q+n3ufQHweufdwbs6tzY0TYi5pwSeh1UpWiBLdLMr6 wV+E2cm687I9iEA6pUYXHJYPRB+J00BejUzNKe79IV5SuslBaqyL77Je5ajI4H8QIg N9nIpef6x5qtw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5nwJ2aGdZ3j0; Mon, 22 May 2023 19:04:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 1F35941C3B; Mon, 22 May 2023 19:04:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1F35941C3B Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 998251BF38E for ; Mon, 22 May 2023 19:04:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7EC88822F8 for ; Mon, 22 May 2023 19:04:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7EC88822F8 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cw2pCi9UshZM for ; Mon, 22 May 2023 19:04:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 06CDC82F99 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 06CDC82F99 for ; Mon, 22 May 2023 19:04:50 +0000 (UTC) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-P7ufCRHfMSeSpZBdXJS7HQ-1; Mon, 22 May 2023 15:04:46 -0400 X-MC-Unique: P7ufCRHfMSeSpZBdXJS7HQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f60481749eso7523955e9.1 for ; Mon, 22 May 2023 12:04:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684782285; x=1687374285; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6jZ28GuDynsihTAd/3VuLVOzUIH4ZwLQEZqNL+84MuY=; b=NMDze2FbB8l2cpyDLsN8bbFatdY6y4vgKe4vQBl7GVSaI/xG1ldtr6oosPB9Pg+xES Nkqke3vQMV3TcbpWUkL6XlT4tZiPyHJQH8jKT7ZskgKJx2g16v8LBvEazVBXibBOf2Vv L/CHlo1V5djTP6V3eJj0ycO3YRru7gtshsWOpktth9ZNI9p1DK/DdqojYdhyHAaTqPV4 n2l3+9uxfT3/TOEokToMEbcqrpI8vN460zI0ODXboprBFb5aQy4GZ+4WpK29bjISvvdk yjRYjXRbC07Kxb/lmmfHBbYUL+vrz32q1onSRBuSc1mxr7Yd2WHAfgLNo0Nsn5ExsbhX RcYA== X-Gm-Message-State: AC+VfDwM3YMqPd/r07quGRY9qwRURUh296XXotLF377Aes+pJSz780u5 TqcfwznxMLVmNjwINB2rnKtjjq+SJZkZXaU/IjBaxghgLwVww29lQ78GElUUxPtYaYaH1LHlgZt BFDMG6SzUfIfjkgnIPm62grDlNEoH0g== X-Received: by 2002:a1c:790b:0:b0:3f6:1ac:5feb with SMTP id l11-20020a1c790b000000b003f601ac5febmr4329589wme.16.1684782285369; Mon, 22 May 2023 12:04:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7QbSewB6BsJ5gKLZmpBeVzToPF+5tO7N7Pm53qG70bIifqfT4ySC3qTsizV5jxSdSGcFqtiQ== X-Received: by 2002:a1c:790b:0:b0:3f6:1ac:5feb with SMTP id l11-20020a1c790b000000b003f601ac5febmr4329567wme.16.1684782284967; Mon, 22 May 2023 12:04:44 -0700 (PDT) Received: from redhat.com ([2.52.20.68]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c220a00b003f50e29bce3sm9169360wml.48.2023.05.22.12.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 12:04:44 -0700 (PDT) Date: Mon, 22 May 2023 15:04:39 -0400 From: "Michael S. Tsirkin" To: Willem de Bruijn Message-ID: <20230522144241-mutt-send-email-mst@kernel.org> References: <20230508194326.482-1-emil.s.tantilov@intel.com> <20230512023234-mutt-send-email-mst@kernel.org> <6a900cd7-470a-3611-c88a-9f901c56c97f@intel.com> <20230518130452-mutt-send-email-mst@kernel.org> <7969d09e-2b77-c1a7-0e38-f10d61c83638@amd.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684782289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6jZ28GuDynsihTAd/3VuLVOzUIH4ZwLQEZqNL+84MuY=; b=Ya/RUfj61abBAYE6hLPagqAf8K/b4m0lM9SpUW7bOFl1QQLrBjpZcJdqDBOFInE1Q5gjAv xkKCvxOXTnKZaL2xxigQ1racXvi8H02h2eLGbvfppP4fjwgCldvtrCQYNdyE3ldvprcvkI AqRcK1L59iiClJeueCrXKcNK6a5tNKI= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ya/RUfj6 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 00/15] Introduce Intel IDPF driver X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Orr, Michael" , pabeni@redhat.com, leon@kernel.org, simon.horman@corigine.com, jesse.brandeburg@intel.com, kuba@kernel.org, edumazet@google.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com, decot@google.com, davem@davemloft.net, Shannon Nelson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gRnJpLCBNYXkgMTksIDIwMjMgYXQgMDE6MTI6NDNQTSAtMDQwMCwgV2lsbGVtIGRlIEJydWlq biB3cm90ZToKPiBPbiBGcmksIE1heSAxOSwgMjAyMyBhdCAxMjoxN+KAr1BNIFNoYW5ub24gTmVs c29uIDxzaGFubm9uLm5lbHNvbkBhbWQuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiA1LzE4LzIzIDQ6 MjYgUE0sIFNhbXVkcmFsYSwgU3JpZGhhciB3cm90ZToKPiA+ID4gT24gNS8xOC8yMDIzIDEwOjEw IEFNLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gPiA+PiBPbiBUaHUsIE1heSAxOCwgMjAy MyBhdCAwOToxOTozMUFNIC0wNzAwLCBTYW11ZHJhbGEsIFNyaWRoYXIgd3JvdGU6Cj4gPiA+Pj4K PiA+ID4+Pgo+ID4gPj4+IE9uIDUvMTEvMjAyMyAxMTozNCBQTSwgTWljaGFlbCBTLiBUc2lya2lu IHdyb3RlOgo+ID4gPj4+PiBPbiBNb24sIE1heSAwOCwgMjAyMyBhdCAxMjo0MzoxMVBNIC0wNzAw LCBFbWlsIFRhbnRpbG92IHdyb3RlOgo+ID4gPj4+Pj4gVGhpcyBwYXRjaCBzZXJpZXMgaW50cm9k dWNlcyB0aGUgSW50ZWwgSW5mcmFzdHJ1Y3R1cmUgRGF0YSBQYXRoCj4gPiA+Pj4+PiBGdW5jdGlv bgo+ID4gPj4+Pj4gKElEUEYpIGRyaXZlci4gSXQgaXMgdXNlZCBmb3IgYm90aCBwaHlzaWNhbCBh bmQgdmlydHVhbCBmdW5jdGlvbnMuCj4gPiA+Pj4+PiBFeGNlcHQKPiA+ID4+Pj4+IGZvciBzb21l IG9mIHRoZSBkZXZpY2Ugb3BlcmF0aW9ucyB0aGUgcmVzdCBvZiB0aGUgZnVuY3Rpb25hbGl0eSBp cyB0aGUKPiA+ID4+Pj4+IHNhbWUgZm9yIGJvdGggUEYgYW5kIFZGLiBJRFBGIHVzZXMgdmlydGNo bmwgdmVyc2lvbjIgb3Bjb2RlcyBhbmQKPiA+ID4+Pj4+IHN0cnVjdHVyZXMgZGVmaW5lZCBpbiB0 aGUgdmlydGNobmwyIGhlYWRlciBmaWxlIHdoaWNoIGhlbHBzIHRoZSBkcml2ZXIKPiA+ID4+Pj4+ IHRvIGxlYXJuIHRoZSBjYXBhYmlsaXRpZXMgYW5kIHJlZ2lzdGVyIG9mZnNldHMgZnJvbSB0aGUg ZGV2aWNlCj4gPiA+Pj4+PiBDb250cm9sIFBsYW5lIChDUCkgaW5zdGVhZCBvZiBhc3N1bWluZyB0 aGUgZGVmYXVsdCB2YWx1ZXMuCj4gPiA+Pj4+Cj4gPiA+Pj4+IFNvLCBpcyB0aGlzIGZvciBtZXJn ZSBpbiB0aGUgbmV4dCBjeWNsZT8gIFNob3VsZCB0aGlzIGJlIGFuIFJGQyByYXRoZXI/Cj4gPiA+ Pj4+IEl0IHNlZW1zIHVubGlrZWx5IHRoYXQgdGhlIElEUEYgc3BlY2lmaWNhdGlvbiB3aWxsIGJl IGZpbmFsaXplZCBieSB0aGF0Cj4gPiA+Pj4+IHRpbWUgLSBob3cgYXJlIHlvdSBnb2luZyB0byBo YW5kbGUgYW55IHNwZWNpZmljYXRpb24gY2hhbmdlcz8KPiA+ID4+Pgo+ID4gPj4+IFllcy4gd2Ug d291bGQgbGlrZSB0aGlzIGRyaXZlciB0byBiZSBtZXJnZWQgaW4gdGhlIG5leHQgY3ljbGUoNi41 KS4KPiA+ID4+PiBCYXNlZCBvbiB0aGUgY29tbXVuaXR5IGZlZWRiYWNrIG9uIHYxIHZlcnNpb24g b2YgdGhlIGRyaXZlciwgd2UKPiA+ID4+PiByZW1vdmVkIGFsbAo+ID4gPj4+IHJlZmVyZW5jZXMg dG8gT0FTSVMgc3RhbmRhcmQgYW5kIGF0IHRoaXMgdGltZSB0aGlzIGlzIGFuIGludGVsIHZlbmRv cgo+ID4gPj4+IGRyaXZlci4KPiA+ID4+Pgo+ID4gPj4+IExpbmtzIHRvIHYxIGFuZCB2MiBkaXNj dXNzaW9uIHRocmVhZHMKPiA+ID4+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9uZXRkZXYvMjAy MzAzMjkxNDA0MDQuMTY0NzkyNS0xLXBhdmFuLmt1bWFyLmxpbmdhQGludGVsLmNvbS8KPiA+ID4+ PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9uZXRkZXYvMjAyMzA0MTEwMTEzNTQuMjYxOTM1OS0x LXBhdmFuLmt1bWFyLmxpbmdhQGludGVsLmNvbS8KPiA+ID4+Pgo+ID4gPj4+IFRoZSB2MS0+djIg Y2hhbmdlIGxvZyByZWZsZWN0cyB0aGlzIHVwZGF0ZS4KPiA+ID4+PiB2MSAtLT4gdjI6IGxpbmsg WzFdCj4gPiA+Pj4gICAqIHJlbW92ZWQgdGhlIE9BU0lTIHJlZmVyZW5jZSBpbiB0aGUgY29tbWl0 IG1lc3NhZ2UgdG8gbWFrZSBpdCBjbGVhcgo+ID4gPj4+ICAgICB0aGF0IHRoaXMgaXMgYW4gSW50 ZWwgdmVuZG9yIHNwZWNpZmljIGRyaXZlcgo+ID4gPj4KPiA+ID4+IFllcyB0aGlzIG1ha2VzIHNl bnNlLgo+ID4gPj4KPiA+ID4+Cj4gPiA+Pj4gQW55IElEUEYgc3BlY2lmaWNhdGlvbiB1cGRhdGVz IHdvdWxkIGJlIGhhbmRsZWQgYXMgcGFydCBvZiB0aGUKPiA+ID4+PiBjaGFuZ2VzIHRoYXQKPiA+ ID4+PiB3b3VsZCBiZSByZXF1aXJlZCB0byBtYWtlIHRoaXMgYSBjb21tb24gc3RhbmRhcmRzIGRy aXZlci4KPiA+ID4+Cj4gPiA+Pgo+ID4gPj4gU28gbXkgcXVlc3Rpb24gaXMsIHdvdWxkIGl0IG1h a2Ugc2Vuc2UgdG8gdXBkYXRlIEtjb25maWcgYW5kIG1vZHVsZSBuYW1lCj4gPiA+PiB0byBiZSAi aXB1IiBvciBpZiB5b3UgcHJlZmVyICJpbnRlbC1pZHBmIiB0byBtYWtlIGl0IGNsZWFyIHRoaXMg aXMKPiA+ID4+IGN1cnJlbnRseSBhbiBJbnRlbCB2ZW5kb3Igc3BlY2lmaWMgZHJpdmVyPyAgQW5k IHRoZW4gd2hlbiB5b3UgbWFrZSBpdCBhCj4gPiA+PiBjb21tb24gc3RhbmRhcmRzIGRyaXZlciBy ZW5hbWUgaXQgdG8gaWRwZj8gIFRoZSBwb2ludCBiZWluZyB0byBoZWxwIG1ha2UKPiA+ID4+IHN1 cmUgdXNlcnMgYXJlIG5vdCBjb25mdXNlZCBhYm91dCB3aGV0aGVyIHRoZXkgZ290IGEgZHJpdmVy IHdpdGgKPiA+ID4+IG9yIHdpdGhvdXQgSURQRiB1cGRhdGVzLiBJdCdzIG5vdCBjcml0aWNhbCBJ IGd1ZXNzIGJ1dCBzZWVtcyBsaWtlIGEgZ29vZAo+ID4gPj4gaWRlYS4gV0RZVD8KPiA+ID4KPiA+ ID4gSXQgd291bGQgYmUgbW9yZSBkaXNydXB0aXZlIHRvIGNoYW5nZSB0aGUgbmFtZSBvZiB0aGUg ZHJpdmVyLiBXZSBjYW4KPiA+ID4gdXBkYXRlIHRoZSBwY2kgZGV2aWNlIHRhYmxlLCBtb2R1bGUg ZGVzY3JpcHRpb24gYW5kIHBvc3NpYmx5IGRyaXZlcgo+ID4gPiB2ZXJzaW9uIHdoZW4gd2UgYXJl IHJlYWR5IHRvIG1ha2UgdGhpcyBhIHN0YW5kYXJkIGRyaXZlci4KPiA+ID4gU28gd2Ugd291bGQg cHJlZmVyIG5vdCBjaGFuZ2luZyB0aGUgZHJpdmVyIG5hbWUuCj4gPgo+ID4gTW9yZSBkaXNydXB0 aXZlIGZvciB3aG8/Cj4gPgo+ID4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8gY2hhbmdl IHRoZSBuYW1lIG9mIHRoZSBvbmUgZHJpdmVyIG5vdwo+ID4gYmVmb3JlIGEgcHJvYmxlbSBpcyBj cmVhdGVkIGluIHRoZSB0cmVlIHRoYW4gdG8gbGVhdmUgYSBwb2ludCBvZgo+ID4gY29uZnVzaW9u IGZvciB0aGUgcmVzdCBvZiB0aGUgZHJpdmVycyB0byBjb250ZW5kIHdpdGggaW4gdGhlIGZ1dHVy ZS4KPiAKPiBUaGlzIGRpc2N1c3Npb24gaXMgcHJlbWlzZWQgb24gdGhlIGlkZWEgdGhhdCB0aGUg ZHJpdmVycyB3aWxsCj4gaW5ldml0YWJseSBmb3JrLCB3aXRoIGFuIEludGVsIGRyaXZlciBhbmQg YSBub24tYmFja3dhcmQgY29tcGF0aWJsZQo+IHN0YW5kYXJkaXplZCBkcml2ZXIuCj4gCj4gSW5z dGVhZCwgSSBleHBlY3QgdGhhdCB0aGUgZ29hbCBpcyB0aGF0IHRoZSBmdXR1cmUgc3RhbmRhcmRp emVkIGRyaXZlcgo+IHdpbGwgaXRlcmF0ZSBhbmQgc3VwcG9ydCBhZGRpdGlvbmFsIGZlYXR1cmVz LiBCdXQgdGhhdCB0aGUgZXhpc3RpbmcKPiBoYXJkd2FyZSB3aWxsIGNvbnRpbnVlIHRvIGJlIHN1 cHBvcnRlZCwgaWYgcGVyaGFwcyB3aXRoIHVwZGF0ZWQKPiBmaXJtd2FyZS4KPiAKPiBJRFBGIGZy b20gdGhlIHN0YXJ0IHVzZXMgZmVhdHVyZSBuZWdvdGlhdGlvbiBvdmVyIHZpcnRjaGFubmVsIHRv IGJlCj4gaGlnaGx5IGNvbmZpZ3VyYWJsZS4gQSBmdXR1cmUgZHJpdmVyIG1pZ2h0IGRlcHJlY2F0 ZSBvbGRlciBmZWF0dXJlCj4gKHZhcmlhbnRzKSwgd2hpbGUgZWl0aGVyIHN0aWxsIGNvbnRpbnVl IHRvIHN1cHBvcnQgdGhvc2Ugb3IgcmVxdWlyZQo+IGZpcm13YXJlIHVwZGF0ZXMgdG8gbWF0Y2gg dGhlIG5ldyB2ZXJzaW9uLgo+IAo+IEV2ZW4gaWYgdGhlIGRldmljZSBBUEkgd291bGQgYnJlYWsg aW4gYSBub24tYmFja3dhcmQgY29tcGF0aWJsZSB3YXksCj4gdGhlIHNhbWUgZHJpdmVyIGNhbiBz dXBwb3J0IGJvdGggdmVyc2lvbnMuIFZpcnRpbyBpcyBhbiBleGFtcGxlIG9mCj4gdGhpcy4KPiAK PiBJZiBJJ20gd3JvbmcgYW5kIGZvciBzb21lIHJlYXNvbiB0d28gZHJpdmVycyB3b3VsZCBoYXZl IHRvIGJlCj4gc3VwcG9ydGVkLCB0aGVuIEknbSBzdXJlIHdlIGNhbiBmaWd1cmUgb3V0IGEgc3Vm Zml4IG9yIHByZWZpeCB0byB0aGUKPiBzdGFuZGFyZCBkcml2ZXIgdGhhdCBzZXBhcmF0ZXMgaXQg ZnJvbSB0aGUgZXhpc3Rpbmcgb25lLgoKCk9LIGxldCB1cyBsb29rIGF0IGEgbW9yZSBzcGVjaWZp YyBleGFtcGxlLgoKVGhlIElEUEYgVEMgcmVjZW50bHkgdm90ZWQgdG8gYmluZCB0byBkZXZpY2UK YmFzZWQgb24gY2xhc3MvcHJvZ3JhbW1pbmcgaW50ZXJmYWNlIGFzIG9wcG9zZWQgdG8gZGV2aWNl L3ZlbmRvciBpZC4KRnV0dXJlIGRyaXZlciB3aWxsIGxpa2VseSBkbyB0aGlzLiBDdXJyZW50IGRy aXZlciBvbmx5IGJpbmRzIHRvIGludGVsJ3MKZGV2aWNlIGFuZCB2ZW5kb3IgaWQuIEFzc3VtaW5n IHRoaXMgaGFwcGVucywgd2hhdCBib3RoZXJzIG1lIGlzIHRoYXQKZGVwZW5kaW5nIG9uIGtlcm5l bCB2ZXJzaW9uLCBkcml2ZXIgaWRwZi5rbyBlaXRoZXIgZG9lcyBvciBkb2VzIG5vdCBiaW5kCnRv IGlkcGYgcHJvZ3JhbW1pbmcgaW50ZXJmYWNlLgoKQWxsIHRoaXMgaXMgcXVpdGUgaW1taW5lbnQu CgpZZXMgdHJpY2tzIGxpa2UgY2hlY2tpbmcgbW9kdWxlIHZlcnNpb24gdG8gY2hlY2sgd2hhdCBp cyBzdXBwb3J0ZWQgaXMKcG9zc2libGUsIGJ1dCB3ZSBhcmUgYmVnaW5uaW5nIHRvIGFscmVhZHkg ZGV2ZWxvcCB0ZWNobmljYWwgZGVwdCBhbmQKbG9yZSBhbmQgd2UganVzdCBzdGFydGVkLiBTaW1w bGUgbHNtb2R8Z3JlcCAtcSBpZHBmIHNlZW1zIGxpa2UgYW4KZWFzaWVyLCBtb3JlIHJvYnVzdCBh bmQgaW50dWl0aXZlIHdheSB0aGFuIGlmIFtbICQoY2F0Ci9zeXMvbW9kdWxlL2lkcGYvdmVyc2lv bikgPT0gIjIuMCIgXV0gdGhlbiBlY2hvICJpZHBmIiBmaQoKQW5kIHllcyBzb21lbW9yZSBtaWdo dCBzaGlwIHRoZSBleGlzdGluZyBkcml2ZXIKZHVyaW5nIHRoaXMgaW5pdGlhbCB3aW5kb3cuIFRo ZW4gd2UgZ2V0CmxzbW9kfGdyZXAgLXEgLWUgaWRwZiAtZSBpbnRlbC1pcHUKc3RpbGwgc2VlbXMg cHJldHR5IGNsZWFuLiBBbmQgaG9wZWZ1bGx5IHRoZSBjaGFuZ2Ugd2lsbCBoYXBwZW4gd2l0aGlu CmEgY291cGxlIG9mIG1vbnRocyBzbyBub3QgbW9yZSB0aGFuIG9uZSByZWxlYXNlIHdpbGwgaGF2 ZQp0aGUgaW50ZWwtaXB1IG5hbWUuCgpPZiBjb3Vyc2UgYWxsIHRoaXMgaXMgbm90IGVhcnRoIHNo YXR0ZXJpbmdseSBpbXBvcnRhbnQgYnV0IHN0aWxsLApJJ20gaW50ZXJlc3RlZCBpbiB3aGF0IG90 aGVycyB0aGluay4KCi0tIApNU1QKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWlsaW5nIGxpc3QKSW50ZWwtd2lyZWQtbGFu QG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtd2lyZWQtbGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD1C13AE5 for ; Mon, 22 May 2023 19:04:50 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B911CB0 for ; Mon, 22 May 2023 12:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684782288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6jZ28GuDynsihTAd/3VuLVOzUIH4ZwLQEZqNL+84MuY=; b=fq/RIrgTPMs6zmBO5RGLdxi8YbbLpxVCsdK6uL9jIe7PlqxUO5mvpFHVk5vORp9l7eozys ti0l8E+cf7We/HVr4vmUF/J7V/MYNCB9n4PCtQz4lVWY0YyK7q1+AM/Qq/e7KhKPOLAech 1zT2fCzexbg4l+01AowpGAgk5Ne8L20= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-Q2E7O_LpPhKelLlMjTHvJA-1; Mon, 22 May 2023 15:04:46 -0400 X-MC-Unique: Q2E7O_LpPhKelLlMjTHvJA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f5d6dc52fdso20202275e9.0 for ; Mon, 22 May 2023 12:04:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684782285; x=1687374285; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6jZ28GuDynsihTAd/3VuLVOzUIH4ZwLQEZqNL+84MuY=; b=i8sWlzjDYXeAYpo0oBzEyJkoiB/28NJg1nJsHlLQfmmz/5XYHnc7fV0C6dpbN+z0eH NwvBAv1Xf55duQ0N5WTZJDeTW9jqvx9x86hqA+CnQv6uMGrlyxqnkI7dw23dPaRBpIUR VB3gavlD/xISMqDoohzKvfrhR7JsI1JAzoVgWtPUq+4MFtSxqCm0m1AbcBTMXTIWSjd/ TMHcNbNhIqHAfdGjSMOIMt6GC7p98iCC5CuAxBKf7cxG6QDc3qDmgvxNUsbpiicBp85I FCJ9gso0J0n0nf4D+fHDP9I2pU62C5u5yjsBd4N2Z/a6K7N9hisVmFuhO4H4iwbSzO+J SonQ== X-Gm-Message-State: AC+VfDxAGkBIJycNiPz9Gvm+gBF+pd1yS3uTEyTz3hfIVs4amb1VWh2l T/uuplf/5ZJJ09kMcuGq8qXXq8/ukKR16lQ6VE+NUKLyI1OE6pTXCIZW9cbXs6Gn3a8hx4PnUrS Tewr1VS0NyjSolLuZ X-Received: by 2002:a1c:790b:0:b0:3f6:1ac:5feb with SMTP id l11-20020a1c790b000000b003f601ac5febmr4329584wme.16.1684782285369; Mon, 22 May 2023 12:04:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7QbSewB6BsJ5gKLZmpBeVzToPF+5tO7N7Pm53qG70bIifqfT4ySC3qTsizV5jxSdSGcFqtiQ== X-Received: by 2002:a1c:790b:0:b0:3f6:1ac:5feb with SMTP id l11-20020a1c790b000000b003f601ac5febmr4329567wme.16.1684782284967; Mon, 22 May 2023 12:04:44 -0700 (PDT) Received: from redhat.com ([2.52.20.68]) by smtp.gmail.com with ESMTPSA id z10-20020a05600c220a00b003f50e29bce3sm9169360wml.48.2023.05.22.12.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 May 2023 12:04:44 -0700 (PDT) Date: Mon, 22 May 2023 15:04:39 -0400 From: "Michael S. Tsirkin" To: Willem de Bruijn Cc: Shannon Nelson , "Samudrala, Sridhar" , Emil Tantilov , intel-wired-lan@lists.osuosl.org, simon.horman@corigine.com, leon@kernel.org, decot@google.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, "Singhai, Anjali" , "Orr, Michael" Subject: Re: [PATCH iwl-next v4 00/15] Introduce Intel IDPF driver Message-ID: <20230522144241-mutt-send-email-mst@kernel.org> References: <20230508194326.482-1-emil.s.tantilov@intel.com> <20230512023234-mutt-send-email-mst@kernel.org> <6a900cd7-470a-3611-c88a-9f901c56c97f@intel.com> <20230518130452-mutt-send-email-mst@kernel.org> <7969d09e-2b77-c1a7-0e38-f10d61c83638@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, May 19, 2023 at 01:12:43PM -0400, Willem de Bruijn wrote: > On Fri, May 19, 2023 at 12:17 PM Shannon Nelson wrote: > > > > On 5/18/23 4:26 PM, Samudrala, Sridhar wrote: > > > On 5/18/2023 10:10 AM, Michael S. Tsirkin wrote: > > >> On Thu, May 18, 2023 at 09:19:31AM -0700, Samudrala, Sridhar wrote: > > >>> > > >>> > > >>> On 5/11/2023 11:34 PM, Michael S. Tsirkin wrote: > > >>>> On Mon, May 08, 2023 at 12:43:11PM -0700, Emil Tantilov wrote: > > >>>>> This patch series introduces the Intel Infrastructure Data Path > > >>>>> Function > > >>>>> (IDPF) driver. It is used for both physical and virtual functions. > > >>>>> Except > > >>>>> for some of the device operations the rest of the functionality is the > > >>>>> same for both PF and VF. IDPF uses virtchnl version2 opcodes and > > >>>>> structures defined in the virtchnl2 header file which helps the driver > > >>>>> to learn the capabilities and register offsets from the device > > >>>>> Control Plane (CP) instead of assuming the default values. > > >>>> > > >>>> So, is this for merge in the next cycle? Should this be an RFC rather? > > >>>> It seems unlikely that the IDPF specification will be finalized by that > > >>>> time - how are you going to handle any specification changes? > > >>> > > >>> Yes. we would like this driver to be merged in the next cycle(6.5). > > >>> Based on the community feedback on v1 version of the driver, we > > >>> removed all > > >>> references to OASIS standard and at this time this is an intel vendor > > >>> driver. > > >>> > > >>> Links to v1 and v2 discussion threads > > >>> https://lore.kernel.org/netdev/20230329140404.1647925-1-pavan.kumar.linga@intel.com/ > > >>> https://lore.kernel.org/netdev/20230411011354.2619359-1-pavan.kumar.linga@intel.com/ > > >>> > > >>> The v1->v2 change log reflects this update. > > >>> v1 --> v2: link [1] > > >>> * removed the OASIS reference in the commit message to make it clear > > >>> that this is an Intel vendor specific driver > > >> > > >> Yes this makes sense. > > >> > > >> > > >>> Any IDPF specification updates would be handled as part of the > > >>> changes that > > >>> would be required to make this a common standards driver. > > >> > > >> > > >> So my question is, would it make sense to update Kconfig and module name > > >> to be "ipu" or if you prefer "intel-idpf" to make it clear this is > > >> currently an Intel vendor specific driver? And then when you make it a > > >> common standards driver rename it to idpf? The point being to help make > > >> sure users are not confused about whether they got a driver with > > >> or without IDPF updates. It's not critical I guess but seems like a good > > >> idea. WDYT? > > > > > > It would be more disruptive to change the name of the driver. We can > > > update the pci device table, module description and possibly driver > > > version when we are ready to make this a standard driver. > > > So we would prefer not changing the driver name. > > > > More disruptive for who? > > > > I think it would be better to change the name of the one driver now > > before a problem is created in the tree than to leave a point of > > confusion for the rest of the drivers to contend with in the future. > > This discussion is premised on the idea that the drivers will > inevitably fork, with an Intel driver and a non-backward compatible > standardized driver. > > Instead, I expect that the goal is that the future standardized driver > will iterate and support additional features. But that the existing > hardware will continue to be supported, if perhaps with updated > firmware. > > IDPF from the start uses feature negotiation over virtchannel to be > highly configurable. A future driver might deprecate older feature > (variants), while either still continue to support those or require > firmware updates to match the new version. > > Even if the device API would break in a non-backward compatible way, > the same driver can support both versions. Virtio is an example of > this. > > If I'm wrong and for some reason two drivers would have to be > supported, then I'm sure we can figure out a suffix or prefix to the > standard driver that separates it from the existing one. OK let us look at a more specific example. The IDPF TC recently voted to bind to device based on class/programming interface as opposed to device/vendor id. Future driver will likely do this. Current driver only binds to intel's device and vendor id. Assuming this happens, what bothers me is that depending on kernel version, driver idpf.ko either does or does not bind to idpf programming interface. All this is quite imminent. Yes tricks like checking module version to check what is supported is possible, but we are beginning to already develop technical dept and lore and we just started. Simple lsmod|grep -q idpf seems like an easier, more robust and intuitive way than if [[ $(cat /sys/module/idpf/version) == "2.0" ]] then echo "idpf" fi And yes somemore might ship the existing driver during this initial window. Then we get lsmod|grep -q -e idpf -e intel-ipu still seems pretty clean. And hopefully the change will happen within a couple of months so not more than one release will have the intel-ipu name. Of course all this is not earth shatteringly important but still, I'm interested in what others think. -- MST