From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E5AC7EE23 for ; Mon, 22 May 2023 15:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xO3SMyIFoSGkAcAuxzDQ+n5/7eV+yzQkn+crIjyQVgw=; b=psKZv0NfRpTWQQ 0gqVpQk9eQCa6NYq5olLqe3Jc9GrO0WVKRrSA6taxkaVqYf5ZlacvV8ESYHAGSgmlj72gEU3WYXCo pgdoYF5QJzIeTp/FyWg60LDo6V09NvfnxEAyLMDNcYb6dHKT5bL8QLJxF0Q7L8++/2i6fUxT1+sHh RsqryhuJ6oE6XGmsIdZI1TyTSoZFIBRg9niNoV0ZNXzpzpXDI/cRD6Qs8xHCqmNlJhI0gIHyla3WV gKSAshVnQNqS28rRzu7yZTXTBoGwhTYY9Gur6DMjeSqVDA061rVAjnYnMHijtQDT5rw91QjS/FZiC 8wXSfp4aTdMa36iAP4Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q176N-006x5i-2g; Mon, 22 May 2023 15:05:35 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q176K-006x4f-0q; Mon, 22 May 2023 15:05:34 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0E419C000B; Mon, 22 May 2023 15:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684767928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfGqNpqYGcaYDPFm+L0EvwvvX+xtHwS882MQS2NRtaE=; b=P8QdRGGHqZgASUf2kWEbUXEWYZEZrfhHtlq56cohDeT4cvM5/wcqr0XTxEahrzv0fJq8AK ISrfFGc80sWA74k9RLAvfNSm3+7QVA1vcHA099qpLV/eTdLMKcK7l6TKiDlDs9Fz2Sd8Rh iRcg64BxeKzaqyVNGYRyNjnv4fYf//LweLEFqnxQl0Bl+DzvtEueDiFuZguknwf9lH9ceQ 33RKB9ok9NcpdcfJtgUUMeAHk7vpyUK2g//kzt+vRHL0nFcFItzAqfIJqKlUvNeJhK+eTs AG3sJ8Zp7fk3bk+DuUHkBRp41wcekq5hH9a1FM4LAZpfg3XvT+JfGVZoi74gUg== Date: Mon, 22 May 2023 17:05:26 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v4 1/5] mtd: rawnand: meson: fix command sequence for read/write Message-ID: <20230522170526.6486755a@xps-13> In-Reply-To: <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_080532_562131_144EAD4E X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBNb24sIDE1IE1h eSAyMDIzIDEyOjQ0OjM1ICswMzAwOgoKPiBUaGlzIGZpeGVzIHJlYWQvd3JpdGUgZnVuY3Rpb25h bGl0eSBieToKPiAxKSBDaGFuZ2luZyBORkNfQ01EX1JCX0lOVCBiaXQgdmFsdWUuCgpJIGd1ZXNz IHRoaXMgaXMgYSBzZXBhcmF0ZSBmaXgKCj4gMikgQWRkaW5nIGV4dHJhIE5BTkRfQ01EX1NUQVRV UyBjb21tYW5kIG9uIGVhY2ggci93IHJlcXVlc3QuCgpJcyB0aGlzIHJlYWxseSBuZWVkZWQ/IExv b2tzIGxpa2UgeW91J3JlIGRlbGF5aW5nIHRoZSBuZXh0IG9wIG9ubHkuIElzCnVzaW5nIGEgZGVs YXkgZW5vdWdoPyBJZiB5ZXMsIHRoZW4gaXQncyBwcm9iYWJseSB0aGUgd3JvbmcgYXBwcm9hY2gu Cgo+IDMpIEFkZGluZyBleHRyYSBpZGxlIGNvbW1hbmRzIGR1cmluZyByL3cgcmVxdWVzdC4KClF1 ZXN0aW9uIGFib3V0IHRoaXMgYmVsb3csIG1pZ2h0IGFsc28gYmUgYSBwYXRjaCBvbiBpdHMgb3du PwoKPiA0KSBBZGRpbmcgZXh0cmEgTkFORF9DTURfUkVBRDAgb24gZWFjaCByZWFkIHJlcXVlc3Qu Cj4gCj4gV2l0aG91dCB0aGlzIHBhdGNoIGRyaXZlciB3b3JrcyB1bnN0YWJsZSwgZm9yIGV4YW1w bGUgdGhlcmUgYXJlIGEgbG90Cj4gb2YgRUNDIGVycm9ycy4KCkkgYmVsaWV2ZSBhbGwgdGhlIGZp eGVzIHNob3VsZCBiZSBDYydlZCB0byBzdGFibGUsIHBsZWFzZSBhZGQgaW4geW91cgpjb21taXRz OgoKQ2M6IHN0YWJsZUAuLi4KCj4gCj4gRml4ZXM6IDhmYWU4NTZjNTM1MCAoIm10ZDogcmF3bmFu ZDogbWVzb246IGFkZCBzdXBwb3J0IGZvciBBbWxvZ2ljIE5BTkQgZmxhc2ggY29udHJvbGxlciIp Cj4gU3VnZ2VzdGVkLWJ5OiBMaWFuZyBZYW5nIDxsaWFuZy55YW5nQGFtbG9naWMuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEFyc2VuaXkgS3Jhc25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAzMCArKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IDA3 NGUxNDIyNWMwNi4uMmY0ZDhjODQxODZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+IEBAIC0zNyw3ICszNyw3IEBACj4gICNkZWZpbmUgTkZDX0NNRF9TQ1JBTUJMRVJfRU5BQkxF CUJJVCgxOSkKPiAgI2RlZmluZSBORkNfQ01EX1NDUkFNQkxFUl9ESVNBQkxFCTAKPiAgI2RlZmlu ZSBORkNfQ01EX1NIT1JUTU9ERV9ESVNBQkxFCTAKPiAtI2RlZmluZSBORkNfQ01EX1JCX0lOVAkJ QklUKDE0KQo+ICsjZGVmaW5lIE5GQ19DTURfUkJfSU5UICgoMHhiIDw8IDEwKSB8IEJJVCgxOCkg fCBCSVQoMTYpKQo+ICAKPiAgI2RlZmluZSBORkNfQ01EX0dFVF9TSVpFKHgpCSgoKHgpID4+IDIy KSAmIEdFTk1BU0soNCwgMCkpCj4gIAo+IEBAIC0zOTIsNyArMzkyLDcgQEAgc3RhdGljIHZvaWQg bWVzb25fbmZjX3NldF9kYXRhX29vYihzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLAo+ICAJfQo+ICB9 Cj4gIAo+IC1zdGF0aWMgaW50IG1lc29uX25mY19xdWV1ZV9yYihzdHJ1Y3QgbWVzb25fbmZjICpu ZmMsIGludCB0aW1lb3V0X21zKQo+ICtzdGF0aWMgaW50IG1lc29uX25mY19xdWV1ZV9yYihzdHJ1 Y3QgbWVzb25fbmZjICpuZmMsIGludCB0aW1lb3V0X21zLCBpbnQgY21kX3JlYWQwKQo+ICB7Cj4g IAl1MzIgY21kLCBjZmc7Cj4gIAlpbnQgcmV0ID0gMDsKPiBAQCAtNDA3LDE3ICs0MDcsMjkgQEAg c3RhdGljIGludCBtZXNvbl9uZmNfcXVldWVfcmIoc3RydWN0IG1lc29uX25mYyAqbmZjLCBpbnQg dGltZW91dF9tcykKPiAgCj4gIAlyZWluaXRfY29tcGxldGlvbigmbmZjLT5jb21wbGV0aW9uKTsK PiAgCj4gKwljbWQgPSBuZmMtPnBhcmFtLmNoaXBfc2VsZWN0IHwgTkZDX0NNRF9DTEUgfCBOQU5E X0NNRF9TVEFUVVM7Cj4gKwl3cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JFR19DTUQp Owo+ICsJbWVzb25fbmZjX2NtZF9pZGxlKG5mYywgNSk7CgpXaHkgNSBhbmQgMiBiZWxvdz8gVGhl eSBsb29rIGxpa2UgbWFnaWMgdmFsdWVzLiBJcyB0aGlzIHRvdGFsbHkKZXhwZXJpbWVudGFsPwoK PiArCj4gIAkvKiB1c2UgdGhlIG1heCBlcmFzZSB0aW1lIGFzIHRoZSBtYXhpbXVtIGNsb2NrIGZv ciB3YWl0aW5nIFIvQiAqLwo+IC0JY21kID0gTkZDX0NNRF9SQiB8IE5GQ19DTURfUkJfSU5UCj4g LQkJfCBuZmMtPnBhcmFtLmNoaXBfc2VsZWN0IHwgbmZjLT50aW1pbmcudGJlcnNfbWF4OwoKVGhp cyBpcyBub3QgZG9jdW1lbnRlZCBpbiB0aGUgY29tbWl0IGxvZywgaXMgaXQ/Cgo+ICsJY21kID0g TkZDX0NNRF9SQiB8IE5GQ19DTURfUkJfSU5UIHwgbmZjLT50aW1pbmcudGJlcnNfbWF4Owo+ICAJ d3JpdGVsKGNtZCwgbmZjLT5yZWdfYmFzZSArIE5GQ19SRUdfQ01EKTsKPiArCW1lc29uX25mY19j bWRfaWRsZShuZmMsIDIpOwo+ICAKPiAgCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91 dCgmbmZjLT5jb21wbGV0aW9uLAo+ICAJCQkJCSAgbXNlY3NfdG9famlmZmllcyh0aW1lb3V0X21z KSk7Cj4gIAlpZiAocmV0ID09IDApCj4gLQkJcmV0ID0gLTE7Cj4gKwkJcmV0dXJuIC0xOwoKUGxl YXNlIHVzZSByZWFsIGVycm9yIGNvZGVzLCBzdWNoIGFzIEVUSU1FRE9VVC4KCj4gIAo+IC0JcmV0 dXJuIHJldDsKPiArCWlmICghY21kX3JlYWQwKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWNtZCA9 IG5mYy0+cGFyYW0uY2hpcF9zZWxlY3QgfCBORkNfQ01EX0NMRSB8IE5BTkRfQ01EX1JFQUQwOwoK VGhpcyBsb29rcyByZWFsbHkgd3JvbmcsIEkgZG9uJ3QgZ2V0IHdoeSB5b3Ugd291bGQgbmVlZCB0 byBzZW5kIGFuCmV4cGVuc2l2ZSBSRUFEMCBjb21tYW5kLgoKPiArCXdyaXRlbChjbWQsIG5mYy0+ cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7Cj4gKwltZXNvbl9uZmNfZHJhaW5fY21kKG5mYyk7Cj4g KwltZXNvbl9uZmNfd2FpdF9jbWRfZmluaXNoKG5mYywgQ01EX0ZJRk9fRU1QVFlfVElNRU9VVCk7 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIG1lc29uX25mY19zZXRf dXNlcl9ieXRlKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpvb2JfYnVmKQo+IEBAIC02MjMs NyArNjM1LDcgQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcndfY21kX3ByZXBhcmVfYW5kX2V4ZWN1 dGUoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCWlmIChpbikgewo+ICAJCW5mYy0+Y21kZmlm by5ydy5jbWQxID0gY3MgfCBORkNfQ01EX0NMRSB8IE5BTkRfQ01EX1JFQURTVEFSVDsKPiAgCQl3 cml0ZWwobmZjLT5jbWRmaWZvLnJ3LmNtZDEsIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7 Cj4gLQkJbWVzb25fbmZjX3F1ZXVlX3JiKG5mYywgUFNFQ19UT19NU0VDKHNkci0+dFJfbWF4KSk7 Cj4gKwkJbWVzb25fbmZjX3F1ZXVlX3JiKG5mYywgUFNFQ19UT19NU0VDKHNkci0+dFJfbWF4KSwg MSk7Cj4gIAl9IGVsc2Ugewo+ICAJCW1lc29uX25mY19jbWRfaWRsZShuZmMsIG5mYy0+dGltaW5n LnRhZGwpOwo+ICAJfQo+IEBAIC02NjksNyArNjgxLDcgQEAgc3RhdGljIGludCBtZXNvbl9uZmNf d3JpdGVfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCj4gIAljbWQgPSBuZmMt PnBhcmFtLmNoaXBfc2VsZWN0IHwgTkZDX0NNRF9DTEUgfCBOQU5EX0NNRF9QQUdFUFJPRzsKPiAg CXdyaXRlbChjbWQsIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7Cj4gLQltZXNvbl9uZmNf cXVldWVfcmIobmZjLCBQU0VDX1RPX01TRUMoc2RyLT50UFJPR19tYXgpKTsKPiArCW1lc29uX25m Y19xdWV1ZV9yYihuZmMsIFBTRUNfVE9fTVNFQyhzZHItPnRQUk9HX21heCksIDApOwo+ICAKPiAg CW1lc29uX25mY19kbWFfYnVmZmVyX3JlbGVhc2UobmFuZCwgZGF0YV9sZW4sIGluZm9fbGVuLCBE TUFfVE9fREVWSUNFKTsKPiAgCj4gQEAgLTk1Miw3ICs5NjQsNyBAQCBzdGF0aWMgaW50IG1lc29u X25mY19leGVjX29wKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAkJCWJyZWFrOwo+ICAKPiAg CQljYXNlIE5BTkRfT1BfV0FJVFJEWV9JTlNUUjoKPiAtCQkJbWVzb25fbmZjX3F1ZXVlX3JiKG5m YywgaW5zdHItPmN0eC53YWl0cmR5LnRpbWVvdXRfbXMpOwo+ICsJCQltZXNvbl9uZmNfcXVldWVf cmIobmZjLCBpbnN0ci0+Y3R4LndhaXRyZHkudGltZW91dF9tcywgMSk7Cj4gIAkJCWlmIChpbnN0 ci0+ZGVsYXlfbnMpCj4gIAkJCQltZXNvbl9uZmNfY21kX2lkbGUobmZjLCBkZWxheV9pZGxlKTsK PiAgCQkJYnJlYWs7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1h bWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79259C7EE23 for ; Mon, 22 May 2023 15:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zVmjtF8dgnU+yc0Pl8hjVz4i25FZci5IdeHEcfryXTc=; b=eU4dXNPJjnThqH 0ovfj6Jr7cS4qyJtjOoou3Q38v2hXSi4oWmwGnLo+RediEqIxyWux1Uqw1zHTG2u2wCR3QItv17EP 4hHpScxfyA/Cp9q11cYUtJJypQim0jpy/euhKBA59Xl2lRq++51uqraadhTYhJEIrEBH3LcBPOgUa E/oMN1OJ8sjOvR+EMB1H2x+1CgQrabSgBAGnezIgkZPk4CZjITjc4kuzPjsJTLp6CH1lU7K599vrk Ip5nsGpEtc2N9QlgvJTUIpmRllWQcL/4YQEtBA3EpmElL52RiQtUDjGd7dzDw/qQ88PML6R/eFjVu 3YuB9j9kAo+9r5mYcpuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q176O-006x65-2K; Mon, 22 May 2023 15:05:36 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q176K-006x4f-0q; Mon, 22 May 2023 15:05:34 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0E419C000B; Mon, 22 May 2023 15:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684767928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfGqNpqYGcaYDPFm+L0EvwvvX+xtHwS882MQS2NRtaE=; b=P8QdRGGHqZgASUf2kWEbUXEWYZEZrfhHtlq56cohDeT4cvM5/wcqr0XTxEahrzv0fJq8AK ISrfFGc80sWA74k9RLAvfNSm3+7QVA1vcHA099qpLV/eTdLMKcK7l6TKiDlDs9Fz2Sd8Rh iRcg64BxeKzaqyVNGYRyNjnv4fYf//LweLEFqnxQl0Bl+DzvtEueDiFuZguknwf9lH9ceQ 33RKB9ok9NcpdcfJtgUUMeAHk7vpyUK2g//kzt+vRHL0nFcFItzAqfIJqKlUvNeJhK+eTs AG3sJ8Zp7fk3bk+DuUHkBRp41wcekq5hH9a1FM4LAZpfg3XvT+JfGVZoi74gUg== Date: Mon, 22 May 2023 17:05:26 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v4 1/5] mtd: rawnand: meson: fix command sequence for read/write Message-ID: <20230522170526.6486755a@xps-13> In-Reply-To: <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_080532_562131_144EAD4E X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBNb24sIDE1IE1h eSAyMDIzIDEyOjQ0OjM1ICswMzAwOgoKPiBUaGlzIGZpeGVzIHJlYWQvd3JpdGUgZnVuY3Rpb25h bGl0eSBieToKPiAxKSBDaGFuZ2luZyBORkNfQ01EX1JCX0lOVCBiaXQgdmFsdWUuCgpJIGd1ZXNz IHRoaXMgaXMgYSBzZXBhcmF0ZSBmaXgKCj4gMikgQWRkaW5nIGV4dHJhIE5BTkRfQ01EX1NUQVRV UyBjb21tYW5kIG9uIGVhY2ggci93IHJlcXVlc3QuCgpJcyB0aGlzIHJlYWxseSBuZWVkZWQ/IExv b2tzIGxpa2UgeW91J3JlIGRlbGF5aW5nIHRoZSBuZXh0IG9wIG9ubHkuIElzCnVzaW5nIGEgZGVs YXkgZW5vdWdoPyBJZiB5ZXMsIHRoZW4gaXQncyBwcm9iYWJseSB0aGUgd3JvbmcgYXBwcm9hY2gu Cgo+IDMpIEFkZGluZyBleHRyYSBpZGxlIGNvbW1hbmRzIGR1cmluZyByL3cgcmVxdWVzdC4KClF1 ZXN0aW9uIGFib3V0IHRoaXMgYmVsb3csIG1pZ2h0IGFsc28gYmUgYSBwYXRjaCBvbiBpdHMgb3du PwoKPiA0KSBBZGRpbmcgZXh0cmEgTkFORF9DTURfUkVBRDAgb24gZWFjaCByZWFkIHJlcXVlc3Qu Cj4gCj4gV2l0aG91dCB0aGlzIHBhdGNoIGRyaXZlciB3b3JrcyB1bnN0YWJsZSwgZm9yIGV4YW1w bGUgdGhlcmUgYXJlIGEgbG90Cj4gb2YgRUNDIGVycm9ycy4KCkkgYmVsaWV2ZSBhbGwgdGhlIGZp eGVzIHNob3VsZCBiZSBDYydlZCB0byBzdGFibGUsIHBsZWFzZSBhZGQgaW4geW91cgpjb21taXRz OgoKQ2M6IHN0YWJsZUAuLi4KCj4gCj4gRml4ZXM6IDhmYWU4NTZjNTM1MCAoIm10ZDogcmF3bmFu ZDogbWVzb246IGFkZCBzdXBwb3J0IGZvciBBbWxvZ2ljIE5BTkQgZmxhc2ggY29udHJvbGxlciIp Cj4gU3VnZ2VzdGVkLWJ5OiBMaWFuZyBZYW5nIDxsaWFuZy55YW5nQGFtbG9naWMuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEFyc2VuaXkgS3Jhc25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAzMCArKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IDA3 NGUxNDIyNWMwNi4uMmY0ZDhjODQxODZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+IEBAIC0zNyw3ICszNyw3IEBACj4gICNkZWZpbmUgTkZDX0NNRF9TQ1JBTUJMRVJfRU5BQkxF CUJJVCgxOSkKPiAgI2RlZmluZSBORkNfQ01EX1NDUkFNQkxFUl9ESVNBQkxFCTAKPiAgI2RlZmlu ZSBORkNfQ01EX1NIT1JUTU9ERV9ESVNBQkxFCTAKPiAtI2RlZmluZSBORkNfQ01EX1JCX0lOVAkJ QklUKDE0KQo+ICsjZGVmaW5lIE5GQ19DTURfUkJfSU5UICgoMHhiIDw8IDEwKSB8IEJJVCgxOCkg fCBCSVQoMTYpKQo+ICAKPiAgI2RlZmluZSBORkNfQ01EX0dFVF9TSVpFKHgpCSgoKHgpID4+IDIy KSAmIEdFTk1BU0soNCwgMCkpCj4gIAo+IEBAIC0zOTIsNyArMzkyLDcgQEAgc3RhdGljIHZvaWQg bWVzb25fbmZjX3NldF9kYXRhX29vYihzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLAo+ICAJfQo+ICB9 Cj4gIAo+IC1zdGF0aWMgaW50IG1lc29uX25mY19xdWV1ZV9yYihzdHJ1Y3QgbWVzb25fbmZjICpu ZmMsIGludCB0aW1lb3V0X21zKQo+ICtzdGF0aWMgaW50IG1lc29uX25mY19xdWV1ZV9yYihzdHJ1 Y3QgbWVzb25fbmZjICpuZmMsIGludCB0aW1lb3V0X21zLCBpbnQgY21kX3JlYWQwKQo+ICB7Cj4g IAl1MzIgY21kLCBjZmc7Cj4gIAlpbnQgcmV0ID0gMDsKPiBAQCAtNDA3LDE3ICs0MDcsMjkgQEAg c3RhdGljIGludCBtZXNvbl9uZmNfcXVldWVfcmIoc3RydWN0IG1lc29uX25mYyAqbmZjLCBpbnQg dGltZW91dF9tcykKPiAgCj4gIAlyZWluaXRfY29tcGxldGlvbigmbmZjLT5jb21wbGV0aW9uKTsK PiAgCj4gKwljbWQgPSBuZmMtPnBhcmFtLmNoaXBfc2VsZWN0IHwgTkZDX0NNRF9DTEUgfCBOQU5E X0NNRF9TVEFUVVM7Cj4gKwl3cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JFR19DTUQp Owo+ICsJbWVzb25fbmZjX2NtZF9pZGxlKG5mYywgNSk7CgpXaHkgNSBhbmQgMiBiZWxvdz8gVGhl eSBsb29rIGxpa2UgbWFnaWMgdmFsdWVzLiBJcyB0aGlzIHRvdGFsbHkKZXhwZXJpbWVudGFsPwoK PiArCj4gIAkvKiB1c2UgdGhlIG1heCBlcmFzZSB0aW1lIGFzIHRoZSBtYXhpbXVtIGNsb2NrIGZv ciB3YWl0aW5nIFIvQiAqLwo+IC0JY21kID0gTkZDX0NNRF9SQiB8IE5GQ19DTURfUkJfSU5UCj4g LQkJfCBuZmMtPnBhcmFtLmNoaXBfc2VsZWN0IHwgbmZjLT50aW1pbmcudGJlcnNfbWF4OwoKVGhp cyBpcyBub3QgZG9jdW1lbnRlZCBpbiB0aGUgY29tbWl0IGxvZywgaXMgaXQ/Cgo+ICsJY21kID0g TkZDX0NNRF9SQiB8IE5GQ19DTURfUkJfSU5UIHwgbmZjLT50aW1pbmcudGJlcnNfbWF4Owo+ICAJ d3JpdGVsKGNtZCwgbmZjLT5yZWdfYmFzZSArIE5GQ19SRUdfQ01EKTsKPiArCW1lc29uX25mY19j bWRfaWRsZShuZmMsIDIpOwo+ICAKPiAgCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91 dCgmbmZjLT5jb21wbGV0aW9uLAo+ICAJCQkJCSAgbXNlY3NfdG9famlmZmllcyh0aW1lb3V0X21z KSk7Cj4gIAlpZiAocmV0ID09IDApCj4gLQkJcmV0ID0gLTE7Cj4gKwkJcmV0dXJuIC0xOwoKUGxl YXNlIHVzZSByZWFsIGVycm9yIGNvZGVzLCBzdWNoIGFzIEVUSU1FRE9VVC4KCj4gIAo+IC0JcmV0 dXJuIHJldDsKPiArCWlmICghY21kX3JlYWQwKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWNtZCA9 IG5mYy0+cGFyYW0uY2hpcF9zZWxlY3QgfCBORkNfQ01EX0NMRSB8IE5BTkRfQ01EX1JFQUQwOwoK VGhpcyBsb29rcyByZWFsbHkgd3JvbmcsIEkgZG9uJ3QgZ2V0IHdoeSB5b3Ugd291bGQgbmVlZCB0 byBzZW5kIGFuCmV4cGVuc2l2ZSBSRUFEMCBjb21tYW5kLgoKPiArCXdyaXRlbChjbWQsIG5mYy0+ cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7Cj4gKwltZXNvbl9uZmNfZHJhaW5fY21kKG5mYyk7Cj4g KwltZXNvbl9uZmNfd2FpdF9jbWRfZmluaXNoKG5mYywgQ01EX0ZJRk9fRU1QVFlfVElNRU9VVCk7 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIG1lc29uX25mY19zZXRf dXNlcl9ieXRlKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpvb2JfYnVmKQo+IEBAIC02MjMs NyArNjM1LDcgQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcndfY21kX3ByZXBhcmVfYW5kX2V4ZWN1 dGUoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCWlmIChpbikgewo+ICAJCW5mYy0+Y21kZmlm by5ydy5jbWQxID0gY3MgfCBORkNfQ01EX0NMRSB8IE5BTkRfQ01EX1JFQURTVEFSVDsKPiAgCQl3 cml0ZWwobmZjLT5jbWRmaWZvLnJ3LmNtZDEsIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7 Cj4gLQkJbWVzb25fbmZjX3F1ZXVlX3JiKG5mYywgUFNFQ19UT19NU0VDKHNkci0+dFJfbWF4KSk7 Cj4gKwkJbWVzb25fbmZjX3F1ZXVlX3JiKG5mYywgUFNFQ19UT19NU0VDKHNkci0+dFJfbWF4KSwg MSk7Cj4gIAl9IGVsc2Ugewo+ICAJCW1lc29uX25mY19jbWRfaWRsZShuZmMsIG5mYy0+dGltaW5n LnRhZGwpOwo+ICAJfQo+IEBAIC02NjksNyArNjgxLDcgQEAgc3RhdGljIGludCBtZXNvbl9uZmNf d3JpdGVfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCj4gIAljbWQgPSBuZmMt PnBhcmFtLmNoaXBfc2VsZWN0IHwgTkZDX0NNRF9DTEUgfCBOQU5EX0NNRF9QQUdFUFJPRzsKPiAg CXdyaXRlbChjbWQsIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7Cj4gLQltZXNvbl9uZmNf cXVldWVfcmIobmZjLCBQU0VDX1RPX01TRUMoc2RyLT50UFJPR19tYXgpKTsKPiArCW1lc29uX25m Y19xdWV1ZV9yYihuZmMsIFBTRUNfVE9fTVNFQyhzZHItPnRQUk9HX21heCksIDApOwo+ICAKPiAg CW1lc29uX25mY19kbWFfYnVmZmVyX3JlbGVhc2UobmFuZCwgZGF0YV9sZW4sIGluZm9fbGVuLCBE TUFfVE9fREVWSUNFKTsKPiAgCj4gQEAgLTk1Miw3ICs5NjQsNyBAQCBzdGF0aWMgaW50IG1lc29u X25mY19leGVjX29wKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAkJCWJyZWFrOwo+ICAKPiAg CQljYXNlIE5BTkRfT1BfV0FJVFJEWV9JTlNUUjoKPiAtCQkJbWVzb25fbmZjX3F1ZXVlX3JiKG5m YywgaW5zdHItPmN0eC53YWl0cmR5LnRpbWVvdXRfbXMpOwo+ICsJCQltZXNvbl9uZmNfcXVldWVf cmIobmZjLCBpbnN0ci0+Y3R4LndhaXRyZHkudGltZW91dF9tcywgMSk7Cj4gIAkJCWlmIChpbnN0 ci0+ZGVsYXlfbnMpCj4gIAkJCQltZXNvbl9uZmNfY21kX2lkbGUobmZjLCBkZWxheV9pZGxlKTsK PiAgCQkJYnJlYWs7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGlu ZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt bXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D5C0C77B73 for ; Mon, 22 May 2023 15:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mmwnMuNb43cRgoxfPYldDiRUQowlfhz8CuNsfHFDrLs=; b=vAt3dnJICgqUtb Wuaasmuw15ZmpMUAsRwENrKdraQ73xAlwvEuoOWTpR4VBM3cLhZEVZy9fO85581InQAbP9Xd5PYpK PImIiXrpsQ6Qh6H14OAQUB/a9Aw3RAiXpuD3KEagDM/RFoKSNq49kRC0Y3pODtE6HISd3Uhl60npW cq2wdiaHuHSAvIDmg6UL1h4y3gbhnFYlAB3B4o0kXmItKe0E+1qOUy1sP5c85d32dHrNWoSbRlS9N Zfi0PstSw5nk6TSeZEmlvF/vSb05djSA54jfdXFL25Wi1lwSLwhtlxZ/DexN8raKbdKQrrh4diEta YTzqKmwMDElCi8XYoGcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q176O-006x5r-0b; Mon, 22 May 2023 15:05:36 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q176K-006x4f-0q; Mon, 22 May 2023 15:05:34 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0E419C000B; Mon, 22 May 2023 15:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684767928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfGqNpqYGcaYDPFm+L0EvwvvX+xtHwS882MQS2NRtaE=; b=P8QdRGGHqZgASUf2kWEbUXEWYZEZrfhHtlq56cohDeT4cvM5/wcqr0XTxEahrzv0fJq8AK ISrfFGc80sWA74k9RLAvfNSm3+7QVA1vcHA099qpLV/eTdLMKcK7l6TKiDlDs9Fz2Sd8Rh iRcg64BxeKzaqyVNGYRyNjnv4fYf//LweLEFqnxQl0Bl+DzvtEueDiFuZguknwf9lH9ceQ 33RKB9ok9NcpdcfJtgUUMeAHk7vpyUK2g//kzt+vRHL0nFcFItzAqfIJqKlUvNeJhK+eTs AG3sJ8Zp7fk3bk+DuUHkBRp41wcekq5hH9a1FM4LAZpfg3XvT+JfGVZoi74gUg== Date: Mon, 22 May 2023 17:05:26 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v4 1/5] mtd: rawnand: meson: fix command sequence for read/write Message-ID: <20230522170526.6486755a@xps-13> In-Reply-To: <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_080532_562131_144EAD4E X-CRM114-Status: GOOD ( 23.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBNb24sIDE1IE1h eSAyMDIzIDEyOjQ0OjM1ICswMzAwOgoKPiBUaGlzIGZpeGVzIHJlYWQvd3JpdGUgZnVuY3Rpb25h bGl0eSBieToKPiAxKSBDaGFuZ2luZyBORkNfQ01EX1JCX0lOVCBiaXQgdmFsdWUuCgpJIGd1ZXNz IHRoaXMgaXMgYSBzZXBhcmF0ZSBmaXgKCj4gMikgQWRkaW5nIGV4dHJhIE5BTkRfQ01EX1NUQVRV UyBjb21tYW5kIG9uIGVhY2ggci93IHJlcXVlc3QuCgpJcyB0aGlzIHJlYWxseSBuZWVkZWQ/IExv b2tzIGxpa2UgeW91J3JlIGRlbGF5aW5nIHRoZSBuZXh0IG9wIG9ubHkuIElzCnVzaW5nIGEgZGVs YXkgZW5vdWdoPyBJZiB5ZXMsIHRoZW4gaXQncyBwcm9iYWJseSB0aGUgd3JvbmcgYXBwcm9hY2gu Cgo+IDMpIEFkZGluZyBleHRyYSBpZGxlIGNvbW1hbmRzIGR1cmluZyByL3cgcmVxdWVzdC4KClF1 ZXN0aW9uIGFib3V0IHRoaXMgYmVsb3csIG1pZ2h0IGFsc28gYmUgYSBwYXRjaCBvbiBpdHMgb3du PwoKPiA0KSBBZGRpbmcgZXh0cmEgTkFORF9DTURfUkVBRDAgb24gZWFjaCByZWFkIHJlcXVlc3Qu Cj4gCj4gV2l0aG91dCB0aGlzIHBhdGNoIGRyaXZlciB3b3JrcyB1bnN0YWJsZSwgZm9yIGV4YW1w bGUgdGhlcmUgYXJlIGEgbG90Cj4gb2YgRUNDIGVycm9ycy4KCkkgYmVsaWV2ZSBhbGwgdGhlIGZp eGVzIHNob3VsZCBiZSBDYydlZCB0byBzdGFibGUsIHBsZWFzZSBhZGQgaW4geW91cgpjb21taXRz OgoKQ2M6IHN0YWJsZUAuLi4KCj4gCj4gRml4ZXM6IDhmYWU4NTZjNTM1MCAoIm10ZDogcmF3bmFu ZDogbWVzb246IGFkZCBzdXBwb3J0IGZvciBBbWxvZ2ljIE5BTkQgZmxhc2ggY29udHJvbGxlciIp Cj4gU3VnZ2VzdGVkLWJ5OiBMaWFuZyBZYW5nIDxsaWFuZy55YW5nQGFtbG9naWMuY29tPgo+IFNp Z25lZC1vZmYtYnk6IEFyc2VuaXkgS3Jhc25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ IC0tLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAzMCArKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+IGluZGV4IDA3 NGUxNDIyNWMwNi4uMmY0ZDhjODQxODZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQv cmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQu Ywo+IEBAIC0zNyw3ICszNyw3IEBACj4gICNkZWZpbmUgTkZDX0NNRF9TQ1JBTUJMRVJfRU5BQkxF CUJJVCgxOSkKPiAgI2RlZmluZSBORkNfQ01EX1NDUkFNQkxFUl9ESVNBQkxFCTAKPiAgI2RlZmlu ZSBORkNfQ01EX1NIT1JUTU9ERV9ESVNBQkxFCTAKPiAtI2RlZmluZSBORkNfQ01EX1JCX0lOVAkJ QklUKDE0KQo+ICsjZGVmaW5lIE5GQ19DTURfUkJfSU5UICgoMHhiIDw8IDEwKSB8IEJJVCgxOCkg fCBCSVQoMTYpKQo+ICAKPiAgI2RlZmluZSBORkNfQ01EX0dFVF9TSVpFKHgpCSgoKHgpID4+IDIy KSAmIEdFTk1BU0soNCwgMCkpCj4gIAo+IEBAIC0zOTIsNyArMzkyLDcgQEAgc3RhdGljIHZvaWQg bWVzb25fbmZjX3NldF9kYXRhX29vYihzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLAo+ICAJfQo+ICB9 Cj4gIAo+IC1zdGF0aWMgaW50IG1lc29uX25mY19xdWV1ZV9yYihzdHJ1Y3QgbWVzb25fbmZjICpu ZmMsIGludCB0aW1lb3V0X21zKQo+ICtzdGF0aWMgaW50IG1lc29uX25mY19xdWV1ZV9yYihzdHJ1 Y3QgbWVzb25fbmZjICpuZmMsIGludCB0aW1lb3V0X21zLCBpbnQgY21kX3JlYWQwKQo+ICB7Cj4g IAl1MzIgY21kLCBjZmc7Cj4gIAlpbnQgcmV0ID0gMDsKPiBAQCAtNDA3LDE3ICs0MDcsMjkgQEAg c3RhdGljIGludCBtZXNvbl9uZmNfcXVldWVfcmIoc3RydWN0IG1lc29uX25mYyAqbmZjLCBpbnQg dGltZW91dF9tcykKPiAgCj4gIAlyZWluaXRfY29tcGxldGlvbigmbmZjLT5jb21wbGV0aW9uKTsK PiAgCj4gKwljbWQgPSBuZmMtPnBhcmFtLmNoaXBfc2VsZWN0IHwgTkZDX0NNRF9DTEUgfCBOQU5E X0NNRF9TVEFUVVM7Cj4gKwl3cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JFR19DTUQp Owo+ICsJbWVzb25fbmZjX2NtZF9pZGxlKG5mYywgNSk7CgpXaHkgNSBhbmQgMiBiZWxvdz8gVGhl eSBsb29rIGxpa2UgbWFnaWMgdmFsdWVzLiBJcyB0aGlzIHRvdGFsbHkKZXhwZXJpbWVudGFsPwoK PiArCj4gIAkvKiB1c2UgdGhlIG1heCBlcmFzZSB0aW1lIGFzIHRoZSBtYXhpbXVtIGNsb2NrIGZv ciB3YWl0aW5nIFIvQiAqLwo+IC0JY21kID0gTkZDX0NNRF9SQiB8IE5GQ19DTURfUkJfSU5UCj4g LQkJfCBuZmMtPnBhcmFtLmNoaXBfc2VsZWN0IHwgbmZjLT50aW1pbmcudGJlcnNfbWF4OwoKVGhp cyBpcyBub3QgZG9jdW1lbnRlZCBpbiB0aGUgY29tbWl0IGxvZywgaXMgaXQ/Cgo+ICsJY21kID0g TkZDX0NNRF9SQiB8IE5GQ19DTURfUkJfSU5UIHwgbmZjLT50aW1pbmcudGJlcnNfbWF4Owo+ICAJ d3JpdGVsKGNtZCwgbmZjLT5yZWdfYmFzZSArIE5GQ19SRUdfQ01EKTsKPiArCW1lc29uX25mY19j bWRfaWRsZShuZmMsIDIpOwo+ICAKPiAgCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91 dCgmbmZjLT5jb21wbGV0aW9uLAo+ICAJCQkJCSAgbXNlY3NfdG9famlmZmllcyh0aW1lb3V0X21z KSk7Cj4gIAlpZiAocmV0ID09IDApCj4gLQkJcmV0ID0gLTE7Cj4gKwkJcmV0dXJuIC0xOwoKUGxl YXNlIHVzZSByZWFsIGVycm9yIGNvZGVzLCBzdWNoIGFzIEVUSU1FRE9VVC4KCj4gIAo+IC0JcmV0 dXJuIHJldDsKPiArCWlmICghY21kX3JlYWQwKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWNtZCA9 IG5mYy0+cGFyYW0uY2hpcF9zZWxlY3QgfCBORkNfQ01EX0NMRSB8IE5BTkRfQ01EX1JFQUQwOwoK VGhpcyBsb29rcyByZWFsbHkgd3JvbmcsIEkgZG9uJ3QgZ2V0IHdoeSB5b3Ugd291bGQgbmVlZCB0 byBzZW5kIGFuCmV4cGVuc2l2ZSBSRUFEMCBjb21tYW5kLgoKPiArCXdyaXRlbChjbWQsIG5mYy0+ cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7Cj4gKwltZXNvbl9uZmNfZHJhaW5fY21kKG5mYyk7Cj4g KwltZXNvbl9uZmNfd2FpdF9jbWRfZmluaXNoKG5mYywgQ01EX0ZJRk9fRU1QVFlfVElNRU9VVCk7 Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIG1lc29uX25mY19zZXRf dXNlcl9ieXRlKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4ICpvb2JfYnVmKQo+IEBAIC02MjMs NyArNjM1LDcgQEAgc3RhdGljIGludCBtZXNvbl9uZmNfcndfY21kX3ByZXBhcmVfYW5kX2V4ZWN1 dGUoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCWlmIChpbikgewo+ICAJCW5mYy0+Y21kZmlm by5ydy5jbWQxID0gY3MgfCBORkNfQ01EX0NMRSB8IE5BTkRfQ01EX1JFQURTVEFSVDsKPiAgCQl3 cml0ZWwobmZjLT5jbWRmaWZvLnJ3LmNtZDEsIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7 Cj4gLQkJbWVzb25fbmZjX3F1ZXVlX3JiKG5mYywgUFNFQ19UT19NU0VDKHNkci0+dFJfbWF4KSk7 Cj4gKwkJbWVzb25fbmZjX3F1ZXVlX3JiKG5mYywgUFNFQ19UT19NU0VDKHNkci0+dFJfbWF4KSwg MSk7Cj4gIAl9IGVsc2Ugewo+ICAJCW1lc29uX25mY19jbWRfaWRsZShuZmMsIG5mYy0+dGltaW5n LnRhZGwpOwo+ICAJfQo+IEBAIC02NjksNyArNjgxLDcgQEAgc3RhdGljIGludCBtZXNvbl9uZmNf d3JpdGVfcGFnZV9zdWIoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCj4gIAljbWQgPSBuZmMt PnBhcmFtLmNoaXBfc2VsZWN0IHwgTkZDX0NNRF9DTEUgfCBOQU5EX0NNRF9QQUdFUFJPRzsKPiAg CXdyaXRlbChjbWQsIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVHX0NNRCk7Cj4gLQltZXNvbl9uZmNf cXVldWVfcmIobmZjLCBQU0VDX1RPX01TRUMoc2RyLT50UFJPR19tYXgpKTsKPiArCW1lc29uX25m Y19xdWV1ZV9yYihuZmMsIFBTRUNfVE9fTVNFQyhzZHItPnRQUk9HX21heCksIDApOwo+ICAKPiAg CW1lc29uX25mY19kbWFfYnVmZmVyX3JlbGVhc2UobmFuZCwgZGF0YV9sZW4sIGluZm9fbGVuLCBE TUFfVE9fREVWSUNFKTsKPiAgCj4gQEAgLTk1Miw3ICs5NjQsNyBAQCBzdGF0aWMgaW50IG1lc29u X25mY19leGVjX29wKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAkJCWJyZWFrOwo+ICAKPiAg CQljYXNlIE5BTkRfT1BfV0FJVFJEWV9JTlNUUjoKPiAtCQkJbWVzb25fbmZjX3F1ZXVlX3JiKG5m YywgaW5zdHItPmN0eC53YWl0cmR5LnRpbWVvdXRfbXMpOwo+ICsJCQltZXNvbl9uZmNfcXVldWVf cmIobmZjLCBpbnN0ci0+Y3R4LndhaXRyZHkudGltZW91dF9tcywgMSk7Cj4gIAkJCWlmIChpbnN0 ci0+ZGVsYXlfbnMpCj4gIAkJCQltZXNvbl9uZmNfY21kX2lkbGUobmZjLCBkZWxheV9pZGxlKTsK PiAgCQkJYnJlYWs7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BFE9C7EE26 for ; Mon, 22 May 2023 15:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234514AbjEVPGE (ORCPT ); Mon, 22 May 2023 11:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234510AbjEVPFs (ORCPT ); Mon, 22 May 2023 11:05:48 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0D8610F6 for ; Mon, 22 May 2023 08:05:30 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0E419C000B; Mon, 22 May 2023 15:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684767928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfGqNpqYGcaYDPFm+L0EvwvvX+xtHwS882MQS2NRtaE=; b=P8QdRGGHqZgASUf2kWEbUXEWYZEZrfhHtlq56cohDeT4cvM5/wcqr0XTxEahrzv0fJq8AK ISrfFGc80sWA74k9RLAvfNSm3+7QVA1vcHA099qpLV/eTdLMKcK7l6TKiDlDs9Fz2Sd8Rh iRcg64BxeKzaqyVNGYRyNjnv4fYf//LweLEFqnxQl0Bl+DzvtEueDiFuZguknwf9lH9ceQ 33RKB9ok9NcpdcfJtgUUMeAHk7vpyUK2g//kzt+vRHL0nFcFItzAqfIJqKlUvNeJhK+eTs AG3sJ8Zp7fk3bk+DuUHkBRp41wcekq5hH9a1FM4LAZpfg3XvT+JfGVZoi74gUg== Date: Mon, 22 May 2023 17:05:26 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Yixun Lan , Jianxin Pan , , , , , , Subject: Re: [PATCH v4 1/5] mtd: rawnand: meson: fix command sequence for read/write Message-ID: <20230522170526.6486755a@xps-13> In-Reply-To: <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-2-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, AVKrasnov@sberdevices.ru wrote on Mon, 15 May 2023 12:44:35 +0300: > This fixes read/write functionality by: > 1) Changing NFC_CMD_RB_INT bit value. I guess this is a separate fix > 2) Adding extra NAND_CMD_STATUS command on each r/w request. Is this really needed? Looks like you're delaying the next op only. Is using a delay enough? If yes, then it's probably the wrong approach. > 3) Adding extra idle commands during r/w request. Question about this below, might also be a patch on its own? > 4) Adding extra NAND_CMD_READ0 on each read request. >=20 > Without this patch driver works unstable, for example there are a lot > of ECC errors. I believe all the fixes should be Cc'ed to stable, please add in your commits: Cc: stable@... >=20 > Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND f= lash controller") > Suggested-by: Liang Yang > Signed-off-by: Arseniy Krasnov > --- > drivers/mtd/nand/raw/meson_nand.c | 30 +++++++++++++++++++++--------- > 1 file changed, 21 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index 074e14225c06..2f4d8c84186b 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -37,7 +37,7 @@ > #define NFC_CMD_SCRAMBLER_ENABLE BIT(19) > #define NFC_CMD_SCRAMBLER_DISABLE 0 > #define NFC_CMD_SHORTMODE_DISABLE 0 > -#define NFC_CMD_RB_INT BIT(14) > +#define NFC_CMD_RB_INT ((0xb << 10) | BIT(18) | BIT(16)) > =20 > #define NFC_CMD_GET_SIZE(x) (((x) >> 22) & GENMASK(4, 0)) > =20 > @@ -392,7 +392,7 @@ static void meson_nfc_set_data_oob(struct nand_chip *= nand, > } > } > =20 > -static int meson_nfc_queue_rb(struct meson_nfc *nfc, int timeout_ms) > +static int meson_nfc_queue_rb(struct meson_nfc *nfc, int timeout_ms, int= cmd_read0) > { > u32 cmd, cfg; > int ret =3D 0; > @@ -407,17 +407,29 @@ static int meson_nfc_queue_rb(struct meson_nfc *nfc= , int timeout_ms) > =20 > reinit_completion(&nfc->completion); > =20 > + cmd =3D nfc->param.chip_select | NFC_CMD_CLE | NAND_CMD_STATUS; > + writel(cmd, nfc->reg_base + NFC_REG_CMD); > + meson_nfc_cmd_idle(nfc, 5); Why 5 and 2 below? They look like magic values. Is this totally experimental? > + > /* use the max erase time as the maximum clock for waiting R/B */ > - cmd =3D NFC_CMD_RB | NFC_CMD_RB_INT > - | nfc->param.chip_select | nfc->timing.tbers_max; This is not documented in the commit log, is it? > + cmd =3D NFC_CMD_RB | NFC_CMD_RB_INT | nfc->timing.tbers_max; > writel(cmd, nfc->reg_base + NFC_REG_CMD); > + meson_nfc_cmd_idle(nfc, 2); > =20 > ret =3D wait_for_completion_timeout(&nfc->completion, > msecs_to_jiffies(timeout_ms)); > if (ret =3D=3D 0) > - ret =3D -1; > + return -1; Please use real error codes, such as ETIMEDOUT. > =20 > - return ret; > + if (!cmd_read0) > + return 0; > + > + cmd =3D nfc->param.chip_select | NFC_CMD_CLE | NAND_CMD_READ0; This looks really wrong, I don't get why you would need to send an expensive READ0 command. > + writel(cmd, nfc->reg_base + NFC_REG_CMD); > + meson_nfc_drain_cmd(nfc); > + meson_nfc_wait_cmd_finish(nfc, CMD_FIFO_EMPTY_TIMEOUT); > + > + return 0; > } > =20 > static void meson_nfc_set_user_byte(struct nand_chip *nand, u8 *oob_buf) > @@ -623,7 +635,7 @@ static int meson_nfc_rw_cmd_prepare_and_execute(struc= t nand_chip *nand, > if (in) { > nfc->cmdfifo.rw.cmd1 =3D cs | NFC_CMD_CLE | NAND_CMD_READSTART; > writel(nfc->cmdfifo.rw.cmd1, nfc->reg_base + NFC_REG_CMD); > - meson_nfc_queue_rb(nfc, PSEC_TO_MSEC(sdr->tR_max)); > + meson_nfc_queue_rb(nfc, PSEC_TO_MSEC(sdr->tR_max), 1); > } else { > meson_nfc_cmd_idle(nfc, nfc->timing.tadl); > } > @@ -669,7 +681,7 @@ static int meson_nfc_write_page_sub(struct nand_chip = *nand, > =20 > cmd =3D nfc->param.chip_select | NFC_CMD_CLE | NAND_CMD_PAGEPROG; > writel(cmd, nfc->reg_base + NFC_REG_CMD); > - meson_nfc_queue_rb(nfc, PSEC_TO_MSEC(sdr->tPROG_max)); > + meson_nfc_queue_rb(nfc, PSEC_TO_MSEC(sdr->tPROG_max), 0); > =20 > meson_nfc_dma_buffer_release(nand, data_len, info_len, DMA_TO_DEVICE); > =20 > @@ -952,7 +964,7 @@ static int meson_nfc_exec_op(struct nand_chip *nand, > break; > =20 > case NAND_OP_WAITRDY_INSTR: > - meson_nfc_queue_rb(nfc, instr->ctx.waitrdy.timeout_ms); > + meson_nfc_queue_rb(nfc, instr->ctx.waitrdy.timeout_ms, 1); > if (instr->delay_ns) > meson_nfc_cmd_idle(nfc, delay_idle); > break; Thanks, Miqu=C3=A8l