From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECBF2C77B73 for ; Tue, 23 May 2023 01:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o2ebCMeC0Gg/ghiaUxjGr45XpfzvcXPIaHpwpcgIJfo=; b=eiBkOEJOLc3NG3 m2rqZvGWkzepTQCBDwkT0NkAvuc/pJSMG3evVLdp3K40mcIN0OOJMmDLb7iExkGsBExDz0A4rCNa0 m2Z4fXOWF2TAvh+SL9tH7eWnNlx689/rMEfBWQV6KiXmnKlzDIfsNZnXBEKag5Sk3Xs1E9GdTQUAp Q9Zn2cac9TZIGiHvm7QptTtz0ub5SVjA+8z22hihK5RnKg6d0ZOylXvq4+XjgZm+UHKkAEs0AaO/g KrWARJxZMt5tuBEN+QevgraU51yQQfd5AVInORqOcDHdbrmme+w5+Vhu9t9Dv69oorilIuM57BUnc 0kShWEPZyJ7bVFKSO2EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1HEg-008cvo-2f; Tue, 23 May 2023 01:54:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1HEV-008crH-0j; Tue, 23 May 2023 01:54:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 145CF61756; Tue, 23 May 2023 01:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C548C433D2; Tue, 23 May 2023 01:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684806877; bh=o2ebCMeC0Gg/ghiaUxjGr45XpfzvcXPIaHpwpcgIJfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lPbDVLevbzTScK5ZPAqhHvPw/7A0H3fmSJL/niJYQgy+Fb63BDQbBtpHumQDTeWvi cqoAbvXaGVSR20Kk8iAYHYT1Vt3bIEMHSWTZaX46VDezfz6X/8KjObGuU1xwC0xazD uDSkNsyl5Xf3qyBzbjPOeObg7tmsHUezd4DVXBgkZFkOYiaQY6Zo+WPBUSAhPRKk+d JK+Yl07hQA3Bwh3BkG5stLSKENFGK1i32uokDksxExsex1/4yascF0E2GiJXD0v3jC gNERi78lPoKqCp331mZkHW6Y8vraLfj6VW9Gct69VvfvodyB6U61elq8jyQu4nXJ1Z NbUZpSEZMFe/g== Date: Mon, 22 May 2023 18:54:35 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Subject: Re: [PATCH net-next 00/30] net: dsa: mt7530: improve, trap BPDU & LLDP, and prefer CPU port Message-ID: <20230522185435.3b2a8d07@kernel.org> In-Reply-To: References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522140917.er7f5ws24b2eeyvs@soft-dev3-1> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_185439_362627_F79DBDCD X-CRM114-Status: GOOD ( 27.37 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-kernel@vger.kernel.org, Eric Dumazet , mithat.guner@xeront.com, Horatiu Vultur , Florian Fainelli , erkin.bozoglu@xeront.com, Richard van Schagen , arinc9.unal@gmail.com, Paolo Abeni , Landen Chao , Sean Wang , Richard van Schagen , DENG Qingfang , linux-mediatek@lists.infradead.org, Bartel Eerdekens , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , netdev@vger.kernel.org, Daniel Golle , Vladimir Oltean , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 22 May 2023 19:13:31 +0100 Russell King (Oracle) wrote: > > I have noticed that in many patches of the series you have: > > Tested-by: Ar=C4=B1n=C3=A7 =C3=9CNAL > >=20 > > Where you also have: > > Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL > >=20 > > I think you can drop Tested-by as the SoB will imply that. I think you > > got a similar comment some time ago to a different patch series. =20 >=20 > Signed-off-by in no way implies a tested-by. Signed-off-by has a very > distinct definition that is in submitting-patches.rst. >=20 > Clearly, if one is working on infrastructure where there are numerous > drivers involved, one probably doesn't have all the hardware, and one > may have to send patches that have only been build tested, but never > tested against real hardware. >=20 > While we may attempt to elicit testing, most of the time this seems > to be a waste of time and effort - or at least that's my experience. > Even if you Cc people who have recently been active with hardware, > that is no guarantee that there will be any reaction. >=20 > That has got to the point now where I just don't bother trying to > elicit help from others to test driver changes. If people want to > test, they need to do so when they see a patch on the mailing list, > preferably before it gets applied. If not, and if it breaks something, > then we'll have to generate a patch to fix the breakage. >=20 > So no, please stop thinking that SoB implies that the patch has been > tested. Dunno, I had the same reaction as Horatiu. Adding "Compile tested only" in the commit messages of patches which author wasn't able to test seems more natural than assuming that nothing is tested by default. It's not a hard requirement, e.g. seems fairly common sense that cross- -driver work comes with limited testing coverage. But for someone working on a single driver, assuming not tested by default, again,=20 to me - feels odd. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0287C77B73 for ; Tue, 23 May 2023 01:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZR/v2B7nIcNR7saV/tjVxqyuzv0L2v6p6EyQUyw7iYI=; b=JnJeQNzh4flmdA ofmtwpEDWYeN/lpsd2R/dYXCeDlfg4QN7VJSFtkBz0Qv/+Ak9OXeZXw7mvy4tUWsgAEkoNQaSsLU0 sYO1RjAJwDS2FJ9H/5Z0hvSOGy076beVaSNK3UGc56ToTtn/37qzcoAXXniStZk3TrqMQybNXGdIg ukj7jgklyRQaMAcgLdMhdn+mH7O4/7SQqEXghmZSlcFCDpzQRx5iQn6JQvgtUWtqWE9HoLGOwbF0N /MYI4OQHRgn8msSYGw6LhqS8NO/cozCeL+qeHWXgno8+FARRxvvWamewD8kK+hRbPI5PhUxLIL398 8fR9qf+UZXyhtcFkxg/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1HEf-008cvC-23; Tue, 23 May 2023 01:54:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1HEV-008crH-0j; Tue, 23 May 2023 01:54:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 145CF61756; Tue, 23 May 2023 01:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C548C433D2; Tue, 23 May 2023 01:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684806877; bh=o2ebCMeC0Gg/ghiaUxjGr45XpfzvcXPIaHpwpcgIJfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lPbDVLevbzTScK5ZPAqhHvPw/7A0H3fmSJL/niJYQgy+Fb63BDQbBtpHumQDTeWvi cqoAbvXaGVSR20Kk8iAYHYT1Vt3bIEMHSWTZaX46VDezfz6X/8KjObGuU1xwC0xazD uDSkNsyl5Xf3qyBzbjPOeObg7tmsHUezd4DVXBgkZFkOYiaQY6Zo+WPBUSAhPRKk+d JK+Yl07hQA3Bwh3BkG5stLSKENFGK1i32uokDksxExsex1/4yascF0E2GiJXD0v3jC gNERi78lPoKqCp331mZkHW6Y8vraLfj6VW9Gct69VvfvodyB6U61elq8jyQu4nXJ1Z NbUZpSEZMFe/g== Date: Mon, 22 May 2023 18:54:35 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Horatiu Vultur , arinc9.unal@gmail.com, Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , erkin.bozoglu@xeront.com, mithat.guner@xeront.com, =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 00/30] net: dsa: mt7530: improve, trap BPDU & LLDP, and prefer CPU port Message-ID: <20230522185435.3b2a8d07@kernel.org> In-Reply-To: References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522140917.er7f5ws24b2eeyvs@soft-dev3-1> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_185439_362627_F79DBDCD X-CRM114-Status: GOOD ( 27.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMiBNYXkgMjAyMyAxOToxMzozMSArMDEwMCBSdXNzZWxsIEtpbmcgKE9yYWNsZSkg d3JvdGU6Cj4gPiBJIGhhdmUgbm90aWNlZCB0aGF0IGluIG1hbnkgcGF0Y2hlcyBvZiB0aGUgc2Vy aWVzIHlvdSBoYXZlOgo+ID4gVGVzdGVkLWJ5OiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFsQGFy aW5jOS5jb20+Cj4gPiAKPiA+IFdoZXJlIHlvdSBhbHNvIGhhdmU6Cj4gPiBTaWduZWQtb2ZmLWJ5 OiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFsQGFyaW5jOS5jb20+Cj4gPiAKPiA+IEkgdGhpbmsg eW91IGNhbiBkcm9wIFRlc3RlZC1ieSBhcyB0aGUgU29CIHdpbGwgaW1wbHkgdGhhdC4gSSB0aGlu ayB5b3UKPiA+IGdvdCBhIHNpbWlsYXIgY29tbWVudCBzb21lIHRpbWUgYWdvIHRvIGEgZGlmZmVy ZW50IHBhdGNoIHNlcmllcy4gIAo+IAo+IFNpZ25lZC1vZmYtYnkgaW4gbm8gd2F5IGltcGxpZXMg YSB0ZXN0ZWQtYnkuIFNpZ25lZC1vZmYtYnkgaGFzIGEgdmVyeQo+IGRpc3RpbmN0IGRlZmluaXRp b24gdGhhdCBpcyBpbiBzdWJtaXR0aW5nLXBhdGNoZXMucnN0Lgo+IAo+IENsZWFybHksIGlmIG9u ZSBpcyB3b3JraW5nIG9uIGluZnJhc3RydWN0dXJlIHdoZXJlIHRoZXJlIGFyZSBudW1lcm91cwo+ IGRyaXZlcnMgaW52b2x2ZWQsIG9uZSBwcm9iYWJseSBkb2Vzbid0IGhhdmUgYWxsIHRoZSBoYXJk d2FyZSwgYW5kIG9uZQo+IG1heSBoYXZlIHRvIHNlbmQgcGF0Y2hlcyB0aGF0IGhhdmUgb25seSBi ZWVuIGJ1aWxkIHRlc3RlZCwgYnV0IG5ldmVyCj4gdGVzdGVkIGFnYWluc3QgcmVhbCBoYXJkd2Fy ZS4KPiAKPiBXaGlsZSB3ZSBtYXkgYXR0ZW1wdCB0byBlbGljaXQgdGVzdGluZywgbW9zdCBvZiB0 aGUgdGltZSB0aGlzIHNlZW1zCj4gdG8gYmUgYSB3YXN0ZSBvZiB0aW1lIGFuZCBlZmZvcnQgLSBv ciBhdCBsZWFzdCB0aGF0J3MgbXkgZXhwZXJpZW5jZS4KPiBFdmVuIGlmIHlvdSBDYyBwZW9wbGUg d2hvIGhhdmUgcmVjZW50bHkgYmVlbiBhY3RpdmUgd2l0aCBoYXJkd2FyZSwKPiB0aGF0IGlzIG5v IGd1YXJhbnRlZSB0aGF0IHRoZXJlIHdpbGwgYmUgYW55IHJlYWN0aW9uLgo+IAo+IFRoYXQgaGFz IGdvdCB0byB0aGUgcG9pbnQgbm93IHdoZXJlIEkganVzdCBkb24ndCBib3RoZXIgdHJ5aW5nIHRv Cj4gZWxpY2l0IGhlbHAgZnJvbSBvdGhlcnMgdG8gdGVzdCBkcml2ZXIgY2hhbmdlcy4gSWYgcGVv cGxlIHdhbnQgdG8KPiB0ZXN0LCB0aGV5IG5lZWQgdG8gZG8gc28gd2hlbiB0aGV5IHNlZSBhIHBh dGNoIG9uIHRoZSBtYWlsaW5nIGxpc3QsCj4gcHJlZmVyYWJseSBiZWZvcmUgaXQgZ2V0cyBhcHBs aWVkLiBJZiBub3QsIGFuZCBpZiBpdCBicmVha3Mgc29tZXRoaW5nLAo+IHRoZW4gd2UnbGwgaGF2 ZSB0byBnZW5lcmF0ZSBhIHBhdGNoIHRvIGZpeCB0aGUgYnJlYWthZ2UuCj4gCj4gU28gbm8sIHBs ZWFzZSBzdG9wIHRoaW5raW5nIHRoYXQgU29CIGltcGxpZXMgdGhhdCB0aGUgcGF0Y2ggaGFzIGJl ZW4KPiB0ZXN0ZWQuCgpEdW5ubywgSSBoYWQgdGhlIHNhbWUgcmVhY3Rpb24gYXMgSG9yYXRpdS4g QWRkaW5nICJDb21waWxlIHRlc3RlZCBvbmx5IgppbiB0aGUgY29tbWl0IG1lc3NhZ2VzIG9mIHBh dGNoZXMgd2hpY2ggYXV0aG9yIHdhc24ndCBhYmxlIHRvIHRlc3Qgc2VlbXMKbW9yZSBuYXR1cmFs IHRoYW4gYXNzdW1pbmcgdGhhdCBub3RoaW5nIGlzIHRlc3RlZCBieSBkZWZhdWx0LgoKSXQncyBu b3QgYSBoYXJkIHJlcXVpcmVtZW50LCBlLmcuIHNlZW1zIGZhaXJseSBjb21tb24gc2Vuc2UgdGhh dCBjcm9zcy0KLWRyaXZlciB3b3JrIGNvbWVzIHdpdGggbGltaXRlZCB0ZXN0aW5nIGNvdmVyYWdl LiBCdXQgZm9yIHNvbWVvbmUKd29ya2luZyBvbiBhIHNpbmdsZSBkcml2ZXIsIGFzc3VtaW5nIG5v dCB0ZXN0ZWQgYnkgZGVmYXVsdCwgYWdhaW4sIAp0byBtZSAtIGZlZWxzIG9kZC4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F96C77B73 for ; Tue, 23 May 2023 01:54:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232320AbjEWBym (ORCPT ); Mon, 22 May 2023 21:54:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232190AbjEWByj (ORCPT ); Mon, 22 May 2023 21:54:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CD41CD for ; Mon, 22 May 2023 18:54:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 166B86226C for ; Tue, 23 May 2023 01:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C548C433D2; Tue, 23 May 2023 01:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684806877; bh=o2ebCMeC0Gg/ghiaUxjGr45XpfzvcXPIaHpwpcgIJfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lPbDVLevbzTScK5ZPAqhHvPw/7A0H3fmSJL/niJYQgy+Fb63BDQbBtpHumQDTeWvi cqoAbvXaGVSR20Kk8iAYHYT1Vt3bIEMHSWTZaX46VDezfz6X/8KjObGuU1xwC0xazD uDSkNsyl5Xf3qyBzbjPOeObg7tmsHUezd4DVXBgkZFkOYiaQY6Zo+WPBUSAhPRKk+d JK+Yl07hQA3Bwh3BkG5stLSKENFGK1i32uokDksxExsex1/4yascF0E2GiJXD0v3jC gNERi78lPoKqCp331mZkHW6Y8vraLfj6VW9Gct69VvfvodyB6U61elq8jyQu4nXJ1Z NbUZpSEZMFe/g== Date: Mon, 22 May 2023 18:54:35 -0700 From: Jakub Kicinski To: "Russell King (Oracle)" Cc: Horatiu Vultur , arinc9.unal@gmail.com, Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , erkin.bozoglu@xeront.com, mithat.guner@xeront.com, =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next 00/30] net: dsa: mt7530: improve, trap BPDU & LLDP, and prefer CPU port Message-ID: <20230522185435.3b2a8d07@kernel.org> In-Reply-To: References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522140917.er7f5ws24b2eeyvs@soft-dev3-1> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2023 19:13:31 +0100 Russell King (Oracle) wrote: > > I have noticed that in many patches of the series you have: > > Tested-by: Ar=C4=B1n=C3=A7 =C3=9CNAL > >=20 > > Where you also have: > > Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL > >=20 > > I think you can drop Tested-by as the SoB will imply that. I think you > > got a similar comment some time ago to a different patch series. =20 >=20 > Signed-off-by in no way implies a tested-by. Signed-off-by has a very > distinct definition that is in submitting-patches.rst. >=20 > Clearly, if one is working on infrastructure where there are numerous > drivers involved, one probably doesn't have all the hardware, and one > may have to send patches that have only been build tested, but never > tested against real hardware. >=20 > While we may attempt to elicit testing, most of the time this seems > to be a waste of time and effort - or at least that's my experience. > Even if you Cc people who have recently been active with hardware, > that is no guarantee that there will be any reaction. >=20 > That has got to the point now where I just don't bother trying to > elicit help from others to test driver changes. If people want to > test, they need to do so when they see a patch on the mailing list, > preferably before it gets applied. If not, and if it breaks something, > then we'll have to generate a patch to fix the breakage. >=20 > So no, please stop thinking that SoB implies that the patch has been > tested. Dunno, I had the same reaction as Horatiu. Adding "Compile tested only" in the commit messages of patches which author wasn't able to test seems more natural than assuming that nothing is tested by default. It's not a hard requirement, e.g. seems fairly common sense that cross- -driver work comes with limited testing coverage. But for someone working on a single driver, assuming not tested by default, again,=20 to me - feels odd.