From: Christopher Snowhill <kode54@gmail.com>
To: intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [Intel-xe] [PATCH v2 7/8] drm/xe: Only try to lock external BOs in VM bind
Date: Mon, 22 May 2023 20:58:07 -0700 [thread overview]
Message-ID: <20230523035808.635175-8-kode54@gmail.com> (raw)
In-Reply-To: <20230523035808.635175-1-kode54@gmail.com>
From: Matthew Brost <matthew.brost@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
We only need to try to lock a BO if it's external as non-external BOs
share the dma-resv with the already locked VM. Trying to lock
non-external BOs caused an issue (list corruption) in an uncoming patch
which adds bulk LRU move. Since this code isn't needed, remove it.
v2: New commit message, s/mattthew/matthew/
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_vm.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index a0306526b269..0398da1ef1e2 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2089,9 +2089,11 @@ static int vm_bind_ioctl(struct xe_vm *vm, struct xe_vma *vma,
*/
xe_bo_get(vbo);
- tv_bo.bo = &vbo->ttm;
- tv_bo.num_shared = 1;
- list_add(&tv_bo.head, &objs);
+ if (!vbo->vm) {
+ tv_bo.bo = &vbo->ttm;
+ tv_bo.num_shared = 1;
+ list_add(&tv_bo.head, &objs);
+ }
}
again:
--
2.40.1
next prev parent reply other threads:[~2023-05-23 3:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 3:58 [Intel-xe] [PATCH v2 0/8] Scheduler changes for upstreaming Christopher Snowhill
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 1/8] fixup! drm/sched: Convert drm scheduler to use a work queue rather than kthread Christopher Snowhill
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 2/8] drm/sched: Move schedule policy to scheduler Christopher Snowhill
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 3/8] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy Christopher Snowhill
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 4/8] drm/xe: Use DRM_SCHED_POLICY_SINGLE_ENTITY mode Christopher Snowhill
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 5/8] drm/xe: Long running job update Christopher Snowhill
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 6/8] drm/xe: Ensure LR engines are not persistent Christopher Snowhill
2023-05-23 3:58 ` Christopher Snowhill [this message]
2023-05-23 3:58 ` [Intel-xe] [PATCH v2 8/8] drm/xe: VM LRU bulk move Christopher Snowhill
2023-05-23 4:00 ` [Intel-xe] ✓ CI.Patch_applied: success for Scheduler changes for upstreaming (rev2) Patchwork
2023-05-23 4:02 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-23 4:06 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-23 4:36 ` [Intel-xe] ○ CI.BAT: info " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-23 5:43 [Intel-xe] [PATCH v2 0/8] Scheduler changes for upstreaming Matthew Brost
2023-05-23 5:44 ` [Intel-xe] [PATCH v2 7/8] drm/xe: Only try to lock external BOs in VM bind Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523035808.635175-8-kode54@gmail.com \
--to=kode54@gmail.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.