From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: hare@suse.de, linux-nvme@lists.infradead.org, hch@lst.de,
sagi@grimberg.me
Subject: Re: [PATCH 3/3] nvmet-auth: use helper for auth send/recv cmd prep
Date: Tue, 23 May 2023 08:56:55 +0200 [thread overview]
Message-ID: <20230523065655.GC8224@lst.de> (raw)
In-Reply-To: <20230522083713.107001-4-kch@nvidia.com>
> + u16 sts = nvmet_auth_check_secp_spsp(req);
> +
> + return sts ? sts : nvmet_auth_alloc_transfer_buffer(req, buf, len);
I'd much prefer just spelling things out here as usual:
if (sts)
return sts;
return nvmet_auth_alloc_transfer_buffer(req, buf, len);
next prev parent reply other threads:[~2023-05-23 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 8:37 [PATCH 0/3] nvmet-auth: auth send / receive cleanup Chaitanya Kulkarni
2023-05-22 8:37 ` [PATCH 1/3] nvmet-auth: use common helper to check secp/spsp Chaitanya Kulkarni
2023-05-23 6:55 ` Christoph Hellwig
2023-05-22 8:37 ` [PATCH 2/3] nvmet_auth: use common helper for buffer alloc Chaitanya Kulkarni
2023-05-23 6:56 ` Christoph Hellwig
2023-05-22 8:37 ` [PATCH 3/3] nvmet-auth: use helper for auth send/recv cmd prep Chaitanya Kulkarni
2023-05-23 6:56 ` Christoph Hellwig [this message]
2023-05-23 8:33 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523065655.GC8224@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.