From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97816C77B75 for ; Tue, 23 May 2023 00:44:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QQFvW0ZRhz3cgv for ; Tue, 23 May 2023 10:44:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=Lh2t3iKM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::102e; helo=mail-pj1-x102e.google.com; envelope-from=zbestahu@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20221208 header.b=Lh2t3iKM; dkim-atps=neutral Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QQFvP4mq3z3bgr for ; Tue, 23 May 2023 10:44:32 +1000 (AEST) Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2533d74895bso4984211a91.0 for ; Mon, 22 May 2023 17:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684802668; x=1687394668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+ohaTtJOaeTv+DUbIMaoQB65niNoQeGMvZ+rell6iqk=; b=Lh2t3iKMxSvClzmCWv9vggXg6qa912HRceMhmGZW22Nea0fZW/Q4GLwhOXlOvZlt8+ svTRTl6rlknvFhR/Vb28ViINP9WwvZd/IjbY8vu685AtJGUVUZog1b3RQQM9orQ0WDtk dECpFw98w8XuJATQW2Y9dMfd+3Xoavt+3vGl6CQsk2BtDr0Qu2EJi01c1Oe3q75H7bHv 1OGVaoV2JE/o0M/8bwm9TIGFYoE8GSL+GWN8OpYHBWW6QU2KiWyW6OLC9Dv0mIABSqSV wS7nO7w+CYB2CEx/D2V5zSOHVLL/c3SiyK87ySOtc86/ZhxG8Hlq6aUypkW0y1WTBXZy cQKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684802668; x=1687394668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ohaTtJOaeTv+DUbIMaoQB65niNoQeGMvZ+rell6iqk=; b=d7NU6N/bQc/JzFK1xrjACjQV+u41SRGp5dFtcnzQ0j77AWv11IabVqI00k81I++UDv Bj2BuDC5wGHktYqocJ5fYjJBx1EuX/DJN9vaiK9wVweR+LU4YoXazGvlsBZwxsjvG6Za yNowcBJEavDt3+Q4beFBs9CMOZR9ZkcWaAgl6fSQXHYE5iAjyndVHxHyEMK6EehC+Dj1 Azj+Vsof7MgRoYwmdyHn3lYn6J3RjX6xHqLn15gM/KXSgCx9VM6obQC5xOf2SnuuTozv s8CF9sc3rDBRCiIBWNwkvm0qXLjKoaChYNPH7LBD/LU9LdrNpd3VyljU6QnGFcpdP6LP 3Xsw== X-Gm-Message-State: AC+VfDyozyXeTq1Jxr745UT1OFsjfVywiybtYP6BqFJbwTfJWVlxYRKL n6zFJSFi6rh3vE6uDa4qvkM= X-Google-Smtp-Source: ACHHUZ7Z00JJe8o88wNi/jig565qsA7QD7/XTMHnzm4a67eYa0dAv7dLNOTRPHowJnhdhWSqEW9znQ== X-Received: by 2002:a17:90a:d513:b0:24d:d377:d1 with SMTP id t19-20020a17090ad51300b0024dd37700d1mr12085705pju.45.1684802668474; Mon, 22 May 2023 17:44:28 -0700 (PDT) Received: from localhost ([156.236.96.165]) by smtp.gmail.com with ESMTPSA id lp4-20020a17090b4a8400b002555689006esm3048698pjb.47.2023.05.22.17.44.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 May 2023 17:44:28 -0700 (PDT) Date: Tue, 23 May 2023 08:52:26 +0800 From: Yue Hu To: Gao Xiang Subject: Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled Message-ID: <20230523085226.00006933.zbestahu@gmail.com> In-Reply-To: <20230522092141.124290-1-hsiangkao@linux.alibaba.com> References: <20230522092141.124290-1-hsiangkao@linux.alibaba.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhangwen@coolpad.com, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org, LKML , Sandeep Dhavale Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Mon, 22 May 2023 17:21:41 +0800 Gao Xiang wrote: > As Sandeep shown [1], high priority RT per-cpu kthreads are > typically helpful for Android scenarios to minimize the scheduling > latencies. > > Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if > EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for > EROFS_FS_PCPU_KTHREAD. > > Also clean up unneeded sched_set_normal(). > > [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com > Cc: Sandeep Dhavale > Signed-off-by: Gao Xiang > --- > fs/erofs/Kconfig | 1 + > fs/erofs/zdata.c | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig > index 704fb59577e0..f259d92c9720 100644 > --- a/fs/erofs/Kconfig > +++ b/fs/erofs/Kconfig > @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD > config EROFS_FS_PCPU_KTHREAD_HIPRI > bool "EROFS high priority per-CPU kthread workers" > depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD > + default y How about removing this config option? > help > This permits EROFS to configure per-CPU kthread workers to run > at higher priority. > diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c > index 92f3a01262cf..3ba505434f03 100644 > --- a/fs/erofs/zdata.c > +++ b/fs/erofs/zdata.c > @@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu) > return worker; > if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI)) > sched_set_fifo_low(worker->task); > - else > - sched_set_normal(worker->task, 0); > return worker; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F82C77B73 for ; Tue, 23 May 2023 00:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235103AbjEWAw7 (ORCPT ); Mon, 22 May 2023 20:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235087AbjEWAwi (ORCPT ); Mon, 22 May 2023 20:52:38 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC0062D58 for ; Mon, 22 May 2023 17:45:58 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2537a79b9acso3040614a91.3 for ; Mon, 22 May 2023 17:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684802668; x=1687394668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+ohaTtJOaeTv+DUbIMaoQB65niNoQeGMvZ+rell6iqk=; b=Lh2t3iKMxSvClzmCWv9vggXg6qa912HRceMhmGZW22Nea0fZW/Q4GLwhOXlOvZlt8+ svTRTl6rlknvFhR/Vb28ViINP9WwvZd/IjbY8vu685AtJGUVUZog1b3RQQM9orQ0WDtk dECpFw98w8XuJATQW2Y9dMfd+3Xoavt+3vGl6CQsk2BtDr0Qu2EJi01c1Oe3q75H7bHv 1OGVaoV2JE/o0M/8bwm9TIGFYoE8GSL+GWN8OpYHBWW6QU2KiWyW6OLC9Dv0mIABSqSV wS7nO7w+CYB2CEx/D2V5zSOHVLL/c3SiyK87ySOtc86/ZhxG8Hlq6aUypkW0y1WTBXZy cQKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684802668; x=1687394668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+ohaTtJOaeTv+DUbIMaoQB65niNoQeGMvZ+rell6iqk=; b=SJvvxgjGIBd7uC6YwlLRpGPyP4YB6FhQEw+kMzRzFr0JBbr2xtBV+/ixK5Tap1/cAR 6VCN65azJKz8EgU5vWNYHyHwNizf9kZs3ySuxIo6n+X8Q6f6GpYeGOzJSx22IxlKLjQ5 OEfgFJbJmJtw/r5RhtMYPeKLLWhh8GS7wVx2yO1OazENFMzRaoiAXklRMg+XJjakbU01 EOgi9Tv8vjbAm/17mQaaCLhxmm5Eb8drR+8Ft+/w1x8sfW4e/YWixZ9vsbopqhDhAYEW tL9RNHer+Dq1VQ2rlppJRWDwLQYe/TpDplWSF4fYN3++RsJLTCc9JhzTr0BDDxetqAk5 89MQ== X-Gm-Message-State: AC+VfDzOzHFfAcyYzU6qV5ZbFF0RuO6Ei6XbqzM2g39sv4Ssq/0XNFut S2x1UNSbvTDFT7Izor7LJQg= X-Google-Smtp-Source: ACHHUZ7Z00JJe8o88wNi/jig565qsA7QD7/XTMHnzm4a67eYa0dAv7dLNOTRPHowJnhdhWSqEW9znQ== X-Received: by 2002:a17:90a:d513:b0:24d:d377:d1 with SMTP id t19-20020a17090ad51300b0024dd37700d1mr12085705pju.45.1684802668474; Mon, 22 May 2023 17:44:28 -0700 (PDT) Received: from localhost ([156.236.96.165]) by smtp.gmail.com with ESMTPSA id lp4-20020a17090b4a8400b002555689006esm3048698pjb.47.2023.05.22.17.44.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 May 2023 17:44:28 -0700 (PDT) Date: Tue, 23 May 2023 08:52:26 +0800 From: Yue Hu To: Gao Xiang Cc: linux-erofs@lists.ozlabs.org, LKML , Sandeep Dhavale , huyue2@coolpad.com, zhangwen@coolpad.com Subject: Re: [PATCH] erofs: use HIPRI by default if per-cpu kthreads are enabled Message-ID: <20230523085226.00006933.zbestahu@gmail.com> In-Reply-To: <20230522092141.124290-1-hsiangkao@linux.alibaba.com> References: <20230522092141.124290-1-hsiangkao@linux.alibaba.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2023 17:21:41 +0800 Gao Xiang wrote: > As Sandeep shown [1], high priority RT per-cpu kthreads are > typically helpful for Android scenarios to minimize the scheduling > latencies. > > Switch EROFS_FS_PCPU_KTHREAD_HIPRI on by default if > EROFS_FS_PCPU_KTHREAD is on since it's the typical use cases for > EROFS_FS_PCPU_KTHREAD. > > Also clean up unneeded sched_set_normal(). > > [1] https://lore.kernel.org/r/CAB=BE-SBtO6vcoyLNA9F-9VaN5R0t3o_Zn+FW8GbO6wyUqFneQ@mail.gmail.com > Cc: Sandeep Dhavale > Signed-off-by: Gao Xiang > --- > fs/erofs/Kconfig | 1 + > fs/erofs/zdata.c | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig > index 704fb59577e0..f259d92c9720 100644 > --- a/fs/erofs/Kconfig > +++ b/fs/erofs/Kconfig > @@ -121,6 +121,7 @@ config EROFS_FS_PCPU_KTHREAD > config EROFS_FS_PCPU_KTHREAD_HIPRI > bool "EROFS high priority per-CPU kthread workers" > depends on EROFS_FS_ZIP && EROFS_FS_PCPU_KTHREAD > + default y How about removing this config option? > help > This permits EROFS to configure per-CPU kthread workers to run > at higher priority. > diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c > index 92f3a01262cf..3ba505434f03 100644 > --- a/fs/erofs/zdata.c > +++ b/fs/erofs/zdata.c > @@ -367,8 +367,6 @@ static struct kthread_worker *erofs_init_percpu_worker(int cpu) > return worker; > if (IS_ENABLED(CONFIG_EROFS_FS_PCPU_KTHREAD_HIPRI)) > sched_set_fifo_low(worker->task); > - else > - sched_set_normal(worker->task, 0); > return worker; > } >