From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: paul@crapouillou.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-mips@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mips: dts: ingenic: Remove unnecessary AIC clocks
Date: Tue, 23 May 2023 11:07:06 +0200 [thread overview]
Message-ID: <20230523090706.GC9484@alpha.franken.de> (raw)
In-Reply-To: <20230505142400.1270848-1-aidanmacdonald.0x0@gmail.com>
On Fri, May 05, 2023 at 03:24:00PM +0100, Aidan MacDonald wrote:
> The "ext" and "pll half" clocks don't belong in the DT. They are
> not consumed directly by the AIC and are only used as the parent
> clocks of the "i2s" clock. An operating system should be able to
> figure out that information itself because it presumably knows the
> layout of the clock tree.
>
> Removing these from the DT should be safe from a compatibility
> point of view because the jz4740-i2s driver in Linux does not, and
> never did depend on them.
>
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> Link: https://lore.kernel.org/all/20221028103418.17578-1-aidanmacdonald.0x0@gmail.com/
> ---
> This is a resend of patch 2/3 from a previous submission which is linked above.
>
> v1->v2: updated commit message
>
> arch/mips/boot/dts/ingenic/jz4725b.dtsi | 7 ++-----
> arch/mips/boot/dts/ingenic/jz4740.dtsi | 7 ++-----
> arch/mips/boot/dts/ingenic/jz4770.dtsi | 5 ++---
> 3 files changed, 6 insertions(+), 13 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-05-23 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 14:24 [PATCH v2] mips: dts: ingenic: Remove unnecessary AIC clocks Aidan MacDonald
2023-05-05 16:53 ` Paul Cercueil
2023-05-23 9:07 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523090706.GC9484@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.