From: guoren@kernel.org <guoren@kernel.org>
To: opensbi@lists.infradead.org
Subject: [RFC PATCH 1/2] lib: reset: thead: Remove unnecessary fence operations
Date: Tue, 23 May 2023 05:46:48 -0400 [thread overview]
Message-ID: <20230523094649.4100554-2-guoren@kernel.org> (raw)
In-Reply-To: <20230523094649.4100554-1-guoren@kernel.org>
From: Guo Ren <guoren@linux.alibaba.com>
There are no load/store operations to fence at the reset point.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
---
lib/utils/reset/fdt_reset_thead.c | 1 -
lib/utils/reset/fdt_reset_thead_asm.S | 2 --
2 files changed, 3 deletions(-)
diff --git a/lib/utils/reset/fdt_reset_thead.c b/lib/utils/reset/fdt_reset_thead.c
index e1d6885debae..ff7d2981b42f 100644
--- a/lib/utils/reset/fdt_reset_thead.c
+++ b/lib/utils/reset/fdt_reset_thead.c
@@ -27,7 +27,6 @@ static void clone_csrs(int cnt)
/* Mask csr BIT[31 - 20] */
*(u32 *)&__fdt_reset_thead_csrr &= BIT(20) - 1;
- smp_mb();
/* Write csr BIT[31 - 20] to __fdt_reset_thead_csrr */
*(u32 *)&__fdt_reset_thead_csrr |= custom_csr[i].index << 20;
diff --git a/lib/utils/reset/fdt_reset_thead_asm.S b/lib/utils/reset/fdt_reset_thead_asm.S
index 8237951fd82d..650f8585cdd2 100644
--- a/lib/utils/reset/fdt_reset_thead_asm.S
+++ b/lib/utils/reset/fdt_reset_thead_asm.S
@@ -27,7 +27,6 @@ __thead_pre_start_warm:
*/
li t1, 0x70013
csrw 0x7c2, t1
- fence rw,rw
lla t1, custom_csr
@@ -43,5 +42,4 @@ __reset_thead_csr_stub:
*/
li t1, 0x70013
csrw 0x7c2, t1
- fence rw,rw
j _start_warm
--
2.36.1
next prev parent reply other threads:[~2023-05-23 9:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 9:46 [RFC PATCH 0/2] lib: reset: thead: Correct dts naming convention guoren
2023-05-23 9:46 ` guoren [this message]
2023-05-23 9:46 ` [RFC PATCH 2/2] lib: reset: thead: Correct the naming convention of dts guoren
2023-05-23 15:51 ` Conor Dooley
2023-05-24 1:17 ` Guo Ren
2023-05-24 6:42 ` Conor Dooley
2023-05-24 10:39 ` Guo Ren
2023-05-24 14:46 ` Conor Dooley
2023-05-24 15:55 ` Jessica Clarke
2023-05-24 17:26 ` Conor Dooley
2023-05-25 3:15 ` Guo Ren
2023-05-25 5:33 ` Conor Dooley
2023-05-25 6:06 ` Guo Ren
2023-06-12 0:57 ` Guo Ren
2023-06-12 1:05 ` Jessica Clarke
2023-06-13 2:21 ` Guo Ren
2023-06-13 2:43 ` Jessica Clarke
2023-06-14 1:07 ` Guo Ren
2023-06-14 1:25 ` Jessica Clarke
2023-06-15 15:32 ` Guo Ren
2023-06-12 15:39 ` Conor Dooley
2023-06-13 2:31 ` Guo Ren
2023-06-13 19:36 ` Conor Dooley
2023-06-14 1:11 ` Guo Ren
2023-06-14 6:56 ` Conor Dooley
2023-06-15 15:54 ` Guo Ren
2023-06-15 16:46 ` Conor Dooley
2023-06-16 0:05 ` Guo Ren
2023-06-14 1:17 ` Guo Ren
2023-05-25 4:05 ` Guo Ren
2023-05-24 7:30 ` [RFC PATCH 0/2] lib: reset: thead: Correct dts naming convention Anup Patel
2023-05-24 10:04 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523094649.4100554-2-guoren@kernel.org \
--to=guoren@kernel.org \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.