From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74F22C7EE2A for ; Wed, 24 May 2023 04:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684903841; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=nJl/J082ttvfaH/fmPNxCalWrw3WB7uS2ZImcbquEXQ=; b=BixPKRoZGZ9Zbd7Rg6oMgSFlrXfWKhVhcgFetxDvM/Fo1ugQGL/8Z4y0sji5rs7fMEp9AB M7kdpvU0Cp2w/4tihtU9TxIbCbwTFDeTUkvgh32HbBHaSzT42DcCydNrWXYgVNpU7MEZ0E BxStjuizXW/3Bxthrx3fjyErTjhFwm4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-Xs2rac5DPU6ptFd-CERq-w-1; Wed, 24 May 2023 00:50:38 -0400 X-MC-Unique: Xs2rac5DPU6ptFd-CERq-w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8DE273800EA1; Wed, 24 May 2023 04:50:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E0FE9E68; Wed, 24 May 2023 04:50:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 158A019465A8; Wed, 24 May 2023 04:50:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D872219465A0 for ; Tue, 23 May 2023 09:34:12 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B6C289D7A; Tue, 23 May 2023 09:34:12 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE5C89D73 for ; Tue, 23 May 2023 09:34:12 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 87A293C13A0C for ; Tue, 23 May 2023 09:34:12 +0000 (UTC) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-103-2oygsCvwPvCafxkCOBuvzg-1; Tue, 23 May 2023 05:34:10 -0400 X-MC-Unique: 2oygsCvwPvCafxkCOBuvzg-1 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9C42B1C000B; Tue, 23 May 2023 09:34:03 +0000 (UTC) Date: Tue, 23 May 2023 11:34:02 +0200 From: Miquel Raynal To: Christoph Hellwig Message-ID: <20230523113402.32fa86ba@xps-13> In-Reply-To: <20230523074535.249802-24-hch@lst.de> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-24-hch@lst.de> Organization: Bootlin MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mailman-Approved-At: Wed, 24 May 2023 04:50:30 +0000 Subject: Re: [dm-devel] [PATCH 23/24] mtd: block2mtd: don't call early_lookup_bdev after the system is running X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Vignesh Raghavendra , "Rafael J. Wysocki" , Greg Kroah-Hartman , linux-pm@vger.kernel.org, Mike Snitzer , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Pavel Machek , Richard Weinberger , Joern Engel Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: bootlin.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgQ2hyaXN0b3BoLAoKaGNoQGxzdC5kZSB3cm90ZSBvbiBUdWUsIDIzIE1heSAyMDIzIDA5OjQ1 OjM0ICswMjAwOgoKPiBlYXJseV9sb29rdXBfYmRldiBpcyBzdXBwb3NlZCB0byBvbmx5IGJlIGNh bGxlZCBmcm9tIHRoZSBlYXJseSBib290Cj4gY29kZSwgYnV0IG1kdGJsb2NrX2Vhcmx5X2dldF9i ZGV2IGlzIGNhbGxlZCBhcyBhIGdlbmVyYWwgZmFsbGJhY2sgd2hlbgo+IGxvb2t1cF9iZGV2IGZh aWxzLCB3aGljaCBpcyBwcm9ibGVtYXRpYyBiZWNhdXNlIGVhcmx5X2xvb2t1cF9iZGV2Cj4gYnlw YXNzZXMgYWxsIG5vcm1hbCBwYXRoIGJhc2VkIHBlcm1pc3Npb24gY2hlY2tpbmcsIGFuZCBtaWdo dCBjYXVzZQo+IHByb2JsZW1zIHdpdGggY2VydGFpbiBjb250YWluZXIgZW52aXJvbm1lbnRzIHJl bmFtaW5nIGRldmljZXMuCj4gCj4gU3dpdGNoIHRvIG9ubHkgY2FsbCBlYXJseV9sb29rdXBfYmRl diB3aGVuIGRtIGlzIGJ1aWx0LWluIGFuZCB0aGUgc3lzdGVtCj4gc3RhdGUgaW4gbm90IHJ1bm5p bmcgeWV0Lgo+IAo+IE5vdGUgdGhhdCB0aGlzIHN0cmljdGx5IHNwZWFraW5nIGNoYW5nZXMgdGhl IGtlcm5lbCBBQkkgYXMgdGhlIFBBUlRVVUlEPQo+IGFuZCBQQVJUTEFCRUw9IHN0eWxlIHN5bnRh eCBpcyBub3cgbm90IGF2YWlsYWJsZSBkdXJpbmcgYSBydW5uaW5nCj4gc3lzdGVtcy4gIFRoZXkg bmV2ZXIgd2VyZSBpbnRlbmRlZCBmb3IgdGhhdCwgYnV0IHRoaXMgYnJlYWtzIHRoaW5ncwo+IHdl J2xsIGhhdmUgdG8gZmlndXJlIG91dCBhIHdheSB0byBtYWtlIHRoZW0gYXZhaWxhYmxlIGFnYWlu LiAgQnV0IGlmCj4gYXZvaWRhYmxlIGluIGFueSB3YXkgSSdkIHJhdGhlciBhdm9pZCB0aGF0LgoK U291bmRzIHJlYXNvbmFibGUgdG8gbWUuIFJpY2hhcmQ/CgpSZXZpZXdlZC1ieTogTWlxdWVsIFJh eW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KClRoYW5rcywKTWlxdcOobAoKLS0KZG0t ZGV2ZWwgbWFpbGluZyBsaXN0CmRtLWRldmVsQHJlZGhhdC5jb20KaHR0cHM6Ly9saXN0bWFuLnJl ZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9kbS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F70C77B75 for ; Tue, 23 May 2023 09:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236008AbjEWJe0 (ORCPT ); Tue, 23 May 2023 05:34:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236353AbjEWJeV (ORCPT ); Tue, 23 May 2023 05:34:21 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AA851AE; Tue, 23 May 2023 02:34:10 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9C42B1C000B; Tue, 23 May 2023 09:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684834449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irbxTtFMj36QTztSinqx+K6zvjiLXjiZS7Tr5vGVeQA=; b=MQH74+mtNlOf4mUA+OQUVAFl8W+eC7RN11ueU2RMGlh+Uwq1wcbbyomCcUxSlkAI5NyNG3 2TMaEiXyqLQolV9rwaPYpsE7eB6oq9qRgjQ7lXGv9e5Fkqy8eud0VjNM1Bd3o3RQCcqQLZ vikDp7RYUdmVy46Cv2NGjbr3pvHIDJNW4A6cX6ZD//6P8rdQyWozGOFmTEtNE+bl6sFbi5 SRNppfd8ppRl7dBbbP6XTyvLL1K1FwSlmvyDZVICHBlkJjNG+Z+ux/uEvVGchQGOIWBi3a eOuUZbU5hKu1s5WmPVeQhF9hEE29NCLi5+s57dwJShnlXv/oGEnNobOwXkW7dw== Date: Tue, 23 May 2023 11:34:02 +0200 From: Miquel Raynal To: Christoph Hellwig Cc: Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Mike Snitzer , Joern Engel , Richard Weinberger , Vignesh Raghavendra , Pavel Machek , dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 23/24] mtd: block2mtd: don't call early_lookup_bdev after the system is running Message-ID: <20230523113402.32fa86ba@xps-13> In-Reply-To: <20230523074535.249802-24-hch@lst.de> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-24-hch@lst.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Christoph, hch@lst.de wrote on Tue, 23 May 2023 09:45:34 +0200: > early_lookup_bdev is supposed to only be called from the early boot > code, but mdtblock_early_get_bdev is called as a general fallback when > lookup_bdev fails, which is problematic because early_lookup_bdev > bypasses all normal path based permission checking, and might cause > problems with certain container environments renaming devices. >=20 > Switch to only call early_lookup_bdev when dm is built-in and the system > state in not running yet. >=20 > Note that this strictly speaking changes the kernel ABI as the PARTUUID=3D > and PARTLABEL=3D style syntax is now not available during a running > systems. They never were intended for that, but this breaks things > we'll have to figure out a way to make them available again. But if > avoidable in any way I'd rather avoid that. Sounds reasonable to me. Richard? Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1555FC77B75 for ; Tue, 23 May 2023 09:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kmWYoFkVIC/alyTFdKB1+cGvECmWcJuKgjmr63VcOwE=; b=UrN0mbIsJa9vlb s532nL/5IWjlT4nBbCFB5BswCl0kHXvh3xqxzQvzvNP6NIPhu+2ZM5hz21Aj0Vq8FimvWTQu3jlb/ qYWfXCwYVutxN+B0fPsH34xOtfgZIqwnDoQ0KXqFict19+dr9kTkddOObwaMIq7vlrJkIVl9lG/JA TXlsGVC3WPdHtOBzLSJzTcRh8rk9xFI/ic+977S4eLvTZW+sbcwV3GX7x+Dz5PSJfa6RcWq/jmK6T dvjHVV3WD7BxrhSHzX3LxTStxNBaWMe1BOrTVOheCvmHP+VQHe8wTt8cWTYSQQK0fh2zQcnOL1E8w FvVlKgGlwIzKueklckaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1OPH-009cto-2W; Tue, 23 May 2023 09:34:15 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1OPE-009crM-2t for linux-mtd@lists.infradead.org; Tue, 23 May 2023 09:34:14 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 9C42B1C000B; Tue, 23 May 2023 09:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1684834449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irbxTtFMj36QTztSinqx+K6zvjiLXjiZS7Tr5vGVeQA=; b=MQH74+mtNlOf4mUA+OQUVAFl8W+eC7RN11ueU2RMGlh+Uwq1wcbbyomCcUxSlkAI5NyNG3 2TMaEiXyqLQolV9rwaPYpsE7eB6oq9qRgjQ7lXGv9e5Fkqy8eud0VjNM1Bd3o3RQCcqQLZ vikDp7RYUdmVy46Cv2NGjbr3pvHIDJNW4A6cX6ZD//6P8rdQyWozGOFmTEtNE+bl6sFbi5 SRNppfd8ppRl7dBbbP6XTyvLL1K1FwSlmvyDZVICHBlkJjNG+Z+ux/uEvVGchQGOIWBi3a eOuUZbU5hKu1s5WmPVeQhF9hEE29NCLi5+s57dwJShnlXv/oGEnNobOwXkW7dw== Date: Tue, 23 May 2023 11:34:02 +0200 From: Miquel Raynal To: Christoph Hellwig Cc: Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Mike Snitzer , Joern Engel , Richard Weinberger , Vignesh Raghavendra , Pavel Machek , dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 23/24] mtd: block2mtd: don't call early_lookup_bdev after the system is running Message-ID: <20230523113402.32fa86ba@xps-13> In-Reply-To: <20230523074535.249802-24-hch@lst.de> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-24-hch@lst.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_023413_087492_6BB7329D X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXN0b3BoLAoKaGNoQGxzdC5kZSB3cm90ZSBvbiBUdWUsIDIzIE1heSAyMDIzIDA5OjQ1 OjM0ICswMjAwOgoKPiBlYXJseV9sb29rdXBfYmRldiBpcyBzdXBwb3NlZCB0byBvbmx5IGJlIGNh bGxlZCBmcm9tIHRoZSBlYXJseSBib290Cj4gY29kZSwgYnV0IG1kdGJsb2NrX2Vhcmx5X2dldF9i ZGV2IGlzIGNhbGxlZCBhcyBhIGdlbmVyYWwgZmFsbGJhY2sgd2hlbgo+IGxvb2t1cF9iZGV2IGZh aWxzLCB3aGljaCBpcyBwcm9ibGVtYXRpYyBiZWNhdXNlIGVhcmx5X2xvb2t1cF9iZGV2Cj4gYnlw YXNzZXMgYWxsIG5vcm1hbCBwYXRoIGJhc2VkIHBlcm1pc3Npb24gY2hlY2tpbmcsIGFuZCBtaWdo dCBjYXVzZQo+IHByb2JsZW1zIHdpdGggY2VydGFpbiBjb250YWluZXIgZW52aXJvbm1lbnRzIHJl bmFtaW5nIGRldmljZXMuCj4gCj4gU3dpdGNoIHRvIG9ubHkgY2FsbCBlYXJseV9sb29rdXBfYmRl diB3aGVuIGRtIGlzIGJ1aWx0LWluIGFuZCB0aGUgc3lzdGVtCj4gc3RhdGUgaW4gbm90IHJ1bm5p bmcgeWV0Lgo+IAo+IE5vdGUgdGhhdCB0aGlzIHN0cmljdGx5IHNwZWFraW5nIGNoYW5nZXMgdGhl IGtlcm5lbCBBQkkgYXMgdGhlIFBBUlRVVUlEPQo+IGFuZCBQQVJUTEFCRUw9IHN0eWxlIHN5bnRh eCBpcyBub3cgbm90IGF2YWlsYWJsZSBkdXJpbmcgYSBydW5uaW5nCj4gc3lzdGVtcy4gIFRoZXkg bmV2ZXIgd2VyZSBpbnRlbmRlZCBmb3IgdGhhdCwgYnV0IHRoaXMgYnJlYWtzIHRoaW5ncwo+IHdl J2xsIGhhdmUgdG8gZmlndXJlIG91dCBhIHdheSB0byBtYWtlIHRoZW0gYXZhaWxhYmxlIGFnYWlu LiAgQnV0IGlmCj4gYXZvaWRhYmxlIGluIGFueSB3YXkgSSdkIHJhdGhlciBhdm9pZCB0aGF0LgoK U291bmRzIHJlYXNvbmFibGUgdG8gbWUuIFJpY2hhcmQ/CgpSZXZpZXdlZC1ieTogTWlxdWVsIFJh eW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KClRoYW5rcywKTWlxdcOobAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1U RCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K