All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: Joseph Myers <joseph@codesourcery.com>,
	 cti-tac@lists.linuxfoundation.org
Subject: Re: Next steps from GTI TAC meeting on 2023-03-08 - Evaluate cost of glibc migration.
Date: Wed, 24 May 2023 15:06:20 -0400	[thread overview]
Message-ID: <20230524-gloating-diocese-cde658@meerkat> (raw)
In-Reply-To: <a4c8b242-7ab1-a0da-fbe0-19cffe1a6054@gotplt.org>

On Wed, May 24, 2023 at 02:13:53PM -0400, Siddhesh Poyarekar wrote:
> It looks like the question of who to ultimately trust, either the gatekeeper
> committer (or two) who is the only person to have write access to the
> repository, or the admin who manages the box.

The maintainer's action are in the public, while the admin's actions are
hidden.

> The gatekeeper committer could also fabricate commits and push to the
> central repository in the same way.

1. Not with nearly as much impunity, especially if non-fast-forward pushes are
   disallowed. 
2. At best, a maintainer can modify someone's patch to introduce a deliberate
   bug, not freely modify a commit somewhere in recent history to add
   significant chunks of code like an admin can.
3. If it's someone else's code they are committing, the original developer
   will probably discover any malicious edits, because they will be watching
   their own commits show up in the repository.
4. It's much easier to audit and review the actions of 2-3 co-maintainers than
   when hundreds of people have write access to the repository.
5. When only a small subset of people can push to a repository, maintaining a
   valid keyring for verifying their cryptographic signatures is much easier
   than when 400+ people all have write access.

I could go on for quite a while still. My recent talk at the Linux Security
Summit was on the subject of how easy it would be to sneak a backdoor into the
Linux kernel where I go into many of these considerations (unfortunately, the
talk not yet posted on the LF channel).

> In fact, the gatekeeper committer could choose to do worse, like
> delaying (or declining to merge) someones patches.

The gatekeeper is accountable to the community and can be replaced. The
admin's actions may never be discovered or they can be blamed on someone else.

-K

  parent reply	other threads:[~2023-05-24 19:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 22:47 Next steps from GTI TAC meeting on 2023-03-08 - Evaluate cost of glibc migration Joseph Myers
2023-05-22 10:11 ` Joel Brobecker
2023-05-24 12:44   ` Carlos O'Donell
2023-05-24 13:43     ` Siddhesh Poyarekar
2023-05-24 14:12       ` Carlos O'Donell
2023-05-24 15:18         ` Siddhesh Poyarekar
2023-05-23 17:38 ` Konstantin Ryabitsev
2023-05-23 19:34   ` Joseph Myers
2023-05-23 19:52     ` Konstantin Ryabitsev
2023-05-23 20:12       ` Joseph Myers
2023-05-23 20:21         ` Konstantin Ryabitsev
2023-05-23 22:12           ` Joseph Myers
2023-05-24 16:29             ` Konstantin Ryabitsev
2023-05-24 18:13               ` Siddhesh Poyarekar
2023-05-24 18:55                 ` Brian Behlendorf
2023-05-24 21:27                   ` Siddhesh Poyarekar
2023-05-25 11:06                     ` Carlos O'Donell
2023-05-24 19:06                 ` Konstantin Ryabitsev [this message]
2023-05-24 19:42                   ` Joseph Myers
2023-05-24 21:12                   ` Siddhesh Poyarekar
2023-05-25 11:12                     ` Carlos O'Donell
2023-05-24 18:58               ` Joseph Myers
2023-05-24 12:11       ` Siddhesh Poyarekar
2023-05-24 18:44         ` Joseph Myers
2023-05-24 19:58           ` Carlos O'Donell
2023-05-24 12:57     ` Carlos O'Donell
2023-05-24 18:46       ` Joseph Myers
2023-05-24 20:19         ` Carlos O'Donell
2023-05-24 20:48           ` Joseph Myers
  -- strict thread matches above, loose matches on Subject: below --
2023-04-03 17:24 Carlos O'Donell
2023-04-12 20:46 ` Konstantin Ryabitsev
2023-04-12 21:28   ` Brian Behlendorf
2023-05-19 21:00 ` Konstantin Ryabitsev
2023-05-22 14:37   ` Ian Kelling
2023-05-24 20:50     ` Carlos O'Donell
2023-05-24 21:53       ` Ian Kelling
2023-05-25 11:02         ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524-gloating-diocese-cde658@meerkat \
    --to=konstantin@linuxfoundation.org \
    --cc=cti-tac@lists.linuxfoundation.org \
    --cc=joseph@codesourcery.com \
    --cc=siddhesh@gotplt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.