From: Eric Biggers <ebiggers@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] fscrypt: Replace 1-element array with flexible array
Date: Tue, 23 May 2023 19:55:28 -0700 [thread overview]
Message-ID: <20230524025528.GA1076@sol.localdomain> (raw)
In-Reply-To: <20230523165458.gonna.580-kees@kernel.org>
On Tue, May 23, 2023 at 09:55:02AM -0700, Kees Cook wrote:
> 1-element arrays are deprecated and are being replaced with C99
> flexible arrays[1].
>
> As sizes were being calculated with the extra byte intentionally,
> propagate the difference so there is no change in binary output.
>
> [1] https://github.com/KSPP/linux/issues/79
>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: "Theodore Y. Ts'o" <tytso@mit.edu>
> Cc: Jaegeuk Kim <jaegeuk@kernel.org>
> Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
> Cc: linux-fscrypt@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> v2: update commit log to avoid mentioning "len" member.
> v1: https://lore.kernel.org/lkml/20230522213924.never.119-kees@kernel.org/
> ---
> fs/crypto/fscrypt_private.h | 2 +-
> fs/crypto/hooks.c | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
Thanks, applied to
https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next
- Eric
prev parent reply other threads:[~2023-05-24 2:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 16:55 [PATCH v2] fscrypt: Replace 1-element array with flexible array Kees Cook
2023-05-24 2:55 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524025528.GA1076@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=gustavoars@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.