From: Christopher Snowhill <kode54@gmail.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [PATCH 0/2] Update Xe uAPI in a minimally invasive way
Date: Tue, 23 May 2023 20:31:29 -0700 [thread overview]
Message-ID: <20230524033131.2000480-1-kode54@gmail.com> (raw)
This series takes off from mlankhorst's attempt to do the same, except
instead, it tries to be as minimally invasive to the original uAPI as
possible, by only inserting padding where appropriate to ensure all
32-bit members are 32-bit aligned, and all 64-bit members are 64-bit
aligned. This should have zero effect on 64-bit hosts versus 64-bit
userspace, so existing native software will operate the same with or
without the update. The only real change is 32-bit compat support for
multilib userspace, which was previously broken.
Also introduces field validation against all of the padding and
reserved fields, which must be zero, in a separate commit.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Christopher Snowhill <kode54@gmail.com>
Christopher Snowhill (2):
drm/xe: Add explicit padding to uAPI definition
drm/xe: Validate uAPI padding and reserved fields
drivers/gpu/drm/xe/xe_bo.c | 6 +++--
drivers/gpu/drm/xe/xe_engine.c | 19 +++++++++++---
drivers/gpu/drm/xe/xe_exec.c | 4 ++-
drivers/gpu/drm/xe/xe_mmio.c | 3 ++-
drivers/gpu/drm/xe/xe_query.c | 3 ++-
drivers/gpu/drm/xe/xe_sync.c | 4 ++-
drivers/gpu/drm/xe/xe_vm.c | 22 +++++++++++++---
drivers/gpu/drm/xe/xe_vm_madvise.c | 4 ++-
drivers/gpu/drm/xe/xe_wait_user_fence.c | 3 ++-
include/uapi/drm/xe_drm.h | 34 ++++++++++++++++++++++++-
10 files changed, 86 insertions(+), 16 deletions(-)
--
2.40.1
next reply other threads:[~2023-05-24 3:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 3:31 Christopher Snowhill [this message]
2023-05-24 3:31 ` [Intel-xe] [PATCH 1/2] drm/xe: Add explicit padding to uAPI definition Christopher Snowhill
2023-05-24 15:20 ` Souza, Jose
2023-05-24 16:21 ` Lucas De Marchi
2023-05-24 3:31 ` [Intel-xe] [PATCH 2/2] drm/xe: Validate uAPI padding and reserved fields Christopher Snowhill
2023-05-24 15:37 ` Souza, Jose
2023-05-25 1:40 ` Christopher Snowhill
2023-05-25 13:06 ` Souza, Jose
2023-05-24 23:43 ` Lucas De Marchi
2023-05-24 3:34 ` [Intel-xe] ✓ CI.Patch_applied: success for Update Xe uAPI in a minimally invasive way Patchwork
2023-05-24 3:36 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-24 3:40 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-24 4:08 ` [Intel-xe] ○ CI.BAT: info " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524033131.2000480-1-kode54@gmail.com \
--to=kode54@gmail.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.