Re: [PATCH mptcp-next v15 5/5] mptcp: update userspace pm infos

[Geliang Tang <geliang.tang@suse.com>]

On Wed, May 24, 2023 at 03:24:09PM +0200, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 24/05/2023 10:02, Geliang Tang wrote:
> > Increase pm subflows counter on both server side and client side when
> > userspace pm creates a new subflow, and decrease the counter when it
> > closes a subflow.
> > 
> > Increase add_addr_signaled counter in mptcp_nl_cmd_announce() when the
> > address is announced by userspace PM.
> > 
> > This modification is similar to how the in-kernel PM is updating the
> > counter: when additional subflows are created/removed.
> (...)
> 
> > diff --git a/net/mptcp/pm_userspace.c b/net/mptcp/pm_userspace.c
> > index 114548b09f47..7ada9cf81c14 100644
> > --- a/net/mptcp/pm_userspace.c
> > +++ b/net/mptcp/pm_userspace.c
> > @@ -91,6 +92,7 @@ static int mptcp_userspace_pm_delete_local_addr(struct mptcp_sock *msk,
> >  
> >  	list_for_each_entry_safe(entry, tmp, &msk->pm.userspace_pm_local_addr_list, list) {
> >  		if (mptcp_addresses_equal(&entry->addr, &addr->addr, false)) {
> > +			msk->pm.local_addr_used--;
> 
> Do you mind if I add this under the following comment with the TODO? We
> should only decrement the entry if it is the last one being used.

Yes, it's much better to move this under the TODO comment.

Thanks,
-Geliang

> 
> >  			/* TODO: a refcount is needed because the entry can
> >  			 * be used multiple times (e.g. fullmesh mode).
> >  			 */
> 
> Cheers,
> Matt
> -- 
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net