From: <rs@ti.com>
To: <reatmon@ti.com>, <denis@denix.org>, <afd@ti.com>, <detheridge@ti.com>
Cc: <meta-arago@lists.yoctoproject.org>, Randolph Sapp <rs@ti.com>
Subject: [arago][kirkstone][PATCH 2/7] weston: drop Fix-touch-screen-crash patch
Date: Wed, 24 May 2023 13:11:17 -0500 [thread overview]
Message-ID: <20230524181122.35202-3-rs@ti.com> (raw)
In-Reply-To: <20230524181122.35202-1-rs@ti.com>
From: Randolph Sapp <rs@ti.com>
Drop the fix touchscreen crash patch as this is for an older version of
weston and it seems like they completely reworked the way the handle
touch events, adding checks for out of bounds events and extra handling
for NULL window focus events.
Signed-off-by: Randolph Sapp <rs@ti.com>
---
...-weston-Fix-touch-screen-crash-issue.patch | 39 -------------------
.../wayland/weston_10.0.2.bbappend | 1 -
2 files changed, 40 deletions(-)
delete mode 100644 meta-arago-distro/recipes-graphics/wayland/weston/0004-weston-Fix-touch-screen-crash-issue.patch
diff --git a/meta-arago-distro/recipes-graphics/wayland/weston/0004-weston-Fix-touch-screen-crash-issue.patch b/meta-arago-distro/recipes-graphics/wayland/weston/0004-weston-Fix-touch-screen-crash-issue.patch
deleted file mode 100644
index 4849d5b6..00000000
--- a/meta-arago-distro/recipes-graphics/wayland/weston/0004-weston-Fix-touch-screen-crash-issue.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 60250e9dc57fe56148c8a24bba107bce8a873fb4 Mon Sep 17 00:00:00 2001
-From: Karthik Ramanan <a0393906@ti.com>
-Date: Mon, 12 Mar 2018 10:56:28 +0530
-Subject: [PATCH 4/4] weston: Fix touch screen crash issue
-
-Touch screen operation causes the weston to crash with segment fault sometimes.
-The crash occurs when the coordinate (x,y) passed to the weston input module
-is outside the view window, hence the weston compositor is not able to pick
-up a display view and there is no code to detect this condition at function
-notify_touch().
-
-Upstream status: pending
-
-Signed-off-by: Eric Ruei <e-ruei1@ti.com>
-Signed-off-by: Karthik Ramanan <a0393906@ti.com>
----
- libweston/input.c | 6 ++++++
- 1 file changed, 6 insertions(+)
-
-diff --git a/libweston/input.c b/libweston/input.c
-index 4fedc55..bcb2f28 100644
---- a/libweston/input.c
-+++ b/libweston/input.c
-@@ -2185,6 +2185,12 @@ notify_touch(struct weston_seat *seat, uint32_t time, int touch_id,
- * until all touch points are up again. */
- if (touch->num_tp == 1) {
- ev = weston_compositor_pick_view(ec, x, y, &sx, &sy);
-+ if (!ev)
-+ {
-+ weston_log("notify_touch: weston_compositor_pick_view(%d, %d) failed to find a view!\n",
-+ wl_fixed_to_int(x), wl_fixed_to_int(y));
-+ return;
-+ }
- weston_touch_set_focus(touch, ev);
- } else if (!touch->focus) {
- /* Unexpected condition: We have non-initial touch but
---
-1.9.1
-
diff --git a/meta-arago-distro/recipes-graphics/wayland/weston_10.0.2.bbappend b/meta-arago-distro/recipes-graphics/wayland/weston_10.0.2.bbappend
index b1b7d26a..16ed6e67 100644
--- a/meta-arago-distro/recipes-graphics/wayland/weston_10.0.2.bbappend
+++ b/meta-arago-distro/recipes-graphics/wayland/weston_10.0.2.bbappend
@@ -5,7 +5,6 @@ PR:append = ".arago1"
# file://0002-weston-Allow-visual_id-to-be-0.patch
SRC_URI += " \
file://0003-weston-Fix-virtual-keyboard-display-issue-for-QT5-ap.patch \
- file://0004-weston-Fix-touch-screen-crash-issue.patch \
file://0001-backend-drm-Select-plane-based-on-current-attached-C.patch \
file://0001-Revert-require-GL_EXT_unpack_subimage-commit.patch \
"
--
2.40.1
next prev parent reply other threads:[~2023-05-24 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 18:11 [arago][kirkstone][PATCH 0/7] Rootless Weston and Weston patch cleanup rs
2023-05-24 18:11 ` [arago][kirkstone][PATCH 1/7] weston-init: drop all the old append logic rs
2023-05-24 18:11 ` rs [this message]
2023-05-24 18:11 ` [arago][kirkstone][PATCH 3/7] weston: drop allow-visual_id-to-be-0 patch rs
2023-05-24 18:11 ` [arago][kirkstone][PATCH 4/7] weston: add notice about select-plane patch rs
2023-05-24 18:11 ` [arago][kirkstone][PATCH 5/7] weston: add weston user to the render group rs
2023-05-24 18:11 ` [arago][kirkstone][PATCH 6/7] weston: drop the fix-virtual-keyboard-display-issue patch rs
2023-05-24 18:11 ` [arago][kirkstone][PATCH 7/7] weston-init: add a simple touchscreen calibration check rs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524181122.35202-3-rs@ti.com \
--to=rs@ti.com \
--cc=afd@ti.com \
--cc=denis@denix.org \
--cc=detheridge@ti.com \
--cc=meta-arago@lists.yoctoproject.org \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.