All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Buildroot Development <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] toolchain-external-custom: Describe BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX
Date: Wed, 24 May 2023 21:15:00 +0200	[thread overview]
Message-ID: <20230524191500.GC2623@scaer> (raw)
In-Reply-To: <20230524031601.19938-1-bagasdotme@gmail.com>

Bags, All,

On 2023-05-24 10:16 +0700, Bagas Sanjaya spake thusly:
> "Toolchain prefix" option apparently doesn't have any help describing
> it, which causes confusion when using external toolchain. Leaving this
> option at default prefix name ("$(ARCH)-linux") when external toolchain
> components are called with different prefix (e.g.
> "$(ARCH)-unknown-linux-gnu") may cause build failure unless the prefix
> symlink is already in place (e.g. when using Buildroot-generated
> toolchain as external toolchain).
> 
> Describe the option to clarify.
> 
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  .../toolchain-external-custom/Config.in.options       | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> index 0fd8841e5b..ed62bad990 100644
> --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> @@ -24,6 +24,17 @@ config BR2_TOOLCHAIN_EXTERNAL_REL_BIN_PATH
>  config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX
>  	string "Toolchain prefix"
>  	default "$(ARCH)-linux"
> +	help
> +	  Component name prefix used by your external toolchain.
> +	  Typically, this is target tuple (e.g. "$(ARCH)-unknown-linux-gnu").
> +	  If unsure, look at "bin" directory of your toolchain and
> +	  note the part of component name before the last dash (i.e. if
> +	  you call the toolchain's gcc as "$(ARCH)-unknown-linux-gnu-gcc",
> +	  the prefix is "$(ARCH)-unknown-linux-gnu").
> +
> +	  Note that Buildroot toolchains have "$(ARCH)-linux" symlink alias
> +	  to the full tuple-named components, so you can leave this option at
> +	  default value if you use them as external toolchain.

    $ ./utils/docker-run make check-package
    toolchain/toolchain-external/toolchain-external-custom/Config.in.options:29: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    toolchain/toolchain-external/toolchain-external-custom/Config.in.options:32: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    toolchain/toolchain-external/toolchain-external-custom/Config.in.options:35: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
    toolchain/toolchain-external/toolchain-external-custom/Config.in.options:36: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)

Applied to master with the above fixed (which required that I rephrase
it slightly to keep lines of a consistent length). Thanks.

Regards,
Yann E. MORIN.

>  choice
>  	bool "External toolchain gcc version"
> 
> base-commit: 603df32a0cd416caa2d2688008cb87f14ad68ef3
> -- 
> An old man doll... just what I always wanted! - Clara
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-05-24 19:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24  3:16 [Buildroot] [PATCH] toolchain-external-custom: Describe BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX Bagas Sanjaya
2023-05-24  6:26 ` Thomas Petazzoni via buildroot
2023-05-24 19:15 ` Yann E. MORIN [this message]
2023-05-29  7:15 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524191500.GC2623@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=bagasdotme@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.de_schampheleire@nokia.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.