From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A7EBC77B7E for ; Thu, 25 May 2023 05:13:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.539310.840058 (Exim 4.92) (envelope-from ) id 1q23HQ-00047s-OW; Thu, 25 May 2023 05:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 539310.840058; Thu, 25 May 2023 05:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q23HQ-00047l-LO; Thu, 25 May 2023 05:12:52 +0000 Received: by outflank-mailman (input) for mailman id 539310; Thu, 25 May 2023 05:12:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q23HP-000478-MB for xen-devel@lists.xenproject.org; Thu, 25 May 2023 05:12:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb491fa4-faba-11ed-b230-6b7b168915f2; Thu, 25 May 2023 07:12:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B25AB63FA3; Thu, 25 May 2023 05:12:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D54B4C433EF; Thu, 25 May 2023 05:12:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb491fa4-faba-11ed-b230-6b7b168915f2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684991569; bh=gx6rfY8zkLlGyaW9DzoBbw69iftNsi3UHSSsrPAeD1o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CZGzlNOxbgpVc1jwE5hJ9N25DOVM2hHKBkE10Fx8i/mMokENlE+s1WXgpJlAIP2zE AV3a6r5qQWo1+V2e+WUPc5i0JqACbO3iVpEWbm6EOsInBQitUVTlPrO5nkzBtpp3gm EMwHARxeNvvDR8FNYkJkxr56fJgaElTTt+cm1ejbnGGXiM8kTprHe20/b0zVsZKlrq RUBI1LwUpsT7Iqt4cOryXHpZ9RHE0kTOb++OAPVdO9AWLkCtmpnXrb1ogiY76AAX3y P5AZwPFdO++llcitqp9a9zDseEXr54y31KCae+z1boirxvyIHacGuk1mjY9kQsuNSg +Ad/B5k5e3UWg== Date: Wed, 24 May 2023 22:12:47 -0700 From: Jakub Kicinski To: Linus Walleij Cc: Wei Liu , Paul Durrant , xen-devel@lists.xenproject.org, netdev@vger.kernel.org Subject: Re: [PATCH] xen/netback: Pass (void *) to virt_to_page() Message-ID: <20230524221247.1dc731a8@kernel.org> In-Reply-To: <20230524221147.5791ba3a@kernel.org> References: <20230523140342.2672713-1-linus.walleij@linaro.org> <20230524221147.5791ba3a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 May 2023 22:11:47 -0700 Jakub Kicinski wrote: > On Tue, 23 May 2023 16:03:42 +0200 Linus Walleij wrote: > > virt_to_page() takes a virtual address as argument but > > the driver passes an unsigned long, which works because > > the target platform(s) uses polymorphic macros to calculate > > the page. > > > > Since many architectures implement virt_to_pfn() as > > a macro, this function becomes polymorphic and accepts both a > > (unsigned long) and a (void *). > > > > Fix this up by an explicit (void *) cast. > > Paul, Wei, looks like netdev may be the usual path for this patch > to flow thru, although I'm never 100% sure with Xen. > Please ack or LUK if you prefer to direct the patch elsewhere? Ugh, Wei already acked this, sorry for the noise.