From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5513CC77B7E for ; Thu, 25 May 2023 08:17:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236511AbjEYIRt (ORCPT ); Thu, 25 May 2023 04:17:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjEYIRs (ORCPT ); Thu, 25 May 2023 04:17:48 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 935CF99 for ; Thu, 25 May 2023 01:17:47 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q26AM-0002fS-2x; Thu, 25 May 2023 10:17:46 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1q26AG-000346-U9; Thu, 25 May 2023 10:17:40 +0200 Date: Thu, 25 May 2023 10:17:40 +0200 From: Michael Tretter To: Hans Verkuil Cc: linux-media@vger.kernel.org, Jacob Chen , Ezequiel Garcia Subject: Re: [PATCH 2/8] media: rockchip: rga: fix clock cleanup Message-ID: <20230525081740.GF9943@pengutronix.de> Mail-Followup-To: Michael Tretter , Hans Verkuil , linux-media@vger.kernel.org, Jacob Chen , Ezequiel Garcia References: <20230524121150.435736-1-hverkuil-cisco@xs4all.nl> <20230524121150.435736-3-hverkuil-cisco@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230524121150.435736-3-hverkuil-cisco@xs4all.nl> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, 24 May 2023 14:11:44 +0200, Hans Verkuil wrote: > Fix this smatch warning: > > drivers/media/platform/rockchip/rga/rga.c:734 rga_enable_clocks() warn: 'rga->sclk' from clk_prepare_enable() not released on lines: 734. > > The reason is that aclk should be disabled/unprepared before > sclk, instead of the other way around. > > Signed-off-by: Hans Verkuil > Cc: Jacob Chen > Cc: Ezequiel Garcia > Cc: Michael Tretter Reviewed-by: Michael Tretter > --- > drivers/media/platform/rockchip/rga/rga.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index 67dcf22e5ba3..cbb33dd62fdd 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -726,10 +726,10 @@ static int rga_enable_clocks(struct rockchip_rga *rga) > > return 0; > > -err_disable_sclk: > - clk_disable_unprepare(rga->sclk); > err_disable_aclk: > clk_disable_unprepare(rga->aclk); > +err_disable_sclk: > + clk_disable_unprepare(rga->sclk); > > return ret; > } > -- > 2.39.2 > >