From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77FCAC7EE29 for ; Thu, 25 May 2023 10:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240442AbjEYKuM (ORCPT ); Thu, 25 May 2023 06:50:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240392AbjEYKuK (ORCPT ); Thu, 25 May 2023 06:50:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3A2F10B; Thu, 25 May 2023 03:50:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 584D964424; Thu, 25 May 2023 10:50:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CCC0C433EF; Thu, 25 May 2023 10:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685011808; bh=bITUuS/msjqCHswws53qmVLCSN8fQpxyKJDunhlChSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UaV9sjBUaHcoWhvbXo6Rl62e3Xy5H7OrI20SC97t537BRRBA0fLFy6tIyqT5G6Rzs 3f2ZPeSsZKi+1APyYByZK+fZpTOW5R2sqtChLpDjx1tp6pk9bmu8Vfurh3cg4rJoKB kTfZACmlHsOPaOU+iaENPHyJkOSBV9k7V0d9CEsMnjKIU3IgIS/UIL8ozfGZ+TJeAf vc+z3n+fGP+0MbWKaz6tO1Ca94k48w1BhJVHOj+hWGRhKCMjwr/NpnHzhKQ27aLhk3 S3WJkauEhRoyCEJr8llgHIESDbE8ZYkQ0eHg2gScrEZBAgfuTvUFDWPRgAk6iiV7sw qD4iaxU4edayA== Date: Thu, 25 May 2023 11:50:03 +0100 From: Lee Jones To: Linus Walleij Cc: Tony Lindgren , Russell King , Bartosz Golaszewski , Andreas Kemnade , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver Message-ID: <20230525105003.GF9691@google.com> References: <20230430-omap2-pdata-quirks-v1-0-e015f3a3ea46@linaro.org> <20230430-omap2-pdata-quirks-v1-1-e015f3a3ea46@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230430-omap2-pdata-quirks-v1-1-e015f3a3ea46@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 01 May 2023, Linus Walleij wrote: > The TWL4030 GPIO driver has a custom platform data .set_up() > callback to call back into the platform and do misc stuff such > as hog and export a GPIO for WLAN PWR on a specific OMAP3 board. > > Avoid all the kludgery in the platform data and the boardfile > and just put the quirks right into the driver. Make it > conditional on OMAP3. > > I think the exported GPIO is used by some kind of userspace > so ordinary DTS hogs will probably not work. > > Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base") > Signed-off-by: Linus Walleij > --- > arch/arm/mach-omap2/omap_device.c | 1 - > arch/arm/mach-omap2/pdata-quirks.c | 41 +----------------------------- > drivers/gpio/gpio-twl4030.c | 52 ++++++++++++++++++++++++++------------ > include/linux/mfd/twl.h | 3 --- Acked-by: Lee Jones > 4 files changed, 37 insertions(+), 60 deletions(-) -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BCE5C7EE29 for ; Thu, 25 May 2023 10:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4mJQtAnliPtpJuPRGAd0CUFFz3pGq9Z+xAnHmdwWjG0=; b=XDI/McMaU2mkxL YMmEdlV9LoY6ky/3PGifagKpSiBTbftxn5y2grx8TDuy3KPQr6yFpcocLiMNW+QKATcbi3dsQyg7V mTDGmf6GWmmp+njtAKo1urCgsyYlfUTMbD5r3pex1iHayhypYXor5sbIDm97SyLv6bqdaDIw5riW1 HGc0ugcI066WKfR+QNHHqg3oqDiNYMA7fQutEoGPxF9Cbj+k/9LjiIHdwxKgKiNHpjYHviHNCG+sI Lp8T3Dapa7GrWDHY4gZKaKgM35ZGbf3iyiKjqfCyLA63lJL4fBrtEOC9Y5pEXYSvBGG4GsFP0Y9JW vhSfDAw4ijvpA7Xg1yHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q28Xu-00GJCc-1e; Thu, 25 May 2023 10:50:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q28Xq-00GJBc-1U for linux-arm-kernel@lists.infradead.org; Thu, 25 May 2023 10:50:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B3056449C; Thu, 25 May 2023 10:50:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CCC0C433EF; Thu, 25 May 2023 10:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685011808; bh=bITUuS/msjqCHswws53qmVLCSN8fQpxyKJDunhlChSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UaV9sjBUaHcoWhvbXo6Rl62e3Xy5H7OrI20SC97t537BRRBA0fLFy6tIyqT5G6Rzs 3f2ZPeSsZKi+1APyYByZK+fZpTOW5R2sqtChLpDjx1tp6pk9bmu8Vfurh3cg4rJoKB kTfZACmlHsOPaOU+iaENPHyJkOSBV9k7V0d9CEsMnjKIU3IgIS/UIL8ozfGZ+TJeAf vc+z3n+fGP+0MbWKaz6tO1Ca94k48w1BhJVHOj+hWGRhKCMjwr/NpnHzhKQ27aLhk3 S3WJkauEhRoyCEJr8llgHIESDbE8ZYkQ0eHg2gScrEZBAgfuTvUFDWPRgAk6iiV7sw qD4iaxU4edayA== Date: Thu, 25 May 2023 11:50:03 +0100 From: Lee Jones To: Linus Walleij Cc: Tony Lindgren , Russell King , Bartosz Golaszewski , Andreas Kemnade , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 1/3] ARM/gpio: Push OMAP2 quirk down into TWL4030 driver Message-ID: <20230525105003.GF9691@google.com> References: <20230430-omap2-pdata-quirks-v1-0-e015f3a3ea46@linaro.org> <20230430-omap2-pdata-quirks-v1-1-e015f3a3ea46@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230430-omap2-pdata-quirks-v1-1-e015f3a3ea46@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230525_035010_567979_1FD2010C X-CRM114-Status: GOOD ( 17.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAwMSBNYXkgMjAyMywgTGludXMgV2FsbGVpaiB3cm90ZToKCj4gVGhlIFRXTDQwMzAg R1BJTyBkcml2ZXIgaGFzIGEgY3VzdG9tIHBsYXRmb3JtIGRhdGEgLnNldF91cCgpCj4gY2FsbGJh Y2sgdG8gY2FsbCBiYWNrIGludG8gdGhlIHBsYXRmb3JtIGFuZCBkbyBtaXNjIHN0dWZmIHN1Y2gK PiBhcyBob2cgYW5kIGV4cG9ydCBhIEdQSU8gZm9yIFdMQU4gUFdSIG9uIGEgc3BlY2lmaWMgT01B UDMgYm9hcmQuCj4gCj4gQXZvaWQgYWxsIHRoZSBrbHVkZ2VyeSBpbiB0aGUgcGxhdGZvcm0gZGF0 YSBhbmQgdGhlIGJvYXJkZmlsZQo+IGFuZCBqdXN0IHB1dCB0aGUgcXVpcmtzIHJpZ2h0IGludG8g dGhlIGRyaXZlci4gTWFrZSBpdAo+IGNvbmRpdGlvbmFsIG9uIE9NQVAzLgo+IAo+IEkgdGhpbmsg dGhlIGV4cG9ydGVkIEdQSU8gaXMgdXNlZCBieSBzb21lIGtpbmQgb2YgdXNlcnNwYWNlCj4gc28g b3JkaW5hcnkgRFRTIGhvZ3Mgd2lsbCBwcm9iYWJseSBub3Qgd29yay4KPiAKPiBGaXhlczogOTJi Zjc4YjMzYjBiICgiZ3Bpbzogb21hcDogdXNlIGR5bmFtaWMgYWxsb2NhdGlvbiBvZiBiYXNlIikK PiBTaWduZWQtb2ZmLWJ5OiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5vcmc+ Cj4gLS0tCj4gIGFyY2gvYXJtL21hY2gtb21hcDIvb21hcF9kZXZpY2UuYyAgfCAgMSAtCj4gIGFy Y2gvYXJtL21hY2gtb21hcDIvcGRhdGEtcXVpcmtzLmMgfCA0MSArLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncGlvL2dwaW8tdHdsNDAzMC5jICAgICAgICB8IDUyICsr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCgo+ICBpbmNsdWRlL2xpbnV4L21m ZC90d2wuaCAgICAgICAgICAgIHwgIDMgLS0tCgpBY2tlZC1ieTogTGVlIEpvbmVzIDxsZWVAa2Vy bmVsLm9yZz4KCj4gIDQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgNjAgZGVsZXRp b25zKC0pCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==