From: Lee Jones <lee@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Maíra Canal" <maira.canal@usp.br>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Lee Jones" <lee.jones@linaro.org>
Subject: Re: [PATCH 1/2] mfd: wcd934x: Fix an error handling path in wcd934x_slim_probe()
Date: Thu, 25 May 2023 12:19:37 +0100 [thread overview]
Message-ID: <20230525111937.GC411262@google.com> (raw)
In-Reply-To: <02d8447f6d1df52cc8357aae698152e9a9be67c6.1684565021.git.christophe.jaillet@wanadoo.fr>
On Sat, 20 May 2023, Christophe JAILLET wrote:
> If devm_gpiod_get_optional() fails, some resources need to be released, as
> already done in the .remove() function.
>
> While at it, remove the unneeded error code from a dev_err_probe() call.
> It is already added in a human readable way by dev_err_probe() itself.
>
> Fixes: 6a0ee2a61a31 ("mfd: wcd934x: Replace legacy gpio interface for gpiod")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/mfd/wcd934x.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-05-25 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 7:10 [PATCH 1/2] mfd: wcd934x: Fix an error handling path in wcd934x_slim_probe() Christophe JAILLET
2023-05-20 7:11 ` [PATCH 2/2] mfd: wcd934x: Simplify with dev_err_probe() Christophe JAILLET
2023-05-25 11:20 ` Lee Jones
2023-05-25 11:19 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525111937.GC411262@google.com \
--to=lee@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maira.canal@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.