From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46CF4C7EE29 for ; Thu, 25 May 2023 18:59:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2GB6-0004PX-Is; Thu, 25 May 2023 14:59:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2GB3-0004Od-IG for qemu-devel@nongnu.org; Thu, 25 May 2023 14:59:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2GB2-0008B8-6J for qemu-devel@nongnu.org; Thu, 25 May 2023 14:59:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685041147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WoX0+NAlOD0KFZNnsTUdVfIRDBp/o1bb86TbabaN+Bg=; b=fuAqDlnylpc97ZH30/Clww4zviFO1u+PCxLoNUF+9DvZYH9GksoG38a0BJCIUucvHmdK6T t8MJyM1k3Bc6BU9lNZRp+3W3QH/PzK5GTUKPIeNx+GiHkfotNf/ffW29ghjUuEXhtC9dgX gxADJsB2yz5YCHb6u21r4Dv6f//5wrI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-315-jsq0VWZwNWG0FdhwmjUYOQ-1; Thu, 25 May 2023 14:59:02 -0400 X-MC-Unique: jsq0VWZwNWG0FdhwmjUYOQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94A0B85A5A8; Thu, 25 May 2023 18:59:02 +0000 (UTC) Received: from localhost (unknown [10.39.192.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 118E22166B2B; Thu, 25 May 2023 18:59:01 +0000 (UTC) Date: Thu, 25 May 2023 14:59:00 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-block@nongnu.org, hreitz@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org Subject: Re: [PATCH 11/12] iotests: Make verify_virtio_scsi_pci_or_ccw() public Message-ID: <20230525185900.GM132697@fedora> References: <20230525124713.401149-1-kwolf@redhat.com> <20230525124713.401149-12-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I4RS+Y2K+GilxGmA" Content-Disposition: inline In-Reply-To: <20230525124713.401149-12-kwolf@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --I4RS+Y2K+GilxGmA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 25, 2023 at 02:47:12PM +0200, Kevin Wolf wrote: > It has no internal callers, so its only use is being called from > individual test cases. If the name starts with an underscore, it is > considered private and linters warn against calling it. 256 only gets > away with it currently because it's on the exception list for linters. >=20 > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/iotests.py | 2 +- > tests/qemu-iotests/256 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi --I4RS+Y2K+GilxGmA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRvr/QACgkQnKSrs4Gr c8ib3gf/WDkqhvsZV3mAZAJNkthoBviOz0zUTwigXGDOjQa7rzoU9git67YuEHol Hg6+w3EfyxWg2F/MCvXW9Bv9DX5QFrSe9PBOhRBskXT9o27rCD43ntXALd+LaiTR c5f1MTpEro96BT7C18EmWlDot96gC4LThVON9ltA00CwyJp9ptDXj5JF3hTqWRTR 0RKMjOwhFr1pZBMmkXY1ep3mLpX7UTkDIAJL+RZedW3q3v8lDOQDajEs6lo69DTs JugLXS/ZScHu4ssWuJdXU6Xxz1B+WbK6L8UI90oQTSjquCfJi4w9szu0jA4FClLg 3gLu6MwYMPCFX8WOuUvwA5FoXrLq2A== =PBYU -----END PGP SIGNATURE----- --I4RS+Y2K+GilxGmA--