All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Snowhill <kode54@gmail.com>
To: intel-xe@lists.freedesktop.org
Cc: Ryan Houdek <sonicadvance1@gmail.com>
Subject: [Intel-xe] [RFC PATCH 0/2] Draft: Update Xe uAPI for 32-bit compat, invasively
Date: Thu, 25 May 2023 17:32:19 -0700	[thread overview]
Message-ID: <20230526003221.3874899-1-kode54@gmail.com> (raw)

This attempt brings in Maarten Lankhorst's original uAPI update, with
suggested changes made to make up the difference. As long as we're
attempting to bring up 32-bit compat capability, we may as well go
whole hog and just break things. Better that way than to deal with the
mess later.

Also introduces field validation against all of the padding and
reserved fields, which must be zero, in a separate commit.

This is the invasive update, as a draft, for comment and examination.
It's probably not going to be applied any time soon, but it's here,
and it's been updated based on the comments against the original
invasive attempt.

v3:
  Redid everything, maybe this one will be a little more permanent.
v2:
  Removed extensions checks where there were none originally. (José)
  Moved extraneous parentheses to the correct places. (Lucas)

Suggested-by: Ryan Houdek <sonicadvance1@gmail.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Christopher Snowhill <kode54@gmail.com>

Christopher Snowhill (2):
  drm/xe: Reshuffle all of the uAPI structs
  drm/xe: Validate uAPI padding and reserved fields

 drivers/gpu/drm/xe/xe_bo.c              |  6 ++-
 drivers/gpu/drm/xe/xe_engine.c          | 18 +++++--
 drivers/gpu/drm/xe/xe_exec.c            |  4 +-
 drivers/gpu/drm/xe/xe_mmio.c            |  3 +-
 drivers/gpu/drm/xe/xe_query.c           |  3 +-
 drivers/gpu/drm/xe/xe_sync.c            |  4 +-
 drivers/gpu/drm/xe/xe_vm.c              | 21 ++++++--
 drivers/gpu/drm/xe/xe_vm_madvise.c      |  3 +-
 drivers/gpu/drm/xe/xe_wait_user_fence.c |  3 +-
 include/uapi/drm/xe_drm.h               | 64 +++++++++++++++++--------
 10 files changed, 95 insertions(+), 34 deletions(-)

-- 
2.40.1


             reply	other threads:[~2023-05-26  0:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26  0:32 Christopher Snowhill [this message]
2023-05-26  0:32 ` [Intel-xe] [RFC PATCH 1/2] drm/xe: Reshuffle all of the uAPI structs Christopher Snowhill
2023-05-26  0:32 ` [Intel-xe] [RFC PATCH 2/2] drm/xe: Validate uAPI padding and reserved fields Christopher Snowhill
2023-05-26  0:34 ` [Intel-xe] ✓ CI.Patch_applied: success for Draft: Update Xe uAPI for 32-bit compat, invasively Patchwork
2023-05-26  0:36 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-26  0:40 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-26  1:09 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230526003221.3874899-1-kode54@gmail.com \
    --to=kode54@gmail.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sonicadvance1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.