From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: "Dominik 'Disconnect3d' Czarnota" <dominik.b.czarnota@gmail.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Andreas Arnez <arnez@linux.ibm.com>,
qemu-devel@nongnu.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v2 0/6] gdbstub: Add support for info proc mappings
Date: Fri, 26 May 2023 13:50:35 +0200 [thread overview]
Message-ID: <20230526115041.1362009-1-iii@linux.ibm.com> (raw)
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg02614.html
v1 -> v2: Reword the 5/6 commit message (Dominik).
Add R-bs.
Patches that need review:
4/6 gdbstub: Add support for info proc mappings
6/6 tests/tcg: Add a test for info proc mappings
Hi,
this series partially implements the Host I/O feature of the GDB Remote
Serial Protocol in order to make generate-core-file work with qemu-user.
It borrows heavily from the abandoned patch by Dominik [1], hence 4/6
carries the respective Co-developed-by: tag. I hope that's okay. I also
peeked at gdbserver/hostio.cc quite a few times.
The changes compared to Dominik's patch are:
- Implement readlink.
- Move the main functionality to user-target.c.
- Allocate buffers on heap.
- Add a test.
- Update gdb.rst.
- Split refactorings to the existing code into separate patches.
- Rename do_openat() to do_guest_openat().
- Do not retry pread(), since GDB is capable of doing it itself.
- Add an extra sanity check to gdb_handle_query_xfer_exec_file().
- Replace citations of the spec by a single link.
Best regards,
Ilya
Ilya Leoshkevich (6):
linux-user: Expose do_guest_openat() and do_guest_readlink()
gdbstub: Expose gdb_get_process() and gdb_get_first_cpu_in_process()
gdbstub: Report the actual qemu-user pid
gdbstub: Add support for info proc mappings
docs: Document security implications of debugging
tests/tcg: Add a test for info proc mappings
docs/system/gdb.rst | 15 ++
gdbstub/gdbstub.c | 86 ++++++++---
gdbstub/internals.h | 7 +
gdbstub/user-target.c | 139 ++++++++++++++++++
linux-user/qemu.h | 3 +
linux-user/syscall.c | 54 ++++---
tests/tcg/aarch64/Makefile.target | 3 +-
tests/tcg/multiarch/Makefile.target | 7 +
.../multiarch/gdbstub/test-proc-mappings.py | 55 +++++++
tests/tcg/s390x/Makefile.target | 2 +-
10 files changed, 332 insertions(+), 39 deletions(-)
create mode 100644 tests/tcg/multiarch/gdbstub/test-proc-mappings.py
--
2.40.1
next reply other threads:[~2023-05-26 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 11:50 Ilya Leoshkevich [this message]
2023-05-26 11:50 ` [PATCH v2 1/6] linux-user: Expose do_guest_openat() and do_guest_readlink() Ilya Leoshkevich
2023-05-26 11:50 ` [PATCH v2 2/6] gdbstub: Expose gdb_get_process() and gdb_get_first_cpu_in_process() Ilya Leoshkevich
2023-05-26 11:50 ` [PATCH v2 3/6] gdbstub: Report the actual qemu-user pid Ilya Leoshkevich
2023-05-26 11:50 ` [PATCH v2 4/6] gdbstub: Add support for info proc mappings Ilya Leoshkevich
2023-05-26 11:50 ` [PATCH v2 5/6] docs: Document security implications of debugging Ilya Leoshkevich
2023-05-26 11:50 ` [PATCH v2 6/6] tests/tcg: Add a test for info proc mappings Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526115041.1362009-1-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=arnez@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=dominik.b.czarnota@gmail.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.