From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 329B5C7EE23 for ; Fri, 26 May 2023 17:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ulxXE+6riMqgJJXSNQ7fwsABWcxRwlPACupV7iVBT0s=; b=sTNb4shiU0Bnmi TLPBQvtdHUeSwC+IkPYB8rivoGvCCCd/pe/33Bv/YMJNwxAAv53r+Px4jbAxOUyAAFdhtQOMwokWJ MZAwZL4kdKsB4B0pP4yUjbX3PiI0iYKNdQFtvC+FIIzoSNnkaO4U90vXNVIVGIMEsv4eUgWFmwLQH HhR6zFn2sVVN9Crl+PpIimfWJQPyGNw0ubCmNDnck6Nceod565rDK6ncPg9KHNmVL5wKqn7a1EbER mNAXiSFhZZz3qrA0G0WoD/zQR2+qEXZ0PU26Px3uGD8zPBVyD7cnLzP/xLV4zpcDWxCsq8hngoTj3 I0I/piIuaU+9K6cgOp9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2awE-003EwP-2h; Fri, 26 May 2023 17:09:14 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2awB-003Eve-0l; Fri, 26 May 2023 17:09:12 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685120948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdi3+7iY1FuuVZkTHEgLzoKSqhn5EptZQCzuKXVDC0s=; b=ZtKAWITht2MZsPftTNyQR0rssOpfR0x0RkKpyVvkGXiNJijisFlfgOqCuq/mhPJtyz5Ror uRm31TWwLlCyu95bUA/IWD5Xdlxq+UBmuwB5dRL9pGUc/rSbm8Hw0/nz6tm6YLkVvfWPST VYEsq1Va1Qg7/9FKOmqfUqUOs17k4nlWHKEuMYLTOxBf1UPqoC8JxLfXSTr/4MiSRUJ+hk xIaINAqGLNijTwq1cHYzwTC8Kl0A3r5Qo5r1B33RoUnd5YRag6V+HosxwW8cVZulf/TS9l 8i8kYjkmP/ltSzYPzSnJRO19FGBSFMlaezoILrh/gXrhKzAaCUT+gMbrSjsqAA== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A77D41BF204; Fri, 26 May 2023 17:09:06 +0000 (UTC) Date: Fri, 26 May 2023 19:09:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v4 3/5] mtd: rawnand: meson: always read whole OOB bytes Message-ID: <20230526190905.1d5a3821@xps-13> In-Reply-To: <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-4-AVKrasnov@sberdevices.ru> <20230522173813.08afe6b8@xps-13> <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_100911_560888_56E0D24E X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUdWUsIDIzIE1h eSAyMDIzIDIwOjI3OjM1ICswMzAwOgoKPiBPbiAyMi4wNS4yMDIzIDE4OjM4LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gQVZLcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIE1vbiwgMTUgTWF5IDIwMjMgMTI6NDQ6MzcgKzAzMDA6Cj4gPiAgIAo+ID4+ IFRoaXMgY2hhbmdlcyBzaXplIG9mIHJlYWQgYWNjZXNzIHRvIE9PQiBhcmVhIGJ5IHJlYWRpbmcg YWxsIGJ5dGVzIG9mCj4gPj4gT09CIChmcmVlIGJ5dGVzICsgRUNDIGVuZ2luZSBieXRlcykuICAK PiA+IAo+ID4gVGhpcyBpcyBub3JtYWxseSB1cCB0byB0aGUgdXNlciAodXNlciBpbiB5b3VyIGNh c2UgPT0gamZmczIpLiBUaGUKPiA+IGNvbnRyb2xsZXIgZHJpdmVyIHNob3VsZCBleHBvc2UgYSBu dW1iZXIgb2YgdXNlciBhY2Nlc3NpYmxlIGJ5dGVzIGFuZAo+ID4gdGhlbiB3aGVuIHVzZXJzIHdh bnQgdGhlIE9PQiBhcmVhLCB0aGV5IHNob3VsZCBhY2Nlc3MgaXQgZW50aXJlbHkuIE9uCj4gPiB0 b3Agb2YgdGhhdCByZWFkLCB0aGV5IGNhbiBleHRyYWN0IChvciAid3JpdGUgb25seSIpIHRoZSB1 c2VyIGJ5dGVzLiAgCj4gCj4gU29ycnksIEkgZGlkbid0IGdldCBpdC4gSWYgZHJpdmVyIGV4cG9z ZXMgTiBieXRlcyBvZiB1c2VyIGFjY2Vzc2libGUgYnl0ZXMsCj4gSSBtdXN0IGFsd2F5cyByZXR1 cm4gd2hvbGUgT09CIHllcz8gRS5nLiBOICsgcmVzdCBvZiBPT0IKClllcy4gQXQgdGhlIE5BTkQg Y29udHJvbGxlciBsZXZlbCwgeW91IGdldCBhc2tlZCBmb3IgZWl0aGVyIGEgcGFnZSBvZgpkYXRh IChzb21ldGltZXMgYSBzdWJwYWdlLCBidXQgd2hhdGV2ZXIpLCBhbmQvb3IgdGhlIG9vYiBhcmVh LiBZb3UgbmVlZAp0byBwcm92aWRlIHdoYXQgaXMgcmVxdWVzdGVkLCBubyBtb3JlLCBubyBsZXNz LiBUaGUgdXBwZXIgbGF5ZXJzIHdpbGwKdHJpbSBkb3duIHdoYXQncyB1bmVlZGVkIGFuZCBleHRy YWN0IHRoZSBieXRlcyB0aGV5IHdhbnQuCgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFyc2VuaXkgS3Jh c25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL210 ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysKPiA+ PiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jh dy9tZXNvbl9uYW5kLmMKPiA+PiBpbmRleCA4NTI2YTZiODc3MjAuLmEzMTEwNmM5NDNkNyAxMDA2 NDQKPiA+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiArKysg Yi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiBAQCAtNzU1LDYgKzc1NSwz MCBAQCBzdGF0aWMgaW50IF9fbWVzb25fbmZjX3JlYWRfb29iKHN0cnVjdCBuYW5kX2NoaXAgKm5h bmQsIGludCBwYWdlLAo+ID4+ICAJdTMyIG9vYl9ieXRlczsKPiA+PiAgCXUzMiBwYWdlX3NpemU7 Cj4gPj4gIAlpbnQgcmV0Owo+ID4+ICsJaW50IGk7Cj4gPj4gKwo+ID4+ICsJLyogUmVhZCBFQ0Mg Y29kZXMgYW5kIHVzZXIgYnl0ZXMuICovCj4gPj4gKwlmb3IgKGkgPSAwOyBpIDwgbmFuZC0+ZWNj LnN0ZXBzOyBpKyspIHsKPiA+PiArCQl1MzIgZWNjX29mZnMgPSBuYW5kLT5lY2Muc2l6ZSAqIChp ICsgMSkgKwo+ID4+ICsJCQkgICAgICAgTkZDX09PQl9QRVJfRUNDKG5hbmQpICogaTsKPiA+PiAr Cj4gPj4gKwkJcmV0ID0gbmFuZF9yZWFkX3BhZ2Vfb3AobmFuZCwgcGFnZSwgMCwgTlVMTCwgMCk7 Cj4gPj4gKwkJaWYgKHJldCkKPiA+PiArCQkJcmV0dXJuIHJldDsKPiA+PiArCj4gPj4gKwkJLyog VXNlIHRlbXBvcmFyeSBidWZmZXIsIGJlY2F1c2UgJ25hbmRfY2hhbmdlX3JlYWRfY29sdW1uX29w KCknCj4gPj4gKwkJICogc2VlbXMgd29yayB3aXRoIHNvbWUgYWxpZ25tZW50LCBzbyB3ZSBjYW4n dCByZWFkIGRhdGEgdG8KPiA+PiArCQkgKiAnb29iX2J1ZicgZGlyZWN0bHkuICAKPiA+IAo+ID4g RE1BPyAgCj4gCj4gWWVzIEkgZ3Vlc3MsIHRoaXMgYWRkcmVzcyBwYXNzZWQgdG8gZXhlY19vcCBj b2RlIGFuZCB1c2VkIGFzIERNQS4KCklmIHlvdXIgY29udHJvbGxlciB1c2VzIERNQSBvbiBleGVj X29wIGFjY2Vzc2VzLCB0aGVuIHllcy4gRXhlY19vcApyZWFkcy93cml0ZXMgYXJlIHVzdWFsbHkg c21hbGwgZW5vdWdoIChvciBub3QgdGltZSBzZW5zaXRpdmUgYXQgYWxsIGlmCnRoZXkgYXJlIGJp Z2dlcikgc28gaXQncyBub3QgcmVxdWlyZWQgdG8gdXNlIERNQSB0aGVyZS4gQW55aG93LCBvb2Jf YnVmCmlzIHN1aXRhYmxlIGZvciBETUEgcHVycG9zZXMsIHNvIEknbSBhIGJpdCBzdXJwcmlzZWQg eW91IG5lZWQgYSBib3VuY2UKYnVmZmVyLCBpZiB0aGF0J3MgdGhlIG9ubHkgcmVhc29uLiBNYXli ZSB5b3UgbmVlZCBhIGJvdW5jZSBidWZmZXIgdG8KcmVvcmdhbml6ZSB0aGUgZGF0YS4gVGhhdCB3 b3VsZCBiZSBhIG11Y2ggYmV0dGVyIGV4cGxhbmF0aW9uLgoKPiA+PiArCQkgKi8KPiA+PiArCQly ZXQgPSBuYW5kX2NoYW5nZV9yZWFkX2NvbHVtbl9vcChuYW5kLCBlY2Nfb2ZmcywgbWVzb25fY2hp cC0+b29iX2J1ZiwKPiA+PiArCQkJCQkJIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwgZmFsc2UpOwo+ ID4+ICsJCWlmIChyZXQpCj4gPj4gKwkJCXJldHVybiByZXQ7Cj4gPj4gKwo+ID4+ICsJCW1lbWNw eShvb2JfYnVmICsgaSAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwKPiA+PiArCQkgICAgICAgbWVz b25fY2hpcC0+b29iX2J1ZiwKPiA+PiArCQkgICAgICAgTkZDX09PQl9QRVJfRUNDKG5hbmQpKTsK PiA+PiArCX0KPiA+PiAgCj4gPj4gIAlvb2JfYnl0ZXMgPSBtZXNvbl9uZmNfZ2V0X29vYl9ieXRl cyhuYW5kKTsKPiA+PiAgICAKPiA+IAo+ID4gCj4gPiBUaGFua3MsCj4gPiBNaXF1w6hsICAKPiAK PiBUaGFua3MsIEFyc2VuaXkKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0Cmxp bnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4406EC77B7A for ; Fri, 26 May 2023 17:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WbZFsEAi9Z2Fbjx8uzMDcmHBq00RpcHegxmcPRjDWWs=; b=xlKrPXggZZI7va xZM0eSehdi1tGShI1xCeOTxf2gI6KQc2AMkSaTZm1EjWU5og4PLskcvVzf2y0mCtKqJY4NjduaKSu zTzkXuhaiGFk2m10NCVGJCyFFrCDn7dgOO//sEq3xNvTLeFwzfH1k+gev20CnnfcRUup1Upch7RVg UMWN/dnlAL/+i8aVApa/QwpGILMQb3JA6847huLQDCxrfwxdwQ84aOBlCbhQVMv2S3PHhtb+/efgg HPPASLQtURCygG9jlp6ELS82KX1H1m+PhFhIJ3qVa/RdVF/xPLU7tLYZYCKy/I2bmVxvC/fSb2bBn pDvbtj6xHkzYtaWmqo5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2awF-003Ewr-2T; Fri, 26 May 2023 17:09:15 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2awB-003Eve-0l; Fri, 26 May 2023 17:09:12 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685120948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdi3+7iY1FuuVZkTHEgLzoKSqhn5EptZQCzuKXVDC0s=; b=ZtKAWITht2MZsPftTNyQR0rssOpfR0x0RkKpyVvkGXiNJijisFlfgOqCuq/mhPJtyz5Ror uRm31TWwLlCyu95bUA/IWD5Xdlxq+UBmuwB5dRL9pGUc/rSbm8Hw0/nz6tm6YLkVvfWPST VYEsq1Va1Qg7/9FKOmqfUqUOs17k4nlWHKEuMYLTOxBf1UPqoC8JxLfXSTr/4MiSRUJ+hk xIaINAqGLNijTwq1cHYzwTC8Kl0A3r5Qo5r1B33RoUnd5YRag6V+HosxwW8cVZulf/TS9l 8i8kYjkmP/ltSzYPzSnJRO19FGBSFMlaezoILrh/gXrhKzAaCUT+gMbrSjsqAA== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A77D41BF204; Fri, 26 May 2023 17:09:06 +0000 (UTC) Date: Fri, 26 May 2023 19:09:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v4 3/5] mtd: rawnand: meson: always read whole OOB bytes Message-ID: <20230526190905.1d5a3821@xps-13> In-Reply-To: <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-4-AVKrasnov@sberdevices.ru> <20230522173813.08afe6b8@xps-13> <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_100911_560888_56E0D24E X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUdWUsIDIzIE1h eSAyMDIzIDIwOjI3OjM1ICswMzAwOgoKPiBPbiAyMi4wNS4yMDIzIDE4OjM4LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gQVZLcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIE1vbiwgMTUgTWF5IDIwMjMgMTI6NDQ6MzcgKzAzMDA6Cj4gPiAgIAo+ID4+ IFRoaXMgY2hhbmdlcyBzaXplIG9mIHJlYWQgYWNjZXNzIHRvIE9PQiBhcmVhIGJ5IHJlYWRpbmcg YWxsIGJ5dGVzIG9mCj4gPj4gT09CIChmcmVlIGJ5dGVzICsgRUNDIGVuZ2luZSBieXRlcykuICAK PiA+IAo+ID4gVGhpcyBpcyBub3JtYWxseSB1cCB0byB0aGUgdXNlciAodXNlciBpbiB5b3VyIGNh c2UgPT0gamZmczIpLiBUaGUKPiA+IGNvbnRyb2xsZXIgZHJpdmVyIHNob3VsZCBleHBvc2UgYSBu dW1iZXIgb2YgdXNlciBhY2Nlc3NpYmxlIGJ5dGVzIGFuZAo+ID4gdGhlbiB3aGVuIHVzZXJzIHdh bnQgdGhlIE9PQiBhcmVhLCB0aGV5IHNob3VsZCBhY2Nlc3MgaXQgZW50aXJlbHkuIE9uCj4gPiB0 b3Agb2YgdGhhdCByZWFkLCB0aGV5IGNhbiBleHRyYWN0IChvciAid3JpdGUgb25seSIpIHRoZSB1 c2VyIGJ5dGVzLiAgCj4gCj4gU29ycnksIEkgZGlkbid0IGdldCBpdC4gSWYgZHJpdmVyIGV4cG9z ZXMgTiBieXRlcyBvZiB1c2VyIGFjY2Vzc2libGUgYnl0ZXMsCj4gSSBtdXN0IGFsd2F5cyByZXR1 cm4gd2hvbGUgT09CIHllcz8gRS5nLiBOICsgcmVzdCBvZiBPT0IKClllcy4gQXQgdGhlIE5BTkQg Y29udHJvbGxlciBsZXZlbCwgeW91IGdldCBhc2tlZCBmb3IgZWl0aGVyIGEgcGFnZSBvZgpkYXRh IChzb21ldGltZXMgYSBzdWJwYWdlLCBidXQgd2hhdGV2ZXIpLCBhbmQvb3IgdGhlIG9vYiBhcmVh LiBZb3UgbmVlZAp0byBwcm92aWRlIHdoYXQgaXMgcmVxdWVzdGVkLCBubyBtb3JlLCBubyBsZXNz LiBUaGUgdXBwZXIgbGF5ZXJzIHdpbGwKdHJpbSBkb3duIHdoYXQncyB1bmVlZGVkIGFuZCBleHRy YWN0IHRoZSBieXRlcyB0aGV5IHdhbnQuCgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFyc2VuaXkgS3Jh c25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL210 ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysKPiA+ PiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jh dy9tZXNvbl9uYW5kLmMKPiA+PiBpbmRleCA4NTI2YTZiODc3MjAuLmEzMTEwNmM5NDNkNyAxMDA2 NDQKPiA+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiArKysg Yi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiBAQCAtNzU1LDYgKzc1NSwz MCBAQCBzdGF0aWMgaW50IF9fbWVzb25fbmZjX3JlYWRfb29iKHN0cnVjdCBuYW5kX2NoaXAgKm5h bmQsIGludCBwYWdlLAo+ID4+ICAJdTMyIG9vYl9ieXRlczsKPiA+PiAgCXUzMiBwYWdlX3NpemU7 Cj4gPj4gIAlpbnQgcmV0Owo+ID4+ICsJaW50IGk7Cj4gPj4gKwo+ID4+ICsJLyogUmVhZCBFQ0Mg Y29kZXMgYW5kIHVzZXIgYnl0ZXMuICovCj4gPj4gKwlmb3IgKGkgPSAwOyBpIDwgbmFuZC0+ZWNj LnN0ZXBzOyBpKyspIHsKPiA+PiArCQl1MzIgZWNjX29mZnMgPSBuYW5kLT5lY2Muc2l6ZSAqIChp ICsgMSkgKwo+ID4+ICsJCQkgICAgICAgTkZDX09PQl9QRVJfRUNDKG5hbmQpICogaTsKPiA+PiAr Cj4gPj4gKwkJcmV0ID0gbmFuZF9yZWFkX3BhZ2Vfb3AobmFuZCwgcGFnZSwgMCwgTlVMTCwgMCk7 Cj4gPj4gKwkJaWYgKHJldCkKPiA+PiArCQkJcmV0dXJuIHJldDsKPiA+PiArCj4gPj4gKwkJLyog VXNlIHRlbXBvcmFyeSBidWZmZXIsIGJlY2F1c2UgJ25hbmRfY2hhbmdlX3JlYWRfY29sdW1uX29w KCknCj4gPj4gKwkJICogc2VlbXMgd29yayB3aXRoIHNvbWUgYWxpZ25tZW50LCBzbyB3ZSBjYW4n dCByZWFkIGRhdGEgdG8KPiA+PiArCQkgKiAnb29iX2J1ZicgZGlyZWN0bHkuICAKPiA+IAo+ID4g RE1BPyAgCj4gCj4gWWVzIEkgZ3Vlc3MsIHRoaXMgYWRkcmVzcyBwYXNzZWQgdG8gZXhlY19vcCBj b2RlIGFuZCB1c2VkIGFzIERNQS4KCklmIHlvdXIgY29udHJvbGxlciB1c2VzIERNQSBvbiBleGVj X29wIGFjY2Vzc2VzLCB0aGVuIHllcy4gRXhlY19vcApyZWFkcy93cml0ZXMgYXJlIHVzdWFsbHkg c21hbGwgZW5vdWdoIChvciBub3QgdGltZSBzZW5zaXRpdmUgYXQgYWxsIGlmCnRoZXkgYXJlIGJp Z2dlcikgc28gaXQncyBub3QgcmVxdWlyZWQgdG8gdXNlIERNQSB0aGVyZS4gQW55aG93LCBvb2Jf YnVmCmlzIHN1aXRhYmxlIGZvciBETUEgcHVycG9zZXMsIHNvIEknbSBhIGJpdCBzdXJwcmlzZWQg eW91IG5lZWQgYSBib3VuY2UKYnVmZmVyLCBpZiB0aGF0J3MgdGhlIG9ubHkgcmVhc29uLiBNYXli ZSB5b3UgbmVlZCBhIGJvdW5jZSBidWZmZXIgdG8KcmVvcmdhbml6ZSB0aGUgZGF0YS4gVGhhdCB3 b3VsZCBiZSBhIG11Y2ggYmV0dGVyIGV4cGxhbmF0aW9uLgoKPiA+PiArCQkgKi8KPiA+PiArCQly ZXQgPSBuYW5kX2NoYW5nZV9yZWFkX2NvbHVtbl9vcChuYW5kLCBlY2Nfb2ZmcywgbWVzb25fY2hp cC0+b29iX2J1ZiwKPiA+PiArCQkJCQkJIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwgZmFsc2UpOwo+ ID4+ICsJCWlmIChyZXQpCj4gPj4gKwkJCXJldHVybiByZXQ7Cj4gPj4gKwo+ID4+ICsJCW1lbWNw eShvb2JfYnVmICsgaSAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwKPiA+PiArCQkgICAgICAgbWVz b25fY2hpcC0+b29iX2J1ZiwKPiA+PiArCQkgICAgICAgTkZDX09PQl9QRVJfRUNDKG5hbmQpKTsK PiA+PiArCX0KPiA+PiAgCj4gPj4gIAlvb2JfYnl0ZXMgPSBtZXNvbl9uZmNfZ2V0X29vYl9ieXRl cyhuYW5kKTsKPiA+PiAgICAKPiA+IAo+ID4gCj4gPiBUaGFua3MsCj4gPiBNaXF1w6hsICAKPiAK PiBUaGFua3MsIEFyc2VuaXkKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBt YWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87FE3C7EE23 for ; Fri, 26 May 2023 17:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fv0cqvM4dprYvDlRv8OXwwnaD/eU8ccE+1ZpQvUusHQ=; b=xRw+haBwmiKM4A F1UdCXlY7qc4AZNQgitGe6bQyYGRZRXN8PIsp0+NzleaJ1ZKBLT+HSuKnbPCFS4RyFxzDNOhEwWrT ipHFr6nKXWvL0aFM7HO2K7kg67ZpfaLrIeNdtFx1VJCz9eGw3B4Vc4wHUsG01s6Z48zLb70JJRqEP tXbhBg59x+I2xfgM9v52I3RsmAdxowAyGtbOI2PAD03k9IF+Um9why97Mb0Nm3iVwoJgJgOH2Ox0X brnid9x36/KfQqIApW8ctrz54atD9Yq0tiTJebv1mFqsyWRymMbyiXq2OnMfZvURShUwgo3YPKJIp prAeHwsMGQCE5RY4pxvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2awF-003Ewa-0i; Fri, 26 May 2023 17:09:15 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2awB-003Eve-0l; Fri, 26 May 2023 17:09:12 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685120948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdi3+7iY1FuuVZkTHEgLzoKSqhn5EptZQCzuKXVDC0s=; b=ZtKAWITht2MZsPftTNyQR0rssOpfR0x0RkKpyVvkGXiNJijisFlfgOqCuq/mhPJtyz5Ror uRm31TWwLlCyu95bUA/IWD5Xdlxq+UBmuwB5dRL9pGUc/rSbm8Hw0/nz6tm6YLkVvfWPST VYEsq1Va1Qg7/9FKOmqfUqUOs17k4nlWHKEuMYLTOxBf1UPqoC8JxLfXSTr/4MiSRUJ+hk xIaINAqGLNijTwq1cHYzwTC8Kl0A3r5Qo5r1B33RoUnd5YRag6V+HosxwW8cVZulf/TS9l 8i8kYjkmP/ltSzYPzSnJRO19FGBSFMlaezoILrh/gXrhKzAaCUT+gMbrSjsqAA== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A77D41BF204; Fri, 26 May 2023 17:09:06 +0000 (UTC) Date: Fri, 26 May 2023 19:09:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v4 3/5] mtd: rawnand: meson: always read whole OOB bytes Message-ID: <20230526190905.1d5a3821@xps-13> In-Reply-To: <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-4-AVKrasnov@sberdevices.ru> <20230522173813.08afe6b8@xps-13> <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_100911_560888_56E0D24E X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUdWUsIDIzIE1h eSAyMDIzIDIwOjI3OjM1ICswMzAwOgoKPiBPbiAyMi4wNS4yMDIzIDE4OjM4LCBNaXF1ZWwgUmF5 bmFsIHdyb3RlOgo+ID4gSGkgQXJzZW5peSwKPiA+IAo+ID4gQVZLcmFzbm92QHNiZXJkZXZpY2Vz LnJ1IHdyb3RlIG9uIE1vbiwgMTUgTWF5IDIwMjMgMTI6NDQ6MzcgKzAzMDA6Cj4gPiAgIAo+ID4+ IFRoaXMgY2hhbmdlcyBzaXplIG9mIHJlYWQgYWNjZXNzIHRvIE9PQiBhcmVhIGJ5IHJlYWRpbmcg YWxsIGJ5dGVzIG9mCj4gPj4gT09CIChmcmVlIGJ5dGVzICsgRUNDIGVuZ2luZSBieXRlcykuICAK PiA+IAo+ID4gVGhpcyBpcyBub3JtYWxseSB1cCB0byB0aGUgdXNlciAodXNlciBpbiB5b3VyIGNh c2UgPT0gamZmczIpLiBUaGUKPiA+IGNvbnRyb2xsZXIgZHJpdmVyIHNob3VsZCBleHBvc2UgYSBu dW1iZXIgb2YgdXNlciBhY2Nlc3NpYmxlIGJ5dGVzIGFuZAo+ID4gdGhlbiB3aGVuIHVzZXJzIHdh bnQgdGhlIE9PQiBhcmVhLCB0aGV5IHNob3VsZCBhY2Nlc3MgaXQgZW50aXJlbHkuIE9uCj4gPiB0 b3Agb2YgdGhhdCByZWFkLCB0aGV5IGNhbiBleHRyYWN0IChvciAid3JpdGUgb25seSIpIHRoZSB1 c2VyIGJ5dGVzLiAgCj4gCj4gU29ycnksIEkgZGlkbid0IGdldCBpdC4gSWYgZHJpdmVyIGV4cG9z ZXMgTiBieXRlcyBvZiB1c2VyIGFjY2Vzc2libGUgYnl0ZXMsCj4gSSBtdXN0IGFsd2F5cyByZXR1 cm4gd2hvbGUgT09CIHllcz8gRS5nLiBOICsgcmVzdCBvZiBPT0IKClllcy4gQXQgdGhlIE5BTkQg Y29udHJvbGxlciBsZXZlbCwgeW91IGdldCBhc2tlZCBmb3IgZWl0aGVyIGEgcGFnZSBvZgpkYXRh IChzb21ldGltZXMgYSBzdWJwYWdlLCBidXQgd2hhdGV2ZXIpLCBhbmQvb3IgdGhlIG9vYiBhcmVh LiBZb3UgbmVlZAp0byBwcm92aWRlIHdoYXQgaXMgcmVxdWVzdGVkLCBubyBtb3JlLCBubyBsZXNz LiBUaGUgdXBwZXIgbGF5ZXJzIHdpbGwKdHJpbSBkb3duIHdoYXQncyB1bmVlZGVkIGFuZCBleHRy YWN0IHRoZSBieXRlcyB0aGV5IHdhbnQuCgo+ID4+IFNpZ25lZC1vZmYtYnk6IEFyc2VuaXkgS3Jh c25vdiA8QVZLcmFzbm92QHNiZXJkZXZpY2VzLnJ1Pgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL210 ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKysKPiA+ PiAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKykKPiA+Pgo+ID4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jh dy9tZXNvbl9uYW5kLmMKPiA+PiBpbmRleCA4NTI2YTZiODc3MjAuLmEzMTEwNmM5NDNkNyAxMDA2 NDQKPiA+PiAtLS0gYS9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiArKysg Yi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiA+PiBAQCAtNzU1LDYgKzc1NSwz MCBAQCBzdGF0aWMgaW50IF9fbWVzb25fbmZjX3JlYWRfb29iKHN0cnVjdCBuYW5kX2NoaXAgKm5h bmQsIGludCBwYWdlLAo+ID4+ICAJdTMyIG9vYl9ieXRlczsKPiA+PiAgCXUzMiBwYWdlX3NpemU7 Cj4gPj4gIAlpbnQgcmV0Owo+ID4+ICsJaW50IGk7Cj4gPj4gKwo+ID4+ICsJLyogUmVhZCBFQ0Mg Y29kZXMgYW5kIHVzZXIgYnl0ZXMuICovCj4gPj4gKwlmb3IgKGkgPSAwOyBpIDwgbmFuZC0+ZWNj LnN0ZXBzOyBpKyspIHsKPiA+PiArCQl1MzIgZWNjX29mZnMgPSBuYW5kLT5lY2Muc2l6ZSAqIChp ICsgMSkgKwo+ID4+ICsJCQkgICAgICAgTkZDX09PQl9QRVJfRUNDKG5hbmQpICogaTsKPiA+PiAr Cj4gPj4gKwkJcmV0ID0gbmFuZF9yZWFkX3BhZ2Vfb3AobmFuZCwgcGFnZSwgMCwgTlVMTCwgMCk7 Cj4gPj4gKwkJaWYgKHJldCkKPiA+PiArCQkJcmV0dXJuIHJldDsKPiA+PiArCj4gPj4gKwkJLyog VXNlIHRlbXBvcmFyeSBidWZmZXIsIGJlY2F1c2UgJ25hbmRfY2hhbmdlX3JlYWRfY29sdW1uX29w KCknCj4gPj4gKwkJICogc2VlbXMgd29yayB3aXRoIHNvbWUgYWxpZ25tZW50LCBzbyB3ZSBjYW4n dCByZWFkIGRhdGEgdG8KPiA+PiArCQkgKiAnb29iX2J1ZicgZGlyZWN0bHkuICAKPiA+IAo+ID4g RE1BPyAgCj4gCj4gWWVzIEkgZ3Vlc3MsIHRoaXMgYWRkcmVzcyBwYXNzZWQgdG8gZXhlY19vcCBj b2RlIGFuZCB1c2VkIGFzIERNQS4KCklmIHlvdXIgY29udHJvbGxlciB1c2VzIERNQSBvbiBleGVj X29wIGFjY2Vzc2VzLCB0aGVuIHllcy4gRXhlY19vcApyZWFkcy93cml0ZXMgYXJlIHVzdWFsbHkg c21hbGwgZW5vdWdoIChvciBub3QgdGltZSBzZW5zaXRpdmUgYXQgYWxsIGlmCnRoZXkgYXJlIGJp Z2dlcikgc28gaXQncyBub3QgcmVxdWlyZWQgdG8gdXNlIERNQSB0aGVyZS4gQW55aG93LCBvb2Jf YnVmCmlzIHN1aXRhYmxlIGZvciBETUEgcHVycG9zZXMsIHNvIEknbSBhIGJpdCBzdXJwcmlzZWQg eW91IG5lZWQgYSBib3VuY2UKYnVmZmVyLCBpZiB0aGF0J3MgdGhlIG9ubHkgcmVhc29uLiBNYXli ZSB5b3UgbmVlZCBhIGJvdW5jZSBidWZmZXIgdG8KcmVvcmdhbml6ZSB0aGUgZGF0YS4gVGhhdCB3 b3VsZCBiZSBhIG11Y2ggYmV0dGVyIGV4cGxhbmF0aW9uLgoKPiA+PiArCQkgKi8KPiA+PiArCQly ZXQgPSBuYW5kX2NoYW5nZV9yZWFkX2NvbHVtbl9vcChuYW5kLCBlY2Nfb2ZmcywgbWVzb25fY2hp cC0+b29iX2J1ZiwKPiA+PiArCQkJCQkJIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwgZmFsc2UpOwo+ ID4+ICsJCWlmIChyZXQpCj4gPj4gKwkJCXJldHVybiByZXQ7Cj4gPj4gKwo+ID4+ICsJCW1lbWNw eShvb2JfYnVmICsgaSAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwKPiA+PiArCQkgICAgICAgbWVz b25fY2hpcC0+b29iX2J1ZiwKPiA+PiArCQkgICAgICAgTkZDX09PQl9QRVJfRUNDKG5hbmQpKTsK PiA+PiArCX0KPiA+PiAgCj4gPj4gIAlvb2JfYnl0ZXMgPSBtZXNvbl9uZmNfZ2V0X29vYl9ieXRl cyhuYW5kKTsKPiA+PiAgICAKPiA+IAo+ID4gCj4gPiBUaGFua3MsCj4gPiBNaXF1w6hsICAKPiAK PiBUaGFua3MsIEFyc2VuaXkKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACCC4C7EE2C for ; Fri, 26 May 2023 17:09:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242138AbjEZRJW (ORCPT ); Fri, 26 May 2023 13:09:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236757AbjEZRJU (ORCPT ); Fri, 26 May 2023 13:09:20 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 935F51B4 for ; Fri, 26 May 2023 10:09:10 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685120948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdi3+7iY1FuuVZkTHEgLzoKSqhn5EptZQCzuKXVDC0s=; b=ZtKAWITht2MZsPftTNyQR0rssOpfR0x0RkKpyVvkGXiNJijisFlfgOqCuq/mhPJtyz5Ror uRm31TWwLlCyu95bUA/IWD5Xdlxq+UBmuwB5dRL9pGUc/rSbm8Hw0/nz6tm6YLkVvfWPST VYEsq1Va1Qg7/9FKOmqfUqUOs17k4nlWHKEuMYLTOxBf1UPqoC8JxLfXSTr/4MiSRUJ+hk xIaINAqGLNijTwq1cHYzwTC8Kl0A3r5Qo5r1B33RoUnd5YRag6V+HosxwW8cVZulf/TS9l 8i8kYjkmP/ltSzYPzSnJRO19FGBSFMlaezoILrh/gXrhKzAaCUT+gMbrSjsqAA== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id A77D41BF204; Fri, 26 May 2023 17:09:06 +0000 (UTC) Date: Fri, 26 May 2023 19:09:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , Subject: Re: [PATCH v4 3/5] mtd: rawnand: meson: always read whole OOB bytes Message-ID: <20230526190905.1d5a3821@xps-13> In-Reply-To: <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> References: <20230515094440.3552094-1-AVKrasnov@sberdevices.ru> <20230515094440.3552094-4-AVKrasnov@sberdevices.ru> <20230522173813.08afe6b8@xps-13> <84a2e0c4-cc6f-1743-ee93-c13bc8bf09f1@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, avkrasnov@sberdevices.ru wrote on Tue, 23 May 2023 20:27:35 +0300: > On 22.05.2023 18:38, Miquel Raynal wrote: > > Hi Arseniy, > >=20 > > AVKrasnov@sberdevices.ru wrote on Mon, 15 May 2023 12:44:37 +0300: > > =20 > >> This changes size of read access to OOB area by reading all bytes of > >> OOB (free bytes + ECC engine bytes). =20 > >=20 > > This is normally up to the user (user in your case =3D=3D jffs2). The > > controller driver should expose a number of user accessible bytes and > > then when users want the OOB area, they should access it entirely. On > > top of that read, they can extract (or "write only") the user bytes. =20 >=20 > Sorry, I didn't get it. If driver exposes N bytes of user accessible byte= s, > I must always return whole OOB yes? E.g. N + rest of OOB Yes. At the NAND controller level, you get asked for either a page of data (sometimes a subpage, but whatever), and/or the oob area. You need to provide what is requested, no more, no less. The upper layers will trim down what's uneeded and extract the bytes they want. > >> Signed-off-by: Arseniy Krasnov > >> --- > >> drivers/mtd/nand/raw/meson_nand.c | 24 ++++++++++++++++++++++++ > >> 1 file changed, 24 insertions(+) > >> > >> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/= meson_nand.c > >> index 8526a6b87720..a31106c943d7 100644 > >> --- a/drivers/mtd/nand/raw/meson_nand.c > >> +++ b/drivers/mtd/nand/raw/meson_nand.c > >> @@ -755,6 +755,30 @@ static int __meson_nfc_read_oob(struct nand_chip = *nand, int page, > >> u32 oob_bytes; > >> u32 page_size; > >> int ret; > >> + int i; > >> + > >> + /* Read ECC codes and user bytes. */ > >> + for (i =3D 0; i < nand->ecc.steps; i++) { > >> + u32 ecc_offs =3D nand->ecc.size * (i + 1) + > >> + NFC_OOB_PER_ECC(nand) * i; > >> + > >> + ret =3D nand_read_page_op(nand, page, 0, NULL, 0); > >> + if (ret) > >> + return ret; > >> + > >> + /* Use temporary buffer, because 'nand_change_read_column_op()' > >> + * seems work with some alignment, so we can't read data to > >> + * 'oob_buf' directly. =20 > >=20 > > DMA? =20 >=20 > Yes I guess, this address passed to exec_op code and used as DMA. If your controller uses DMA on exec_op accesses, then yes. Exec_op reads/writes are usually small enough (or not time sensitive at all if they are bigger) so it's not required to use DMA there. Anyhow, oob_buf is suitable for DMA purposes, so I'm a bit surprised you need a bounce buffer, if that's the only reason. Maybe you need a bounce buffer to reorganize the data. That would be a much better explanation. > >> + */ > >> + ret =3D nand_change_read_column_op(nand, ecc_offs, meson_chip->oob_= buf, > >> + NFC_OOB_PER_ECC(nand), false); > >> + if (ret) > >> + return ret; > >> + > >> + memcpy(oob_buf + i * NFC_OOB_PER_ECC(nand), > >> + meson_chip->oob_buf, > >> + NFC_OOB_PER_ECC(nand)); > >> + } > >> =20 > >> oob_bytes =3D meson_nfc_get_oob_bytes(nand); > >> =20 > >=20 > >=20 > > Thanks, > > Miqu=C3=A8l =20 >=20 > Thanks, Arseniy Thanks, Miqu=C3=A8l