From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next,v1 2/6] netfilter: nf_tables: remove fast bitwise and cmp operations
Date: Fri, 26 May 2023 23:48:06 +0200 [thread overview]
Message-ID: <20230526214806.GB2532@breakpoint.cc> (raw)
In-Reply-To: <20230525154024.222338-3-pablo@netfilter.org>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> This patch removes r10fdd6d80e4c ("netfilter: nf_tables: Implement fast
> bitwise expression") and 23f68d462984 ("netfilter: nft_cmp: optimize
> comparison for 16-bytes") which aim to speed up matching on 128-bits and
> <= 32-bits fields with bitwise operations in favour of the new combo
> match approach.
No objections from my side, I see you retained the payload_fast helper
so ip saddr @bla isn't impacted.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2023-05-26 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 15:40 [PATCH nf-next,v1 0/6] nf_tables combo match Pablo Neira Ayuso
2023-05-25 15:40 ` [PATCH nf-next,v1 1/6] netfilter: nf_tables: remove expression reduce infrastructure Pablo Neira Ayuso
2023-05-26 21:49 ` Florian Westphal
2023-05-25 15:40 ` [PATCH nf-next,v1 2/6] netfilter: nf_tables: remove fast bitwise and cmp operations Pablo Neira Ayuso
2023-05-26 0:51 ` kernel test robot
2023-05-26 21:48 ` Florian Westphal [this message]
2023-05-25 15:40 ` [PATCH nf-next,v1 3/6] netfilter: nf_tables: add payload combo match Pablo Neira Ayuso
2023-05-25 15:40 ` [PATCH nf-next,v1 4/6] netfilter: nf_tables: add meta " Pablo Neira Ayuso
2023-05-26 21:52 ` Florian Westphal
2023-05-25 15:40 ` [PATCH nf-next,v1 5/6] netfilter: nf_tables: add payload bitwise " Pablo Neira Ayuso
2023-05-25 15:40 ` [PATCH nf-next,v1 6/6] netfilter: nf_tables: skip comment match when building blob Pablo Neira Ayuso
2023-05-25 15:50 ` [PATCH nf-next,v1 0/6] nf_tables combo match Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526214806.GB2532@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.