All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	arei.gonglei@huawei.com, qemu-devel@nongnu.org
Subject: Re: Re: [PATCH] cryptodev: fix memory leak during stats query
Date: Sun, 28 May 2023 07:29:29 -0400	[thread overview]
Message-ID: <20230528072913-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <6c5bb6a2-9177-ee9f-be7d-7394e8e54ff0@bytedance.com>

On Fri, May 26, 2023 at 04:34:21PM +0800, zhenwei pi wrote:
> 
> 
> On 5/3/23 20:59, Peter Maydell wrote:
> > On Wed, 3 May 2023 at 12:54, zhenwei pi <pizhenwei@bytedance.com> wrote:
> > > 
> > > object_get_canonical_path already returns newly allocated memory, this
> > > means no additional g_strdup required. Remove g_strdup to avoid memory
> > > leak.
> > > 
> > > Fixes: Coverity CID 1508074
> > > Fixes: f2b901098 ("cryptodev: Support query-stats QMP command")
> > > Cc: Peter Maydell <peter.maydell@linaro.org>
> > > Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> > > ---
> > 
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> > 
> > thanks
> > -- PMM
> 
> Hi, Michael
> 
> This patch has been ignored, could you please merge this in next PR?
> 
> -- 
> zhenwei pi
> 

I don't know why - didn't have it in my inbox. Tagged now, thanks!



      reply	other threads:[~2023-05-28 11:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 11:54 [PATCH] cryptodev: fix memory leak during stats query zhenwei pi
2023-05-03 12:59 ` Peter Maydell
2023-05-26  8:34   ` zhenwei pi
2023-05-28 11:29     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230528072913-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=arei.gonglei@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=pizhenwei@bytedance.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.