All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: David Ahern <dsahern@kernel.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] libtraceevent: Handle %c
Date: Mon, 29 May 2023 04:50:10 -0400	[thread overview]
Message-ID: <20230529045010.0b1e22ca@rorschach.local.home> (raw)
In-Reply-To: <20230508224121.12861-1-dsahern@kernel.org>

On Mon,  8 May 2023 16:41:21 -0600
David Ahern <dsahern@kernel.org> wrote:

> Use of %c in tracepoints is throwing off the argument order when printing
> event data via perf. Handle '%c' in parse_arg_format.
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>

Applied, Thanks David!

-- Steve

> ---
>  src/event-parse.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/event-parse.c b/src/event-parse.c
> index acf7fde4ead9..12c6f560019b 100644
> --- a/src/event-parse.c
> +++ b/src/event-parse.c
> @@ -6486,6 +6486,7 @@ static int parse_arg_format(struct tep_print_parse **parse,
>  			*arg = (*arg)->next;
>  			ret++;
>  			return ret;
> +		case 'c':
>  		case 'd':
>  		case 'u':
>  		case 'i':


      reply	other threads:[~2023-05-29  8:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 22:41 [PATCH] libtraceevent: Handle %c David Ahern
2023-05-29  8:50 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230529045010.0b1e22ca@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=dsahern@kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.