From: Kanchan Joshi <joshi.k@samsung.com>
To: "min15.li" <min15.li@samsung.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nvme: fix miss command type check
Date: Mon, 29 May 2023 11:43:28 +0530 [thread overview]
Message-ID: <20230529061328.GA11198@green245> (raw)
In-Reply-To: <20230526170656.55303-1-min15.li@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Fri, May 26, 2023 at 05:06:56PM +0000, min15.li wrote:
>In the function nvme_passthru_end(),only the value of the command opcode is
>checked, without checking the command type (IO command or Admin command).
>When we send a Dataset Management command (The opcode of the Dataset
>Management command is the same as the Set Feature command),kernel
>thinks it is a set feature command, then sets the controller's keep
> alive interval, and calls nvme_keep_alive_work().
>
>Signed-off-by: min15.li <min15.li@samsung.com>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2023-05-29 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230526090834epcas5p197a90228102b26759f9b957c50d3bb6b@epcas5p1.samsung.com>
2023-05-26 17:06 ` [PATCH v2] nvme: fix miss command type check min15.li
2023-05-26 9:22 ` Christoph Hellwig
2023-05-29 6:13 ` Kanchan Joshi [this message]
2023-05-30 16:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529061328.GA11198@green245 \
--to=joshi.k@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=min15.li@samsung.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.