From: Florian Westphal <fw@strlen.de>
To: Geliang Tang <geliang.tang@suse.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2 02/12] Squash to "mptcp: add sched in mptcp_sock"
Date: Mon, 29 May 2023 12:24:06 +0200 [thread overview]
Message-ID: <20230529102406.GA19295@breakpoint.cc> (raw)
In-Reply-To: <e74931ae5fd52b1353bf90727fbaedbc45c05a83.1685351620.git.geliang.tang@suse.com>
Geliang Tang <geliang.tang@suse.com> wrote:
> @@ -64,6 +64,10 @@ int mptcp_init_sched(struct mptcp_sock *msk,
> if (!bpf_try_module_get(sched, sched->owner))
> return -EBUSY;
>
> + msk->data = kzalloc(sizeof(struct mptcp_sched_data), GFP_ATOMIC);
> + if (!msk->data)
> + return -ENOMEM;
> +
Who will undo module_get call on sched->owner?
Might be a good idea to add a gfp_t arg to the function as well,
at least one caller could use GFP_KERNEL here.
data is a pretty generic name...
Maybe call ->data ->sched_data instead?
next prev parent reply other threads:[~2023-05-29 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 9:17 [PATCH mptcp-next v2 00/12] save sched_data at mptcp_sock Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 01/12] Squash to "mptcp: add struct mptcp_sched_ops" Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 02/12] Squash to "mptcp: add sched in mptcp_sock" Geliang Tang
2023-05-29 10:24 ` Florian Westphal [this message]
2023-05-29 9:17 ` [PATCH mptcp-next v2 03/12] Squash to "mptcp: add scheduler wrappers" Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 04/12] mptcp: add last_snd in sched_data Geliang Tang
2023-05-29 10:29 ` Florian Westphal
2023-05-29 9:17 ` [PATCH mptcp-next v2 05/12] mptcp: add snd_burst " Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 06/12] mptcp: register default scheduler Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 07/12] Squash to "bpf: Add bpf_mptcp_sched_ops" Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 08/12] Squash to "bpf: Add bpf_mptcp_sched_kfunc_set" Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 09/12] Squash to "selftests/bpf: Add mptcp sched structs" Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 10/12] Squash to "selftests/bpf: Add bpf_rr scheduler" Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 11/12] selftests/bpf: Add bpf_burst scheduler Geliang Tang
2023-05-29 9:17 ` [PATCH mptcp-next v2 12/12] selftests/bpf: Add bpf_burst test Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529102406.GA19295@breakpoint.cc \
--to=fw@strlen.de \
--cc=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.