From: Jakub Kicinski <kuba@kernel.org>
To: Parav Pandit <parav@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>,
davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: Make gro complete function to return void
Date: Tue, 30 May 2023 12:39:29 -0700 [thread overview]
Message-ID: <20230530123929.42472e9f@kernel.org> (raw)
In-Reply-To: <CANn89iLxUk6KpQ1a=Q+pNb95nkS6fYbHsuBGdxyTX23fuTGo6g@mail.gmail.com>
On Tue, 30 May 2023 17:48:22 +0200 Eric Dumazet wrote:
> > tcp_gro_complete seems fairly trivial. Any reason not to make it an
> > inline and avoid another function call in the datapath?
>
> Probably, although it is a regular function call, not an indirect one.
>
> In the grand total of driver rx napi + GRO cost, saving a few cycles
> per GRO completed packet is quite small.
IOW please make sure you include the performance analysis quantifying
the win, if you want to make this a static inline. Or let us know if
the patch is good as is, I'm keeping it in pw for now.
next prev parent reply other threads:[~2023-05-30 19:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 13:44 [PATCH net-next] net: Make gro complete function to return void Parav Pandit
2023-05-30 7:45 ` Simon Horman
2023-05-30 15:25 ` David Ahern
2023-05-30 15:39 ` Parav Pandit
2023-05-30 15:51 ` David Ahern
2023-05-30 15:48 ` Eric Dumazet
2023-05-30 19:39 ` Jakub Kicinski [this message]
2023-05-30 22:36 ` David Ahern
2023-05-31 4:38 ` Eric Dumazet
2023-05-31 17:07 ` Parav Pandit
2023-05-31 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530123929.42472e9f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.