From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael Tsirkin" <mst@redhat.com>,
"Fan Ni" <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org, linuxarm@huawei.com,
"Ira Weiny" <ira.weiny@intel.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dave Jiang" <dave.jiang@intel.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Mike Maslenkin" <mike.maslenkin@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH v8 7/7] hw/cxl/events: Add injection of Memory Module Events
Date: Tue, 30 May 2023 14:33:18 +0100 [thread overview]
Message-ID: <20230530143318.00005430@Huawei.com> (raw)
In-Reply-To: <87wn0u4953.fsf@pond.sub.org>
...
> > +#
> > +# @corrected-persistent-error-count: Total number correctable errors
>
> Total number of correctable errors
Gah. I've now seen these too often so read that a good 5 times before
working out what was wrong!
>
> > +# in persistent memory
> > +#
> > +# Since: 8.1
> > +##
> > +{ 'command': 'cxl-inject-memory-module-event',
> > + 'data': { 'path': 'str', 'log': 'CxlEventLog', 'flags' : 'uint8',
> > + 'type': 'uint8', 'health-status': 'uint8',
> > + 'media-status': 'uint8', 'additional-status': 'uint8',
> > + 'life-used': 'uint8', 'temperature' : 'int16',
> > + 'dirty-shutdown-count': 'uint32',
> > + 'corrected-volatile-error-count': 'uint32',
> > + 'corrected-persistent-error-count': 'uint32'
> > + }}
> > +
> > ##
> > # @cxl-inject-poison:
> > #
>
> Neither these nitpicks nor the one on PATCH 5 calls for a respin.
> Simply fix them in the PR. Thanks!
Thanks but for now Michael Tsirkin is still picking up the CXL focused
series based on patch sets so I'll spin a v9 with this stuff tidied up.
While, not true of this particular set, a lot of the CXL series are still
impacting the generic PCI code and so far Michael has been happy with that
approach.
Jonathan
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael Tsirkin" <mst@redhat.com>,
"Fan Ni" <fan.ni@samsung.com>,
linux-cxl@vger.kernel.org, linuxarm@huawei.com,
"Ira Weiny" <ira.weiny@intel.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Dave Jiang" <dave.jiang@intel.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Mike Maslenkin" <mike.maslenkin@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH v8 7/7] hw/cxl/events: Add injection of Memory Module Events
Date: Tue, 30 May 2023 14:33:18 +0100 [thread overview]
Message-ID: <20230530143318.00005430@Huawei.com> (raw)
In-Reply-To: <87wn0u4953.fsf@pond.sub.org>
...
> > +#
> > +# @corrected-persistent-error-count: Total number correctable errors
>
> Total number of correctable errors
Gah. I've now seen these too often so read that a good 5 times before
working out what was wrong!
>
> > +# in persistent memory
> > +#
> > +# Since: 8.1
> > +##
> > +{ 'command': 'cxl-inject-memory-module-event',
> > + 'data': { 'path': 'str', 'log': 'CxlEventLog', 'flags' : 'uint8',
> > + 'type': 'uint8', 'health-status': 'uint8',
> > + 'media-status': 'uint8', 'additional-status': 'uint8',
> > + 'life-used': 'uint8', 'temperature' : 'int16',
> > + 'dirty-shutdown-count': 'uint32',
> > + 'corrected-volatile-error-count': 'uint32',
> > + 'corrected-persistent-error-count': 'uint32'
> > + }}
> > +
> > ##
> > # @cxl-inject-poison:
> > #
>
> Neither these nitpicks nor the one on PATCH 5 calls for a respin.
> Simply fix them in the PR. Thanks!
Thanks but for now Michael Tsirkin is still picking up the CXL focused
series based on patch sets so I'll spin a v9 with this stuff tidied up.
While, not true of this particular set, a lot of the CXL series are still
impacting the generic PCI code and so far Michael has been happy with that
approach.
Jonathan
next prev parent reply other threads:[~2023-05-30 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 17:12 [PATCH v8 0/7] QEMU CXL Provide mock CXL events and irq support Jonathan Cameron
2023-05-26 17:12 ` Jonathan Cameron via
2023-05-26 17:12 ` [PATCH v8 1/7] hw/cxl/events: Add event status register Jonathan Cameron
2023-05-26 17:12 ` Jonathan Cameron via
2023-05-26 17:12 ` [PATCH v8 2/7] hw/cxl: Move CXLRetCode definition to cxl_device.h Jonathan Cameron
2023-05-26 17:12 ` Jonathan Cameron via
2023-05-26 17:13 ` [PATCH v8 3/7] hw/cxl/events: Wire up get/clear event mailbox commands Jonathan Cameron
2023-05-26 17:13 ` Jonathan Cameron via
2023-05-26 17:13 ` [PATCH v8 4/7] hw/cxl/events: Add event interrupt support Jonathan Cameron
2023-05-26 17:13 ` Jonathan Cameron via
2023-05-26 17:13 ` [PATCH v8 5/7] hw/cxl/events: Add injection of General Media Events Jonathan Cameron
2023-05-26 17:13 ` Jonathan Cameron via
2023-05-27 5:47 ` Markus Armbruster
2023-05-26 17:13 ` [PATCH v8 6/7] hw/cxl/events: Add injection of DRAM events Jonathan Cameron
2023-05-26 17:13 ` Jonathan Cameron via
2023-05-26 17:13 ` [PATCH v8 7/7] hw/cxl/events: Add injection of Memory Module Events Jonathan Cameron
2023-05-26 17:13 ` Jonathan Cameron via
2023-05-27 5:48 ` Markus Armbruster
2023-05-30 13:33 ` Jonathan Cameron [this message]
2023-05-30 13:33 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530143318.00005430@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave.jiang@intel.com \
--cc=eblake@redhat.com \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=mike.maslenkin@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.