Re: [RFC PATCH 1/1] fdt: Mark "/reserved-memory" nodes as nosave if !reusable

[kernel test robot <lkp@intel.com>]

Hi Alexandre,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.4-rc4 next-20230530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexandre-Ghiti/fdt-Mark-reserved-memory-nodes-as-nosave-if-reusable/20230530-160609
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20230530080425.18612-2-alexghiti%40rivosinc.com
patch subject: [RFC PATCH 1/1] fdt: Mark "/reserved-memory" nodes as nosave if !reusable
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20230530/202305301844.lzGXMUkw-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
        mkdir -p ~/bin
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e6e989bc8043fe16df80c07a2f61d759e148b6fb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Alexandre-Ghiti/fdt-Mark-reserved-memory-nodes-as-nosave-if-reusable/20230530-160609
        git checkout e6e989bc8043fe16df80c07a2f61d759e148b6fb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/of/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305301844.lzGXMUkw-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/of/fdt.c: In function '__reserved_mem_nosave_reg':
>> drivers/of/fdt.c:528:48: error: implicit declaration of function 'phys_to_pfn'; did you mean 'page_to_pfn'? [-Werror=implicit-function-declaration]
     528 |                         register_nosave_region(phys_to_pfn(base),
         |                                                ^~~~~~~~~~~
         |                                                page_to_pfn
   drivers/of/fdt.c: At top level:
   drivers/of/fdt.c:641:19: warning: 'fdt_nosave_reserved_mem' defined but not used [-Wunused-function]
     641 | static int __init fdt_nosave_reserved_mem(void)
         |                   ^~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +528 drivers/of/fdt.c

   497	
   498	/*
   499	 * __reserved_mem_nosave_reg() - Make all memory described in 'reg' property as
   500	 * nosave, unless it is "reusable".
   501	 */
   502	static void __init __reserved_mem_nosave_reg(unsigned long node,
   503						     const char *uname)
   504	{
   505		int t_len = (dt_root_addr_cells + dt_root_size_cells) * sizeof(__be32);
   506		phys_addr_t base, size;
   507		int len;
   508		const __be32 *prop;
   509		bool reusable;
   510	
   511		prop = of_get_flat_dt_prop(node, "reg", &len);
   512		if (!prop)
   513			return;
   514	
   515		if (len && len % t_len != 0) {
   516			pr_err("Reserved memory: invalid reg property in '%s', skipping node.\n",
   517			       uname);
   518			return;
   519		}
   520	
   521		reusable = of_get_flat_dt_prop(node, "reusable", NULL) != NULL;
   522	
   523		while (len >= t_len) {
   524			base = dt_mem_next_cell(dt_root_addr_cells, &prop);
   525			size = dt_mem_next_cell(dt_root_size_cells, &prop);
   526	
   527			if (size && !reusable)
 > 528				register_nosave_region(phys_to_pfn(base),
   529						       phys_to_pfn(base + size));
   530	
   531			len -= t_len;
   532		}
   533	}
   534	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki