From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Lukas Wunner <lukas@wunner.de>,
Andreas Noever <andreas.noever@gmail.com>,
beld zhang <beldzhang@gmail.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH] thunderbolt: Mask ring interrupt on Intel hardware as well
Date: Wed, 31 May 2023 10:41:31 +0300 [thread overview]
Message-ID: <20230531074131.GJ45886@black.fi.intel.com> (raw)
In-Reply-To: <20230530075555.35239-1-mika.westerberg@linux.intel.com>
On Tue, May 30, 2023 at 10:55:55AM +0300, Mika Westerberg wrote:
> When resuming from system sleep states the driver issues following
> warning on Intel hardware:
>
> thunderbolt 0000:07:00.0: interrupt for TX ring 0 is already enabled
>
> The reason for this is that the commit in question did not mask the ring
> interrupt on Intel hardware leaving the interrupt active. Fix this by
> masking it also in Intel hardware.
>
> Reported-by: beld zhang <beldzhang@gmail.com>
> Closes: https://lore.kernel.org/linux-usb/ZHKW5NeabmfhgLbY@debian.me/
> Fixes: c4af8e3fecd0 ("thunderbolt: Clear registers properly when auto clear isn't in use")
> Cc: stable@vger.kernel.org
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to thunderbolt.git/fixes.
prev parent reply other threads:[~2023-05-31 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 7:55 [PATCH] thunderbolt: Mask ring interrupt on Intel hardware as well Mika Westerberg
2023-05-31 7:41 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531074131.GJ45886@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=beldzhang@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.