From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, io-uring@vger.kernel.org,
linux-nvme@lists.infradead.org, hch@lst.de, axboe@kernel.dk,
sagi@grimberg.me, joshi.k@samsung.com,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/2] block: add request polling helper
Date: Wed, 31 May 2023 15:01:14 +0200 [thread overview]
Message-ID: <20230531130114.GC27468@lst.de> (raw)
In-Reply-To: <20230530172343.3250958-1-kbusch@meta.com>
> +int blk_mq_poll(struct request_queue *q, blk_qc_t cookie, struct io_comp_batch *iob,
It would be nice to fix the overly long line while you're at it.
> + unsigned int flags)
> +{
> + return blk_hctx_poll(q, blk_qc_to_hctx(q, cookie), iob, flags);
> +}
But looking at the two callers of blk_mq_poll, shouldn't one use
rq->mq_hctx to get the hctx anyway instead of doing repeated
blk_qc_to_hctx in the polling loop? We could then just open code
blk_qc_to_hctx in the remaining one.
The rest looks good to me.
next prev parent reply other threads:[~2023-05-31 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230530172405epcas5p317e15a619d6101c8875b920224f02e31@epcas5p3.samsung.com>
2023-05-30 17:23 ` [PATCH 1/2] block: add request polling helper Keith Busch
2023-05-30 17:23 ` [PATCH 2/2] nvme: improved uring polling Keith Busch
2023-05-31 10:10 ` Kanchan Joshi
2023-05-31 13:02 ` Christoph Hellwig
2023-06-05 23:04 ` Sagi Grimberg
2023-05-31 9:45 ` [PATCH 1/2] block: add request polling helper Kanchan Joshi
2023-05-31 13:01 ` Christoph Hellwig [this message]
2023-06-05 23:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531130114.GC27468@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.