From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org,
Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
emil.s.tantilov@intel.com, jesse.brandeburg@intel.com,
sridhar.samudrala@intel.com, shiraz.saleem@intel.com,
sindhu.devale@intel.com, willemb@google.com, decot@google.com,
andrew@lunn.ch, leon@kernel.org, mst@redhat.com,
simon.horman@corigine.com, shannon.nelson@amd.com,
stephen@networkplumber.org, Alan Brady <alan.brady@intel.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
Phani Burra <phani.r.burra@intel.com>,
Shailendra Bhatnagar <shailendra.bhatnagar@intel.com>,
Krishneil Singh <krishneil.k.singh@intel.com>
Subject: Re: [PATCH net-next 05/15] idpf: add create vport and netdev configuration
Date: Wed, 31 May 2023 23:22:39 -0700 [thread overview]
Message-ID: <20230531232239.5db93c09@kernel.org> (raw)
In-Reply-To: <20230530234501.2680230-6-anthony.l.nguyen@intel.com>
On Tue, 30 May 2023 16:44:51 -0700 Tony Nguyen wrote:
> @@ -137,8 +210,12 @@ static int idpf_set_msg_pending_bit(struct idpf_adapter *adapter,
> * previous message.
> */
> while (retries) {
> - if (!test_and_set_bit(IDPF_VC_MSG_PENDING, adapter->flags))
> + if ((vport && !test_and_set_bit(IDPF_VPORT_VC_MSG_PENDING,
> + vport->flags)) ||
> + (!vport && !test_and_set_bit(IDPF_VC_MSG_PENDING,
> + adapter->flags)))
> break;
> +
> msleep(20);
> retries--;
> }
Please use locks. Every single Intel driver comes with gazillion flags
and endless bugs when the flags go out of sync.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-01 6:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:44 [PATCH net-next 00/15][pull request] Introduce Intel IDPF driver Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 01/15] virtchnl: add virtchnl version 2 ops Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 02/15] idpf: add module register and probe functionality Tony Nguyen
2023-05-31 6:05 ` Michael S. Tsirkin
2023-05-31 18:34 ` Jesse Brandeburg
2023-05-31 20:25 ` Tony Nguyen
2023-06-11 17:54 ` Leon Romanovsky
2023-05-30 23:44 ` [PATCH net-next 03/15] idpf: add controlq init and reset checks Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 04/15] idpf: add core init and interrupt request Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 05/15] idpf: add create vport and netdev configuration Tony Nguyen
2023-06-01 6:22 ` Jakub Kicinski [this message]
2023-06-01 23:47 ` Linga, Pavan Kumar
2023-06-07 18:20 ` Willem de Bruijn
2023-06-07 19:10 ` Jakub Kicinski
2023-06-07 19:39 ` Willem de Bruijn
2023-05-30 23:44 ` [PATCH net-next 06/15] idpf: continue expanding init task Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 07/15] idpf: configure resources for TX queues Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 08/15] idpf: configure resources for RX queues Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 09/15] idpf: initialize interrupts and enable vport Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 10/15] idpf: add splitq start_xmit Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 11/15] idpf: add TX splitq napi poll support Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 12/15] idpf: add RX " Tony Nguyen
2023-05-30 23:44 ` [PATCH net-next 13/15] idpf: add singleq start_xmit and napi poll Tony Nguyen
2023-05-30 23:45 ` [PATCH net-next 14/15] idpf: add ethtool callbacks Tony Nguyen
2023-05-30 23:45 ` [PATCH net-next 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
2023-06-01 6:23 ` Jakub Kicinski
2023-06-01 23:40 ` Linga, Pavan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531232239.5db93c09@kernel.org \
--to=kuba@kernel.org \
--cc=alan.brady@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=krishneil.k.singh@intel.com \
--cc=leon@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=shailendra.bhatnagar@intel.com \
--cc=shannon.nelson@amd.com \
--cc=shiraz.saleem@intel.com \
--cc=simon.horman@corigine.com \
--cc=sindhu.devale@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.