From: Eric Wong <e@80x24.org>
To: Siddharth Singh <siddhartth@google.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] Unit tests for khash.h
Date: Wed, 31 May 2023 23:35:26 +0000 [thread overview]
Message-ID: <20230531233526.M226883@dcvr> (raw)
In-Reply-To: <20230531155142.3359886-1-siddhartth@google.com>
Siddharth Singh <siddhartth@google.com> wrote:
> This RFC patch adds unit tests for khash.h.
I agree with what Taylor said about being skeptical of these
tests being productive.
I'm curious about switching parts of git to use AC's newer `khashl'.
khashl is smaller than the original khash but slower for deletes.
Since git hardly deletes and khash memory use is high (especially on
packing); it should be a benefit all around.
Also, see Documentation/CodingGuidelines for coding style.
next prev parent reply other threads:[~2023-05-31 23:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 15:51 [RFC PATCH 0/1] Unit tests for khash.h Siddharth Singh
2023-05-31 15:51 ` [RFC PATCH 1/1] khash_test.c: add unit tests Siddharth Singh
2023-05-31 22:35 ` [RFC PATCH 0/1] Unit tests for khash.h Taylor Blau
2023-06-01 6:26 ` Junio C Hamano
2023-06-01 13:02 ` Phillip Wood
2023-05-31 23:35 ` Eric Wong [this message]
2023-06-01 13:23 ` Phillip Wood
2023-06-27 13:20 ` [RFC PATCH v2] khash_test.c : add unit tests Siddharth Singh
2023-06-30 0:53 ` Glen Choo
2023-07-07 15:04 ` Siddharth Singh
2023-07-07 21:12 ` Glen Choo
2023-06-30 1:05 ` Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531233526.M226883@dcvr \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=siddhartth@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.