From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23242C77B7A for ; Thu, 1 Jun 2023 08:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AwWrBJZMIS2kMnEDfbNch4F5rAhQnnmJrwNTuu5IGAw=; b=gDX5tmYdTnkmm2 jEkDHW/iUkNUlQAdWmmodttmOKFbELFFxAiMBOxJClPDJx54xM6wC6rY3qLqXlS/5ZXwqFQbgoGTd mHhACEUCRD9fi5vhDdLV0em6vNEN9FZirMm1qOWimFRU28tHBBUAba6LqltBMTC+AQNF4BnuJP/AT Yy+eiX/GQEMOrZKi1pnXdGCYOqwyqgqRCsadpPItJFhExP1viFmRWZiiEuSPNYWy/tAFvX8WK5SQi V3/xLEHhDEwo+SIIvfqkqHivO1/aWwahthlq1LDTQ52PYlXHCgfdx+2HJUge/O60xe9nmNZUSt6eq UazIkhp2Uhf8wyXN1leA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4dlA-002ZxD-1g; Thu, 01 Jun 2023 08:34:16 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4dl6-002Zw2-27; Thu, 01 Jun 2023 08:34:14 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685608450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=663IAskSouGvSvR75PHPprqPibZidxQMt5gFnwQhwKw=; b=N9LC6jiIgSsRnMoqd4fOu94yzBOqz5ZALVcfI3eIolqZxTZyzsAg+yxpRCz6ELtRAiUYyd 2h6byanGwpXngLqwp3gUhuHEfSyj/SCVJVT+I/d5FWTnC7LzH3dTcUM64dmXYVpeWndXWh mqOpXCTwAyJmoS7ROmQUVES/ShT7mwcZT5rmgSUDM5mi8X44jotikO6TXQiQn5PB6gWjKu ErHfcirIYe6jeMSa2E2dPwz5wM1/fGZBjLEPRtSHccM+72dHg2g6CkGN1A9TCfhTeilir+ 82nF6inbzu008F/EWwZvmxFHvUy++vpVi2EPyEsrzqJckmGMbifrX4icsAWlLg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id EA7B3C000E; Thu, 1 Jun 2023 08:34:07 +0000 (UTC) Date: Thu, 1 Jun 2023 10:34:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , Subject: Re: [RFC PATCH v5 4/6] mtd: rawnand: meson: use macro for OOB area Message-ID: <20230601103405.51cb459a@xps-13> In-Reply-To: <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> References: <20230601061850.3907800-1-AVKrasnov@sberdevices.ru> <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_013412_998874_06A534C0 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUaHUsIDEgSnVu IDIwMjMgMDk6MTg6NDcgKzAzMDA6Cgo+IFRoaXMgcmVwbGFjZXMgY29uc3RhbnRzIGFuZCBzYW1l IHBhdHRlcm5zIGZvciBPT0IgaGFuZGxpbmcgd2l0aCBzcGVjaWFsCj4gbWFjcm9zZXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogQXJzZW5peSBLcmFzbm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+ Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyB8IDMzICsrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMo KyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jh dy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiBpbmRl eCBlNDJjMjhiZTAyZjMuLjIzYTczMjY4NDIxYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9u YW5kLmMKPiBAQCAtMTA4LDYgKzEwOCw5IEBACj4gIAo+ICAjZGVmaW5lIFBFUl9JTkZPX0JZVEUJ CTgKPiAgCj4gKyNkZWZpbmUgTkZDX1VTRVJfQllURVMJCTIKPiArI2RlZmluZSBORkNfT09CX1BF Ul9FQ0MobmFuZCkJKChuYW5kKS0+ZWNjLmJ5dGVzICsgTkZDX1VTRVJfQllURVMpCgpPT0IgcGVy IEVDQyBmb3IgbWUgZG9lcyBub3QgbWFrZSBzZW5zZS4KT09CIGlzIHRoZSB3aG9sZSBhcmVhIGFm dGVyIHRoZSBkYXRhLgpXaGF0IGFib3V0IE5GQ19PT0JfU1pfUEVSX0VDQ19TVEVQID8KCj4gKwo+ ICBzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCB7Cj4gIAlzdHJ1Y3QgbGlzdF9oZWFkIG5vZGU7 Cj4gIAlzdHJ1Y3QgbmFuZF9jaGlwIG5hbmQ7Cj4gQEAgLTMzOSw3ICszNDIsNyBAQCBzdGF0aWMg dTggKm1lc29uX25mY19vb2JfcHRyKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIGludCBpKQo+ICAJ c3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgKm1lc29uX2NoaXAgPSB0b19tZXNvbl9uYW5kKG5h bmQpOwo+ICAJaW50IGxlbjsKPiAgCj4gLQlsZW4gPSBuYW5kLT5lY2Muc2l6ZSAqIChpICsgMSkg KyAobmFuZC0+ZWNjLmJ5dGVzICsgMikgKiBpOwo+ICsJbGVuID0gbmFuZC0+ZWNjLnNpemUgKiAo aSArIDEpICsgTkZDX09PQl9QRVJfRUNDKG5hbmQpICogaTsKPiAgCj4gIAlyZXR1cm4gbWVzb25f Y2hpcC0+ZGF0YV9idWYgKyBsZW47Cj4gIH0KPiBAQCAtMzUwLDcgKzM1Myw3IEBAIHN0YXRpYyB1 OCAqbWVzb25fbmZjX2RhdGFfcHRyKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIGludCBpKQo+ICAJ aW50IGxlbiwgdGVtcDsKPiAgCj4gIAl0ZW1wID0gbmFuZC0+ZWNjLnNpemUgKyBuYW5kLT5lY2Mu Ynl0ZXM7Cj4gLQlsZW4gPSAodGVtcCArIDIpICogaTsKPiArCWxlbiA9ICh0ZW1wICsgTkZDX1VT RVJfQllURVMpICogaTsKPiAgCj4gIAlyZXR1cm4gbWVzb25fY2hpcC0+ZGF0YV9idWYgKyBsZW47 Cj4gIH0KPiBAQCAtMzY0LDcgKzM2Nyw3IEBAIHN0YXRpYyB2b2lkIG1lc29uX25mY19nZXRfZGF0 YV9vb2Ioc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCXU4ICpkc3JjLCAqb3NyYzsKPiAgCXU4 ICpvb2J0YWlsOwo+ICAKPiAtCW9vYl9sZW4gPSBuYW5kLT5lY2MuYnl0ZXMgKyAyOwo+ICsJb29i X2xlbiA9IE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgCWZvciAoaSA9IDA7IGkgPCBuYW5kLT5l Y2Muc3RlcHM7IGkrKykgewo+ICAJCWlmIChidWYpIHsKPiAgCQkJZHNyYyA9IG1lc29uX25mY19k YXRhX3B0cihuYW5kLCBpKTsKPiBAQCAtMzkzLDcgKzM5Niw3IEBAIHN0YXRpYyB2b2lkIG1lc29u X25mY19zZXRfZGF0YV9vb2Ioc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCXU4ICpkc3JjLCAq b3NyYzsKPiAgCXU4ICpvb2J0YWlsOwo+ICAKPiAtCW9vYl9sZW4gPSBuYW5kLT5lY2MuYnl0ZXMg KyAyOwo+ICsJb29iX2xlbiA9IE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgCWZvciAoaSA9IDA7 IGkgPCBuYW5kLT5lY2Muc3RlcHM7IGkrKykgewo+ICAJCWlmIChidWYpIHsKPiAgCQkJZHNyYyA9 IG1lc29uX25mY19kYXRhX3B0cihuYW5kLCBpKTsKPiBAQCAtNDUyLDcgKzQ1NSw3IEBAIHN0YXRp YyB2b2lkIG1lc29uX25mY19zZXRfdXNlcl9ieXRlKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4 ICpvb2JfYnVmKQo+ICAJX19sZTY0ICppbmZvOwo+ICAJaW50IGksIGNvdW50Owo+ICAKPiAtCWZv ciAoaSA9IDAsIGNvdW50ID0gMDsgaSA8IG5hbmQtPmVjYy5zdGVwczsgaSsrLCBjb3VudCArPSAo bmFuZC0+ZWNjLmJ5dGVzICsgMikpIHsKPiArCWZvciAoaSA9IDAsIGNvdW50ID0gMDsgaSA8IG5h bmQtPmVjYy5zdGVwczsgaSsrLCBjb3VudCArPSBORkNfT09CX1BFUl9FQ0MobmFuZCkpIHsKPiAg CQlpbmZvID0gJm1lc29uX2NoaXAtPmluZm9fYnVmW2ldOwo+ICAJCSppbmZvIHw9IG9vYl9idWZb Y291bnRdOwo+ICAJCSppbmZvIHw9IG9vYl9idWZbY291bnQgKyAxXSA8PCA4Owo+IEBAIC00NjUs NyArNDY4LDcgQEAgc3RhdGljIHZvaWQgbWVzb25fbmZjX2dldF91c2VyX2J5dGUoc3RydWN0IG5h bmRfY2hpcCAqbmFuZCwgdTggKm9vYl9idWYpCj4gIAlfX2xlNjQgKmluZm87Cj4gIAlpbnQgaSwg Y291bnQ7Cj4gIAo+IC0JZm9yIChpID0gMCwgY291bnQgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBz OyBpKyssIGNvdW50ICs9IChuYW5kLT5lY2MuYnl0ZXMgKyAyKSkgewo+ICsJZm9yIChpID0gMCwg Y291bnQgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBzOyBpKyssIGNvdW50ICs9IE5GQ19PT0JfUEVS X0VDQyhuYW5kKSkgewo+ICAJCWluZm8gPSAmbWVzb25fY2hpcC0+aW5mb19idWZbaV07Cj4gIAkJ b29iX2J1Zltjb3VudF0gPSAqaW5mbzsKPiAgCQlvb2JfYnVmW2NvdW50ICsgMV0gPSAqaW5mbyA+ PiA4Owo+IEBAIC02NjEsNyArNjY0LDcgQEAgc3RhdGljIHUzMiBtZXNvbl9uZmNfb29iX2ZyZWVf Ynl0ZXMoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCkKPiAgewo+ICAJc3RydWN0IG10ZF9pbmZvICpt dGQgPSBuYW5kX3RvX210ZChuYW5kKTsKPiAgCj4gLQlyZXR1cm4gbXRkLT5vb2JzaXplIC0gbmFu ZC0+ZWNjLnN0ZXBzICogKG5hbmQtPmVjYy5ieXRlcyArIDIpOwo+ICsJcmV0dXJuIG10ZC0+b29i c2l6ZSAtIG5hbmQtPmVjYy5zdGVwcyAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBtZXNvbl9uZmNfd3JpdGVfb29iKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQs IGludCBwYWdlKQo+IEBAIC03MTIsMTEgKzcxNSwxMSBAQCBzdGF0aWMgaW50IG1lc29uX25mY19y ZWFkX29vYihzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCBpbnQgcGFnZSkKPiAgCS8qIFJlYWQgRUND IGNvZGVzIGFuZCB1c2VyIGJ5dGVzLiAqLwo+ICAJZm9yIChpID0gMDsgaSA8IG5hbmQtPmVjYy5z dGVwczsgaSsrKSB7Cj4gIAkJdTMyIGVjY19vZmZzID0gbmFuZC0+ZWNjLnNpemUgKiAoaSArIDEp ICsKPiAtCQkJICAgICAgIChuYW5kLT5lY2MuYnl0ZXMgKyAyKSAqIGk7Cj4gKwkJCSAgICAgICBO RkNfT09CX1BFUl9FQ0MobmFuZCkgKiBpOwo+ICAKPiAgCQlyZXQgPSBuYW5kX2NoYW5nZV9yZWFk X2NvbHVtbl9vcChuYW5kLCBlY2Nfb2ZmcywKPiAtCQkJCQkJIG9vYl9idWYgKyBpICogKG5hbmQt PmVjYy5ieXRlcyArIDIpLAo+IC0JCQkJCQkgKG5hbmQtPmVjYy5ieXRlcyArIDIpLCBmYWxzZSk7 Cj4gKwkJCQkJCSBvb2JfYnVmICsgaSAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwKPiArCQkJCQkJ IE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwgZmFsc2UpOwo+ICAJCWlmIChyZXQpCj4gIAkJCXJldHVy biByZXQ7Cj4gIAl9Cj4gQEAgLTkxOCwxMiArOTIxLDE0IEBAIHN0YXRpYyBpbnQgbWVzb25fbmZj X3JlYWRfcGFnZV9od2VjYyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAqYnVmLAo+ICAKPiAg CQlmb3IgKGkgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBzIDsgaSsrKSB7Cj4gIAkJCXU4ICpkYXRh ID0gYnVmICsgaSAqIGVjYy0+c2l6ZTsKPiAtCQkJdTggKm9vYiA9IG5hbmQtPm9vYl9wb2kgKyBp ICogKGVjYy0+Ynl0ZXMgKyAyKTsKPiArCQkJdTggKm9vYiA9IG5hbmQtPm9vYl9wb2kgKyBpICog TkZDX09PQl9QRVJfRUNDKG5hbmQpOwo+ICAKPiAgCQkJaWYgKGNvcnJlY3RfYml0bWFwICYgQklU X1VMTChpKSkKPiAgCQkJCWNvbnRpbnVlOwo+ICsKPiAgCQkJcmV0ID0gbmFuZF9jaGVja19lcmFz ZWRfZWNjX2NodW5rKGRhdGEsCWVjYy0+c2l6ZSwKPiAtCQkJCQkJCSAgb29iLCBlY2MtPmJ5dGVz ICsgMiwKPiArCQkJCQkJCSAgb29iLAo+ICsJCQkJCQkJICBORkNfT09CX1BFUl9FQ0MobmFuZCks Cj4gIAkJCQkJCQkgIE5VTEwsIDAsCj4gIAkJCQkJCQkgIGVjYy0+c3RyZW5ndGgpOwo+ICAJCQlp ZiAocmV0IDwgMCkgewo+IEBAIC0xMDczLDcgKzEwNzgsNyBAQCBzdGF0aWMgaW50IG1lc29uX29v YmxheW91dF9lY2Moc3RydWN0IG10ZF9pbmZvICptdGQsIGludCBzZWN0aW9uLAo+ICAJaWYgKHNl Y3Rpb24gPj0gbmFuZC0+ZWNjLnN0ZXBzKQo+ICAJCXJldHVybiAtRVJBTkdFOwo+ICAKPiAtCW9v YnJlZ2lvbi0+b2Zmc2V0ID0gIDIgKyAoc2VjdGlvbiAqICgyICsgbmFuZC0+ZWNjLmJ5dGVzKSk7 Cj4gKwlvb2JyZWdpb24tPm9mZnNldCA9IE5GQ19VU0VSX0JZVEVTICsgKHNlY3Rpb24gKiBORkNf T09CX1BFUl9FQ0MobmFuZCkpOwoKTm8sIHRoZSBmaXJzdCAiMiIgaGVyZSBpcyBmb3IgYmFkIGJs b2NrIG1hcmtlcnMsIGl0IGlzIG5vdCByZWxhdGVkIHRvCnlvdXIgRUNDIGVuZ2luZSBsYXlvdXQg SSBiZWxpZXZlLgoKPiAgCW9vYnJlZ2lvbi0+bGVuZ3RoID0gbmFuZC0+ZWNjLmJ5dGVzOwo+ICAK PiAgCXJldHVybiAwOwo+IEBAIC0xMDkxLDcgKzEwOTYsNyBAQCBzdGF0aWMgaW50IG1lc29uX29v YmxheW91dF9mcmVlKHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBpbnQgc2VjdGlvbiwKPiAgCS8qIFNw bGl0IHJlc3Qgb2YgT09CIGFyZWEgKG5vdCBjb3ZlcmVkIGJ5IEVDQyBlbmdpbmUpIHBlciBlYWNo Cj4gIAkgKiBFQ0Mgc2VjdGlvbi4gVGhpcyB3aWxsIGJlIE9PQiBkYXRhIGF2YWlsYWJsZSB0byB1 c2VyLgo+ICAJICovCj4gLQlvb2JyZWdpb24tPm9mZnNldCA9IChzZWN0aW9uICsgbmFuZC0+ZWNj LnN0ZXBzKSAqICgyICsgbmFuZC0+ZWNjLmJ5dGVzKTsKPiArCW9vYnJlZ2lvbi0+b2Zmc2V0ID0g KHNlY3Rpb24gKyBuYW5kLT5lY2Muc3RlcHMpICogTkZDX09PQl9QRVJfRUNDKG5hbmQpOwo+ICAJ b29icmVnaW9uLT5sZW5ndGggPSBvb2JfYnl0ZXMgLyBuYW5kLT5lY2Muc3RlcHM7Cj4gIAo+ICAJ cmV0dXJuIDA7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxv Z2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06781C77B7E for ; Thu, 1 Jun 2023 08:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r0A0bjs0gu7tjbukIRVcai5/y/30/gUbItETuOxyzk4=; b=Lzr8QS6ZsUtOAe WeJrv1+6yy2eDJtaeBMDznEtPaf4PNDA6t+42QxWszIYdAQCXQybrl0dDBtO78Cxt2aYu3DRNzbry TjhwOVI56kMpCNZCZ52jOfesxaN3ztOQOAkHGj8lbtMMZgKjLx9mNjxwkGqBcXb1O5Li9S13REfMx sFFIovkeZpZM9q5lwP9oH/zzKbk5wnGosgZVayj6neuwKnUrho4AmQ5dMNRnpflrMn5t1xCRCgFHw FVHMbBkjtHPPj8S3MhsC+RAIh4eU92T8VD5UbeYU9PvZC+XFRq7U+VEkT8a/Khsj4HaE3qYYEGFPu pLH3E9nUB9aTvSFadtuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4dlB-002Zxb-1W; Thu, 01 Jun 2023 08:34:17 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4dl6-002Zw2-27; Thu, 01 Jun 2023 08:34:14 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685608450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=663IAskSouGvSvR75PHPprqPibZidxQMt5gFnwQhwKw=; b=N9LC6jiIgSsRnMoqd4fOu94yzBOqz5ZALVcfI3eIolqZxTZyzsAg+yxpRCz6ELtRAiUYyd 2h6byanGwpXngLqwp3gUhuHEfSyj/SCVJVT+I/d5FWTnC7LzH3dTcUM64dmXYVpeWndXWh mqOpXCTwAyJmoS7ROmQUVES/ShT7mwcZT5rmgSUDM5mi8X44jotikO6TXQiQn5PB6gWjKu ErHfcirIYe6jeMSa2E2dPwz5wM1/fGZBjLEPRtSHccM+72dHg2g6CkGN1A9TCfhTeilir+ 82nF6inbzu008F/EWwZvmxFHvUy++vpVi2EPyEsrzqJckmGMbifrX4icsAWlLg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id EA7B3C000E; Thu, 1 Jun 2023 08:34:07 +0000 (UTC) Date: Thu, 1 Jun 2023 10:34:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , Subject: Re: [RFC PATCH v5 4/6] mtd: rawnand: meson: use macro for OOB area Message-ID: <20230601103405.51cb459a@xps-13> In-Reply-To: <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> References: <20230601061850.3907800-1-AVKrasnov@sberdevices.ru> <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_013412_998874_06A534C0 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUaHUsIDEgSnVu IDIwMjMgMDk6MTg6NDcgKzAzMDA6Cgo+IFRoaXMgcmVwbGFjZXMgY29uc3RhbnRzIGFuZCBzYW1l IHBhdHRlcm5zIGZvciBPT0IgaGFuZGxpbmcgd2l0aCBzcGVjaWFsCj4gbWFjcm9zZXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogQXJzZW5peSBLcmFzbm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+ Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyB8IDMzICsrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMo KyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jh dy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiBpbmRl eCBlNDJjMjhiZTAyZjMuLjIzYTczMjY4NDIxYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9u YW5kLmMKPiBAQCAtMTA4LDYgKzEwOCw5IEBACj4gIAo+ICAjZGVmaW5lIFBFUl9JTkZPX0JZVEUJ CTgKPiAgCj4gKyNkZWZpbmUgTkZDX1VTRVJfQllURVMJCTIKPiArI2RlZmluZSBORkNfT09CX1BF Ul9FQ0MobmFuZCkJKChuYW5kKS0+ZWNjLmJ5dGVzICsgTkZDX1VTRVJfQllURVMpCgpPT0IgcGVy IEVDQyBmb3IgbWUgZG9lcyBub3QgbWFrZSBzZW5zZS4KT09CIGlzIHRoZSB3aG9sZSBhcmVhIGFm dGVyIHRoZSBkYXRhLgpXaGF0IGFib3V0IE5GQ19PT0JfU1pfUEVSX0VDQ19TVEVQID8KCj4gKwo+ ICBzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCB7Cj4gIAlzdHJ1Y3QgbGlzdF9oZWFkIG5vZGU7 Cj4gIAlzdHJ1Y3QgbmFuZF9jaGlwIG5hbmQ7Cj4gQEAgLTMzOSw3ICszNDIsNyBAQCBzdGF0aWMg dTggKm1lc29uX25mY19vb2JfcHRyKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIGludCBpKQo+ICAJ c3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgKm1lc29uX2NoaXAgPSB0b19tZXNvbl9uYW5kKG5h bmQpOwo+ICAJaW50IGxlbjsKPiAgCj4gLQlsZW4gPSBuYW5kLT5lY2Muc2l6ZSAqIChpICsgMSkg KyAobmFuZC0+ZWNjLmJ5dGVzICsgMikgKiBpOwo+ICsJbGVuID0gbmFuZC0+ZWNjLnNpemUgKiAo aSArIDEpICsgTkZDX09PQl9QRVJfRUNDKG5hbmQpICogaTsKPiAgCj4gIAlyZXR1cm4gbWVzb25f Y2hpcC0+ZGF0YV9idWYgKyBsZW47Cj4gIH0KPiBAQCAtMzUwLDcgKzM1Myw3IEBAIHN0YXRpYyB1 OCAqbWVzb25fbmZjX2RhdGFfcHRyKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIGludCBpKQo+ICAJ aW50IGxlbiwgdGVtcDsKPiAgCj4gIAl0ZW1wID0gbmFuZC0+ZWNjLnNpemUgKyBuYW5kLT5lY2Mu Ynl0ZXM7Cj4gLQlsZW4gPSAodGVtcCArIDIpICogaTsKPiArCWxlbiA9ICh0ZW1wICsgTkZDX1VT RVJfQllURVMpICogaTsKPiAgCj4gIAlyZXR1cm4gbWVzb25fY2hpcC0+ZGF0YV9idWYgKyBsZW47 Cj4gIH0KPiBAQCAtMzY0LDcgKzM2Nyw3IEBAIHN0YXRpYyB2b2lkIG1lc29uX25mY19nZXRfZGF0 YV9vb2Ioc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCXU4ICpkc3JjLCAqb3NyYzsKPiAgCXU4 ICpvb2J0YWlsOwo+ICAKPiAtCW9vYl9sZW4gPSBuYW5kLT5lY2MuYnl0ZXMgKyAyOwo+ICsJb29i X2xlbiA9IE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgCWZvciAoaSA9IDA7IGkgPCBuYW5kLT5l Y2Muc3RlcHM7IGkrKykgewo+ICAJCWlmIChidWYpIHsKPiAgCQkJZHNyYyA9IG1lc29uX25mY19k YXRhX3B0cihuYW5kLCBpKTsKPiBAQCAtMzkzLDcgKzM5Niw3IEBAIHN0YXRpYyB2b2lkIG1lc29u X25mY19zZXRfZGF0YV9vb2Ioc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCXU4ICpkc3JjLCAq b3NyYzsKPiAgCXU4ICpvb2J0YWlsOwo+ICAKPiAtCW9vYl9sZW4gPSBuYW5kLT5lY2MuYnl0ZXMg KyAyOwo+ICsJb29iX2xlbiA9IE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgCWZvciAoaSA9IDA7 IGkgPCBuYW5kLT5lY2Muc3RlcHM7IGkrKykgewo+ICAJCWlmIChidWYpIHsKPiAgCQkJZHNyYyA9 IG1lc29uX25mY19kYXRhX3B0cihuYW5kLCBpKTsKPiBAQCAtNDUyLDcgKzQ1NSw3IEBAIHN0YXRp YyB2b2lkIG1lc29uX25mY19zZXRfdXNlcl9ieXRlKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4 ICpvb2JfYnVmKQo+ICAJX19sZTY0ICppbmZvOwo+ICAJaW50IGksIGNvdW50Owo+ICAKPiAtCWZv ciAoaSA9IDAsIGNvdW50ID0gMDsgaSA8IG5hbmQtPmVjYy5zdGVwczsgaSsrLCBjb3VudCArPSAo bmFuZC0+ZWNjLmJ5dGVzICsgMikpIHsKPiArCWZvciAoaSA9IDAsIGNvdW50ID0gMDsgaSA8IG5h bmQtPmVjYy5zdGVwczsgaSsrLCBjb3VudCArPSBORkNfT09CX1BFUl9FQ0MobmFuZCkpIHsKPiAg CQlpbmZvID0gJm1lc29uX2NoaXAtPmluZm9fYnVmW2ldOwo+ICAJCSppbmZvIHw9IG9vYl9idWZb Y291bnRdOwo+ICAJCSppbmZvIHw9IG9vYl9idWZbY291bnQgKyAxXSA8PCA4Owo+IEBAIC00NjUs NyArNDY4LDcgQEAgc3RhdGljIHZvaWQgbWVzb25fbmZjX2dldF91c2VyX2J5dGUoc3RydWN0IG5h bmRfY2hpcCAqbmFuZCwgdTggKm9vYl9idWYpCj4gIAlfX2xlNjQgKmluZm87Cj4gIAlpbnQgaSwg Y291bnQ7Cj4gIAo+IC0JZm9yIChpID0gMCwgY291bnQgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBz OyBpKyssIGNvdW50ICs9IChuYW5kLT5lY2MuYnl0ZXMgKyAyKSkgewo+ICsJZm9yIChpID0gMCwg Y291bnQgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBzOyBpKyssIGNvdW50ICs9IE5GQ19PT0JfUEVS X0VDQyhuYW5kKSkgewo+ICAJCWluZm8gPSAmbWVzb25fY2hpcC0+aW5mb19idWZbaV07Cj4gIAkJ b29iX2J1Zltjb3VudF0gPSAqaW5mbzsKPiAgCQlvb2JfYnVmW2NvdW50ICsgMV0gPSAqaW5mbyA+ PiA4Owo+IEBAIC02NjEsNyArNjY0LDcgQEAgc3RhdGljIHUzMiBtZXNvbl9uZmNfb29iX2ZyZWVf Ynl0ZXMoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCkKPiAgewo+ICAJc3RydWN0IG10ZF9pbmZvICpt dGQgPSBuYW5kX3RvX210ZChuYW5kKTsKPiAgCj4gLQlyZXR1cm4gbXRkLT5vb2JzaXplIC0gbmFu ZC0+ZWNjLnN0ZXBzICogKG5hbmQtPmVjYy5ieXRlcyArIDIpOwo+ICsJcmV0dXJuIG10ZC0+b29i c2l6ZSAtIG5hbmQtPmVjYy5zdGVwcyAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBtZXNvbl9uZmNfd3JpdGVfb29iKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQs IGludCBwYWdlKQo+IEBAIC03MTIsMTEgKzcxNSwxMSBAQCBzdGF0aWMgaW50IG1lc29uX25mY19y ZWFkX29vYihzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCBpbnQgcGFnZSkKPiAgCS8qIFJlYWQgRUND IGNvZGVzIGFuZCB1c2VyIGJ5dGVzLiAqLwo+ICAJZm9yIChpID0gMDsgaSA8IG5hbmQtPmVjYy5z dGVwczsgaSsrKSB7Cj4gIAkJdTMyIGVjY19vZmZzID0gbmFuZC0+ZWNjLnNpemUgKiAoaSArIDEp ICsKPiAtCQkJICAgICAgIChuYW5kLT5lY2MuYnl0ZXMgKyAyKSAqIGk7Cj4gKwkJCSAgICAgICBO RkNfT09CX1BFUl9FQ0MobmFuZCkgKiBpOwo+ICAKPiAgCQlyZXQgPSBuYW5kX2NoYW5nZV9yZWFk X2NvbHVtbl9vcChuYW5kLCBlY2Nfb2ZmcywKPiAtCQkJCQkJIG9vYl9idWYgKyBpICogKG5hbmQt PmVjYy5ieXRlcyArIDIpLAo+IC0JCQkJCQkgKG5hbmQtPmVjYy5ieXRlcyArIDIpLCBmYWxzZSk7 Cj4gKwkJCQkJCSBvb2JfYnVmICsgaSAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwKPiArCQkJCQkJ IE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwgZmFsc2UpOwo+ICAJCWlmIChyZXQpCj4gIAkJCXJldHVy biByZXQ7Cj4gIAl9Cj4gQEAgLTkxOCwxMiArOTIxLDE0IEBAIHN0YXRpYyBpbnQgbWVzb25fbmZj X3JlYWRfcGFnZV9od2VjYyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAqYnVmLAo+ICAKPiAg CQlmb3IgKGkgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBzIDsgaSsrKSB7Cj4gIAkJCXU4ICpkYXRh ID0gYnVmICsgaSAqIGVjYy0+c2l6ZTsKPiAtCQkJdTggKm9vYiA9IG5hbmQtPm9vYl9wb2kgKyBp ICogKGVjYy0+Ynl0ZXMgKyAyKTsKPiArCQkJdTggKm9vYiA9IG5hbmQtPm9vYl9wb2kgKyBpICog TkZDX09PQl9QRVJfRUNDKG5hbmQpOwo+ICAKPiAgCQkJaWYgKGNvcnJlY3RfYml0bWFwICYgQklU X1VMTChpKSkKPiAgCQkJCWNvbnRpbnVlOwo+ICsKPiAgCQkJcmV0ID0gbmFuZF9jaGVja19lcmFz ZWRfZWNjX2NodW5rKGRhdGEsCWVjYy0+c2l6ZSwKPiAtCQkJCQkJCSAgb29iLCBlY2MtPmJ5dGVz ICsgMiwKPiArCQkJCQkJCSAgb29iLAo+ICsJCQkJCQkJICBORkNfT09CX1BFUl9FQ0MobmFuZCks Cj4gIAkJCQkJCQkgIE5VTEwsIDAsCj4gIAkJCQkJCQkgIGVjYy0+c3RyZW5ndGgpOwo+ICAJCQlp ZiAocmV0IDwgMCkgewo+IEBAIC0xMDczLDcgKzEwNzgsNyBAQCBzdGF0aWMgaW50IG1lc29uX29v YmxheW91dF9lY2Moc3RydWN0IG10ZF9pbmZvICptdGQsIGludCBzZWN0aW9uLAo+ICAJaWYgKHNl Y3Rpb24gPj0gbmFuZC0+ZWNjLnN0ZXBzKQo+ICAJCXJldHVybiAtRVJBTkdFOwo+ICAKPiAtCW9v YnJlZ2lvbi0+b2Zmc2V0ID0gIDIgKyAoc2VjdGlvbiAqICgyICsgbmFuZC0+ZWNjLmJ5dGVzKSk7 Cj4gKwlvb2JyZWdpb24tPm9mZnNldCA9IE5GQ19VU0VSX0JZVEVTICsgKHNlY3Rpb24gKiBORkNf T09CX1BFUl9FQ0MobmFuZCkpOwoKTm8sIHRoZSBmaXJzdCAiMiIgaGVyZSBpcyBmb3IgYmFkIGJs b2NrIG1hcmtlcnMsIGl0IGlzIG5vdCByZWxhdGVkIHRvCnlvdXIgRUNDIGVuZ2luZSBsYXlvdXQg SSBiZWxpZXZlLgoKPiAgCW9vYnJlZ2lvbi0+bGVuZ3RoID0gbmFuZC0+ZWNjLmJ5dGVzOwo+ICAK PiAgCXJldHVybiAwOwo+IEBAIC0xMDkxLDcgKzEwOTYsNyBAQCBzdGF0aWMgaW50IG1lc29uX29v YmxheW91dF9mcmVlKHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBpbnQgc2VjdGlvbiwKPiAgCS8qIFNw bGl0IHJlc3Qgb2YgT09CIGFyZWEgKG5vdCBjb3ZlcmVkIGJ5IEVDQyBlbmdpbmUpIHBlciBlYWNo Cj4gIAkgKiBFQ0Mgc2VjdGlvbi4gVGhpcyB3aWxsIGJlIE9PQiBkYXRhIGF2YWlsYWJsZSB0byB1 c2VyLgo+ICAJICovCj4gLQlvb2JyZWdpb24tPm9mZnNldCA9IChzZWN0aW9uICsgbmFuZC0+ZWNj LnN0ZXBzKSAqICgyICsgbmFuZC0+ZWNjLmJ5dGVzKTsKPiArCW9vYnJlZ2lvbi0+b2Zmc2V0ID0g KHNlY3Rpb24gKyBuYW5kLT5lY2Muc3RlcHMpICogTkZDX09PQl9QRVJfRUNDKG5hbmQpOwo+ICAJ b29icmVnaW9uLT5sZW5ndGggPSBvb2JfYnl0ZXMgLyBuYW5kLT5lY2Muc3RlcHM7Cj4gIAo+ICAJ cmV0dXJuIDA7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBs aXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRk Lwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F31E6C77B7E for ; Thu, 1 Jun 2023 08:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wmcc519Krpk/Eu/S+sP96aMtPZVR8lOQ71ltSEqpCPk=; b=IE0BCj0PVwxtG8 TucYSdnIGtcY4H+0+4xrv/Jw7PwfgG6iFcusWYMj1KL+IiYKfGaqPlg8uGKxftpBhLAwyHyw6AJDk eVbkFfqDzn6kOPYkATy7aaiqgnLs7MidvLhwpV6Lt7ZU41LxLkJ9bJBGch44sc7GxNZUp+ylI/+5R YdbdgJovT1MFmIAxrkqhARxfhXHFZkJLemH5Qs0eXk0ynUldWyG2IqDzm1ASKPIOtVXz2XmrdXlDF BbV+3bYjwVixWnwjNCGlZw3MRITrFmMa9rITc2kicI7w8Oa3l7LxDupdSXLIWNm9R8RnB4AV5tZ3T mntMv07h6V9daTf6LTlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4dlA-002ZxP-2y; Thu, 01 Jun 2023 08:34:16 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4dl6-002Zw2-27; Thu, 01 Jun 2023 08:34:14 +0000 X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685608450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=663IAskSouGvSvR75PHPprqPibZidxQMt5gFnwQhwKw=; b=N9LC6jiIgSsRnMoqd4fOu94yzBOqz5ZALVcfI3eIolqZxTZyzsAg+yxpRCz6ELtRAiUYyd 2h6byanGwpXngLqwp3gUhuHEfSyj/SCVJVT+I/d5FWTnC7LzH3dTcUM64dmXYVpeWndXWh mqOpXCTwAyJmoS7ROmQUVES/ShT7mwcZT5rmgSUDM5mi8X44jotikO6TXQiQn5PB6gWjKu ErHfcirIYe6jeMSa2E2dPwz5wM1/fGZBjLEPRtSHccM+72dHg2g6CkGN1A9TCfhTeilir+ 82nF6inbzu008F/EWwZvmxFHvUy++vpVi2EPyEsrzqJckmGMbifrX4icsAWlLg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id EA7B3C000E; Thu, 1 Jun 2023 08:34:07 +0000 (UTC) Date: Thu, 1 Jun 2023 10:34:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , Subject: Re: [RFC PATCH v5 4/6] mtd: rawnand: meson: use macro for OOB area Message-ID: <20230601103405.51cb459a@xps-13> In-Reply-To: <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> References: <20230601061850.3907800-1-AVKrasnov@sberdevices.ru> <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230601_013412_998874_06A534C0 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCkFWS3Jhc25vdkBzYmVyZGV2aWNlcy5ydSB3cm90ZSBvbiBUaHUsIDEgSnVu IDIwMjMgMDk6MTg6NDcgKzAzMDA6Cgo+IFRoaXMgcmVwbGFjZXMgY29uc3RhbnRzIGFuZCBzYW1l IHBhdHRlcm5zIGZvciBPT0IgaGFuZGxpbmcgd2l0aCBzcGVjaWFsCj4gbWFjcm9zZXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogQXJzZW5peSBLcmFzbm92IDxBVktyYXNub3ZAc2JlcmRldmljZXMucnU+ Cj4gLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYyB8IDMzICsrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE5IGluc2VydGlvbnMo KyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5kL3Jh dy9tZXNvbl9uYW5kLmMgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiBpbmRl eCBlNDJjMjhiZTAyZjMuLjIzYTczMjY4NDIxYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL210ZC9u YW5kL3Jhdy9tZXNvbl9uYW5kLmMKPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9tZXNvbl9u YW5kLmMKPiBAQCAtMTA4LDYgKzEwOCw5IEBACj4gIAo+ICAjZGVmaW5lIFBFUl9JTkZPX0JZVEUJ CTgKPiAgCj4gKyNkZWZpbmUgTkZDX1VTRVJfQllURVMJCTIKPiArI2RlZmluZSBORkNfT09CX1BF Ul9FQ0MobmFuZCkJKChuYW5kKS0+ZWNjLmJ5dGVzICsgTkZDX1VTRVJfQllURVMpCgpPT0IgcGVy IEVDQyBmb3IgbWUgZG9lcyBub3QgbWFrZSBzZW5zZS4KT09CIGlzIHRoZSB3aG9sZSBhcmVhIGFm dGVyIHRoZSBkYXRhLgpXaGF0IGFib3V0IE5GQ19PT0JfU1pfUEVSX0VDQ19TVEVQID8KCj4gKwo+ ICBzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCB7Cj4gIAlzdHJ1Y3QgbGlzdF9oZWFkIG5vZGU7 Cj4gIAlzdHJ1Y3QgbmFuZF9jaGlwIG5hbmQ7Cj4gQEAgLTMzOSw3ICszNDIsNyBAQCBzdGF0aWMg dTggKm1lc29uX25mY19vb2JfcHRyKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIGludCBpKQo+ICAJ c3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgKm1lc29uX2NoaXAgPSB0b19tZXNvbl9uYW5kKG5h bmQpOwo+ICAJaW50IGxlbjsKPiAgCj4gLQlsZW4gPSBuYW5kLT5lY2Muc2l6ZSAqIChpICsgMSkg KyAobmFuZC0+ZWNjLmJ5dGVzICsgMikgKiBpOwo+ICsJbGVuID0gbmFuZC0+ZWNjLnNpemUgKiAo aSArIDEpICsgTkZDX09PQl9QRVJfRUNDKG5hbmQpICogaTsKPiAgCj4gIAlyZXR1cm4gbWVzb25f Y2hpcC0+ZGF0YV9idWYgKyBsZW47Cj4gIH0KPiBAQCAtMzUwLDcgKzM1Myw3IEBAIHN0YXRpYyB1 OCAqbWVzb25fbmZjX2RhdGFfcHRyKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIGludCBpKQo+ICAJ aW50IGxlbiwgdGVtcDsKPiAgCj4gIAl0ZW1wID0gbmFuZC0+ZWNjLnNpemUgKyBuYW5kLT5lY2Mu Ynl0ZXM7Cj4gLQlsZW4gPSAodGVtcCArIDIpICogaTsKPiArCWxlbiA9ICh0ZW1wICsgTkZDX1VT RVJfQllURVMpICogaTsKPiAgCj4gIAlyZXR1cm4gbWVzb25fY2hpcC0+ZGF0YV9idWYgKyBsZW47 Cj4gIH0KPiBAQCAtMzY0LDcgKzM2Nyw3IEBAIHN0YXRpYyB2b2lkIG1lc29uX25mY19nZXRfZGF0 YV9vb2Ioc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCXU4ICpkc3JjLCAqb3NyYzsKPiAgCXU4 ICpvb2J0YWlsOwo+ICAKPiAtCW9vYl9sZW4gPSBuYW5kLT5lY2MuYnl0ZXMgKyAyOwo+ICsJb29i X2xlbiA9IE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgCWZvciAoaSA9IDA7IGkgPCBuYW5kLT5l Y2Muc3RlcHM7IGkrKykgewo+ICAJCWlmIChidWYpIHsKPiAgCQkJZHNyYyA9IG1lc29uX25mY19k YXRhX3B0cihuYW5kLCBpKTsKPiBAQCAtMzkzLDcgKzM5Niw3IEBAIHN0YXRpYyB2b2lkIG1lc29u X25mY19zZXRfZGF0YV9vb2Ioc3RydWN0IG5hbmRfY2hpcCAqbmFuZCwKPiAgCXU4ICpkc3JjLCAq b3NyYzsKPiAgCXU4ICpvb2J0YWlsOwo+ICAKPiAtCW9vYl9sZW4gPSBuYW5kLT5lY2MuYnl0ZXMg KyAyOwo+ICsJb29iX2xlbiA9IE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgCWZvciAoaSA9IDA7 IGkgPCBuYW5kLT5lY2Muc3RlcHM7IGkrKykgewo+ICAJCWlmIChidWYpIHsKPiAgCQkJZHNyYyA9 IG1lc29uX25mY19kYXRhX3B0cihuYW5kLCBpKTsKPiBAQCAtNDUyLDcgKzQ1NSw3IEBAIHN0YXRp YyB2b2lkIG1lc29uX25mY19zZXRfdXNlcl9ieXRlKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsIHU4 ICpvb2JfYnVmKQo+ICAJX19sZTY0ICppbmZvOwo+ICAJaW50IGksIGNvdW50Owo+ICAKPiAtCWZv ciAoaSA9IDAsIGNvdW50ID0gMDsgaSA8IG5hbmQtPmVjYy5zdGVwczsgaSsrLCBjb3VudCArPSAo bmFuZC0+ZWNjLmJ5dGVzICsgMikpIHsKPiArCWZvciAoaSA9IDAsIGNvdW50ID0gMDsgaSA8IG5h bmQtPmVjYy5zdGVwczsgaSsrLCBjb3VudCArPSBORkNfT09CX1BFUl9FQ0MobmFuZCkpIHsKPiAg CQlpbmZvID0gJm1lc29uX2NoaXAtPmluZm9fYnVmW2ldOwo+ICAJCSppbmZvIHw9IG9vYl9idWZb Y291bnRdOwo+ICAJCSppbmZvIHw9IG9vYl9idWZbY291bnQgKyAxXSA8PCA4Owo+IEBAIC00NjUs NyArNDY4LDcgQEAgc3RhdGljIHZvaWQgbWVzb25fbmZjX2dldF91c2VyX2J5dGUoc3RydWN0IG5h bmRfY2hpcCAqbmFuZCwgdTggKm9vYl9idWYpCj4gIAlfX2xlNjQgKmluZm87Cj4gIAlpbnQgaSwg Y291bnQ7Cj4gIAo+IC0JZm9yIChpID0gMCwgY291bnQgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBz OyBpKyssIGNvdW50ICs9IChuYW5kLT5lY2MuYnl0ZXMgKyAyKSkgewo+ICsJZm9yIChpID0gMCwg Y291bnQgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBzOyBpKyssIGNvdW50ICs9IE5GQ19PT0JfUEVS X0VDQyhuYW5kKSkgewo+ICAJCWluZm8gPSAmbWVzb25fY2hpcC0+aW5mb19idWZbaV07Cj4gIAkJ b29iX2J1Zltjb3VudF0gPSAqaW5mbzsKPiAgCQlvb2JfYnVmW2NvdW50ICsgMV0gPSAqaW5mbyA+ PiA4Owo+IEBAIC02NjEsNyArNjY0LDcgQEAgc3RhdGljIHUzMiBtZXNvbl9uZmNfb29iX2ZyZWVf Ynl0ZXMoc3RydWN0IG5hbmRfY2hpcCAqbmFuZCkKPiAgewo+ICAJc3RydWN0IG10ZF9pbmZvICpt dGQgPSBuYW5kX3RvX210ZChuYW5kKTsKPiAgCj4gLQlyZXR1cm4gbXRkLT5vb2JzaXplIC0gbmFu ZC0+ZWNjLnN0ZXBzICogKG5hbmQtPmVjYy5ieXRlcyArIDIpOwo+ICsJcmV0dXJuIG10ZC0+b29i c2l6ZSAtIG5hbmQtPmVjYy5zdGVwcyAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKTsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBtZXNvbl9uZmNfd3JpdGVfb29iKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQs IGludCBwYWdlKQo+IEBAIC03MTIsMTEgKzcxNSwxMSBAQCBzdGF0aWMgaW50IG1lc29uX25mY19y ZWFkX29vYihzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCBpbnQgcGFnZSkKPiAgCS8qIFJlYWQgRUND IGNvZGVzIGFuZCB1c2VyIGJ5dGVzLiAqLwo+ICAJZm9yIChpID0gMDsgaSA8IG5hbmQtPmVjYy5z dGVwczsgaSsrKSB7Cj4gIAkJdTMyIGVjY19vZmZzID0gbmFuZC0+ZWNjLnNpemUgKiAoaSArIDEp ICsKPiAtCQkJICAgICAgIChuYW5kLT5lY2MuYnl0ZXMgKyAyKSAqIGk7Cj4gKwkJCSAgICAgICBO RkNfT09CX1BFUl9FQ0MobmFuZCkgKiBpOwo+ICAKPiAgCQlyZXQgPSBuYW5kX2NoYW5nZV9yZWFk X2NvbHVtbl9vcChuYW5kLCBlY2Nfb2ZmcywKPiAtCQkJCQkJIG9vYl9idWYgKyBpICogKG5hbmQt PmVjYy5ieXRlcyArIDIpLAo+IC0JCQkJCQkgKG5hbmQtPmVjYy5ieXRlcyArIDIpLCBmYWxzZSk7 Cj4gKwkJCQkJCSBvb2JfYnVmICsgaSAqIE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwKPiArCQkJCQkJ IE5GQ19PT0JfUEVSX0VDQyhuYW5kKSwgZmFsc2UpOwo+ICAJCWlmIChyZXQpCj4gIAkJCXJldHVy biByZXQ7Cj4gIAl9Cj4gQEAgLTkxOCwxMiArOTIxLDE0IEBAIHN0YXRpYyBpbnQgbWVzb25fbmZj X3JlYWRfcGFnZV9od2VjYyhzdHJ1Y3QgbmFuZF9jaGlwICpuYW5kLCB1OCAqYnVmLAo+ICAKPiAg CQlmb3IgKGkgPSAwOyBpIDwgbmFuZC0+ZWNjLnN0ZXBzIDsgaSsrKSB7Cj4gIAkJCXU4ICpkYXRh ID0gYnVmICsgaSAqIGVjYy0+c2l6ZTsKPiAtCQkJdTggKm9vYiA9IG5hbmQtPm9vYl9wb2kgKyBp ICogKGVjYy0+Ynl0ZXMgKyAyKTsKPiArCQkJdTggKm9vYiA9IG5hbmQtPm9vYl9wb2kgKyBpICog TkZDX09PQl9QRVJfRUNDKG5hbmQpOwo+ICAKPiAgCQkJaWYgKGNvcnJlY3RfYml0bWFwICYgQklU X1VMTChpKSkKPiAgCQkJCWNvbnRpbnVlOwo+ICsKPiAgCQkJcmV0ID0gbmFuZF9jaGVja19lcmFz ZWRfZWNjX2NodW5rKGRhdGEsCWVjYy0+c2l6ZSwKPiAtCQkJCQkJCSAgb29iLCBlY2MtPmJ5dGVz ICsgMiwKPiArCQkJCQkJCSAgb29iLAo+ICsJCQkJCQkJICBORkNfT09CX1BFUl9FQ0MobmFuZCks Cj4gIAkJCQkJCQkgIE5VTEwsIDAsCj4gIAkJCQkJCQkgIGVjYy0+c3RyZW5ndGgpOwo+ICAJCQlp ZiAocmV0IDwgMCkgewo+IEBAIC0xMDczLDcgKzEwNzgsNyBAQCBzdGF0aWMgaW50IG1lc29uX29v YmxheW91dF9lY2Moc3RydWN0IG10ZF9pbmZvICptdGQsIGludCBzZWN0aW9uLAo+ICAJaWYgKHNl Y3Rpb24gPj0gbmFuZC0+ZWNjLnN0ZXBzKQo+ICAJCXJldHVybiAtRVJBTkdFOwo+ICAKPiAtCW9v YnJlZ2lvbi0+b2Zmc2V0ID0gIDIgKyAoc2VjdGlvbiAqICgyICsgbmFuZC0+ZWNjLmJ5dGVzKSk7 Cj4gKwlvb2JyZWdpb24tPm9mZnNldCA9IE5GQ19VU0VSX0JZVEVTICsgKHNlY3Rpb24gKiBORkNf T09CX1BFUl9FQ0MobmFuZCkpOwoKTm8sIHRoZSBmaXJzdCAiMiIgaGVyZSBpcyBmb3IgYmFkIGJs b2NrIG1hcmtlcnMsIGl0IGlzIG5vdCByZWxhdGVkIHRvCnlvdXIgRUNDIGVuZ2luZSBsYXlvdXQg SSBiZWxpZXZlLgoKPiAgCW9vYnJlZ2lvbi0+bGVuZ3RoID0gbmFuZC0+ZWNjLmJ5dGVzOwo+ICAK PiAgCXJldHVybiAwOwo+IEBAIC0xMDkxLDcgKzEwOTYsNyBAQCBzdGF0aWMgaW50IG1lc29uX29v YmxheW91dF9mcmVlKHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBpbnQgc2VjdGlvbiwKPiAgCS8qIFNw bGl0IHJlc3Qgb2YgT09CIGFyZWEgKG5vdCBjb3ZlcmVkIGJ5IEVDQyBlbmdpbmUpIHBlciBlYWNo Cj4gIAkgKiBFQ0Mgc2VjdGlvbi4gVGhpcyB3aWxsIGJlIE9PQiBkYXRhIGF2YWlsYWJsZSB0byB1 c2VyLgo+ICAJICovCj4gLQlvb2JyZWdpb24tPm9mZnNldCA9IChzZWN0aW9uICsgbmFuZC0+ZWNj LnN0ZXBzKSAqICgyICsgbmFuZC0+ZWNjLmJ5dGVzKTsKPiArCW9vYnJlZ2lvbi0+b2Zmc2V0ID0g KHNlY3Rpb24gKyBuYW5kLT5lY2Muc3RlcHMpICogTkZDX09PQl9QRVJfRUNDKG5hbmQpOwo+ICAJ b29icmVnaW9uLT5sZW5ndGggPSBvb2JfYnl0ZXMgLyBuYW5kLT5lY2Muc3RlcHM7Cj4gIAo+ICAJ cmV0dXJuIDA7CgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9F9C77B7E for ; Thu, 1 Jun 2023 08:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232223AbjFAIgS (ORCPT ); Thu, 1 Jun 2023 04:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232199AbjFAIfi (ORCPT ); Thu, 1 Jun 2023 04:35:38 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36A89E70 for ; Thu, 1 Jun 2023 01:34:11 -0700 (PDT) X-GND-Sasl: miquel.raynal@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685608450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=663IAskSouGvSvR75PHPprqPibZidxQMt5gFnwQhwKw=; b=N9LC6jiIgSsRnMoqd4fOu94yzBOqz5ZALVcfI3eIolqZxTZyzsAg+yxpRCz6ELtRAiUYyd 2h6byanGwpXngLqwp3gUhuHEfSyj/SCVJVT+I/d5FWTnC7LzH3dTcUM64dmXYVpeWndXWh mqOpXCTwAyJmoS7ROmQUVES/ShT7mwcZT5rmgSUDM5mi8X44jotikO6TXQiQn5PB6gWjKu ErHfcirIYe6jeMSa2E2dPwz5wM1/fGZBjLEPRtSHccM+72dHg2g6CkGN1A9TCfhTeilir+ 82nF6inbzu008F/EWwZvmxFHvUy++vpVi2EPyEsrzqJckmGMbifrX4icsAWlLg== X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com X-GND-Sasl: miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id EA7B3C000E; Thu, 1 Jun 2023 08:34:07 +0000 (UTC) Date: Thu, 1 Jun 2023 10:34:05 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , Subject: Re: [RFC PATCH v5 4/6] mtd: rawnand: meson: use macro for OOB area Message-ID: <20230601103405.51cb459a@xps-13> In-Reply-To: <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> References: <20230601061850.3907800-1-AVKrasnov@sberdevices.ru> <20230601061850.3907800-5-AVKrasnov@sberdevices.ru> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arseniy, AVKrasnov@sberdevices.ru wrote on Thu, 1 Jun 2023 09:18:47 +0300: > This replaces constants and same patterns for OOB handling with special > macroses. >=20 > Signed-off-by: Arseniy Krasnov > --- > drivers/mtd/nand/raw/meson_nand.c | 33 ++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 14 deletions(-) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index e42c28be02f3..23a73268421b 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -108,6 +108,9 @@ > =20 > #define PER_INFO_BYTE 8 > =20 > +#define NFC_USER_BYTES 2 > +#define NFC_OOB_PER_ECC(nand) ((nand)->ecc.bytes + NFC_USER_BYTES) OOB per ECC for me does not make sense. OOB is the whole area after the data. What about NFC_OOB_SZ_PER_ECC_STEP ? > + > struct meson_nfc_nand_chip { > struct list_head node; > struct nand_chip nand; > @@ -339,7 +342,7 @@ static u8 *meson_nfc_oob_ptr(struct nand_chip *nand, = int i) > struct meson_nfc_nand_chip *meson_chip =3D to_meson_nand(nand); > int len; > =20 > - len =3D nand->ecc.size * (i + 1) + (nand->ecc.bytes + 2) * i; > + len =3D nand->ecc.size * (i + 1) + NFC_OOB_PER_ECC(nand) * i; > =20 > return meson_chip->data_buf + len; > } > @@ -350,7 +353,7 @@ static u8 *meson_nfc_data_ptr(struct nand_chip *nand,= int i) > int len, temp; > =20 > temp =3D nand->ecc.size + nand->ecc.bytes; > - len =3D (temp + 2) * i; > + len =3D (temp + NFC_USER_BYTES) * i; > =20 > return meson_chip->data_buf + len; > } > @@ -364,7 +367,7 @@ static void meson_nfc_get_data_oob(struct nand_chip *= nand, > u8 *dsrc, *osrc; > u8 *oobtail; > =20 > - oob_len =3D nand->ecc.bytes + 2; > + oob_len =3D NFC_OOB_PER_ECC(nand); > for (i =3D 0; i < nand->ecc.steps; i++) { > if (buf) { > dsrc =3D meson_nfc_data_ptr(nand, i); > @@ -393,7 +396,7 @@ static void meson_nfc_set_data_oob(struct nand_chip *= nand, > u8 *dsrc, *osrc; > u8 *oobtail; > =20 > - oob_len =3D nand->ecc.bytes + 2; > + oob_len =3D NFC_OOB_PER_ECC(nand); > for (i =3D 0; i < nand->ecc.steps; i++) { > if (buf) { > dsrc =3D meson_nfc_data_ptr(nand, i); > @@ -452,7 +455,7 @@ static void meson_nfc_set_user_byte(struct nand_chip = *nand, u8 *oob_buf) > __le64 *info; > int i, count; > =20 > - for (i =3D 0, count =3D 0; i < nand->ecc.steps; i++, count +=3D (nand->= ecc.bytes + 2)) { > + for (i =3D 0, count =3D 0; i < nand->ecc.steps; i++, count +=3D NFC_OOB= _PER_ECC(nand)) { > info =3D &meson_chip->info_buf[i]; > *info |=3D oob_buf[count]; > *info |=3D oob_buf[count + 1] << 8; > @@ -465,7 +468,7 @@ static void meson_nfc_get_user_byte(struct nand_chip = *nand, u8 *oob_buf) > __le64 *info; > int i, count; > =20 > - for (i =3D 0, count =3D 0; i < nand->ecc.steps; i++, count +=3D (nand->= ecc.bytes + 2)) { > + for (i =3D 0, count =3D 0; i < nand->ecc.steps; i++, count +=3D NFC_OOB= _PER_ECC(nand)) { > info =3D &meson_chip->info_buf[i]; > oob_buf[count] =3D *info; > oob_buf[count + 1] =3D *info >> 8; > @@ -661,7 +664,7 @@ static u32 meson_nfc_oob_free_bytes(struct nand_chip = *nand) > { > struct mtd_info *mtd =3D nand_to_mtd(nand); > =20 > - return mtd->oobsize - nand->ecc.steps * (nand->ecc.bytes + 2); > + return mtd->oobsize - nand->ecc.steps * NFC_OOB_PER_ECC(nand); > } > =20 > static int meson_nfc_write_oob(struct nand_chip *nand, int page) > @@ -712,11 +715,11 @@ static int meson_nfc_read_oob(struct nand_chip *nan= d, int page) > /* Read ECC codes and user bytes. */ > for (i =3D 0; i < nand->ecc.steps; i++) { > u32 ecc_offs =3D nand->ecc.size * (i + 1) + > - (nand->ecc.bytes + 2) * i; > + NFC_OOB_PER_ECC(nand) * i; > =20 > ret =3D nand_change_read_column_op(nand, ecc_offs, > - oob_buf + i * (nand->ecc.bytes + 2), > - (nand->ecc.bytes + 2), false); > + oob_buf + i * NFC_OOB_PER_ECC(nand), > + NFC_OOB_PER_ECC(nand), false); > if (ret) > return ret; > } > @@ -918,12 +921,14 @@ static int meson_nfc_read_page_hwecc(struct nand_ch= ip *nand, u8 *buf, > =20 > for (i =3D 0; i < nand->ecc.steps ; i++) { > u8 *data =3D buf + i * ecc->size; > - u8 *oob =3D nand->oob_poi + i * (ecc->bytes + 2); > + u8 *oob =3D nand->oob_poi + i * NFC_OOB_PER_ECC(nand); > =20 > if (correct_bitmap & BIT_ULL(i)) > continue; > + > ret =3D nand_check_erased_ecc_chunk(data, ecc->size, > - oob, ecc->bytes + 2, > + oob, > + NFC_OOB_PER_ECC(nand), > NULL, 0, > ecc->strength); > if (ret < 0) { > @@ -1073,7 +1078,7 @@ static int meson_ooblayout_ecc(struct mtd_info *mtd= , int section, > if (section >=3D nand->ecc.steps) > return -ERANGE; > =20 > - oobregion->offset =3D 2 + (section * (2 + nand->ecc.bytes)); > + oobregion->offset =3D NFC_USER_BYTES + (section * NFC_OOB_PER_ECC(nand)= ); No, the first "2" here is for bad block markers, it is not related to your ECC engine layout I believe. > oobregion->length =3D nand->ecc.bytes; > =20 > return 0; > @@ -1091,7 +1096,7 @@ static int meson_ooblayout_free(struct mtd_info *mt= d, int section, > /* Split rest of OOB area (not covered by ECC engine) per each > * ECC section. This will be OOB data available to user. > */ > - oobregion->offset =3D (section + nand->ecc.steps) * (2 + nand->ecc.byte= s); > + oobregion->offset =3D (section + nand->ecc.steps) * NFC_OOB_PER_ECC(nan= d); > oobregion->length =3D oob_bytes / nand->ecc.steps; > =20 > return 0; Thanks, Miqu=C3=A8l