All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Steven Price <steven.price@arm.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Dhruva Gole" <d-gole@ti.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Johan Hovold" <johan@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-omap@vger.kernel.org,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM
Date: Thu, 1 Jun 2023 13:57:16 +0300	[thread overview]
Message-ID: <20230601105716.GY14287@atomide.com> (raw)
In-Reply-To: <fca99838-991d-66a7-0c2c-16ae901e3935@arm.com>

* Steven Price <steven.price@arm.com> [230601 10:53]:
> On 01/06/2023 11:44, Tony Lindgren wrote:
> > Hi,
> > 
> > * Steven Price <steven.price@arm.com> [230601 10:04]:
> >> I haven't studied this change in detail, but I assume the bug is that
> >> serial_base_port_device_remove() shouldn't be dropping port_mutex. The
> >> below hack gets my board booting again.
> > 
> > You're right. I wonder how I managed to miss that.. Care to post a proper
> > fix for this or do you want me to post it?
> 
> I'll post a proper fix shortly. Thanks for the confirmation of the fix.

OK great thanks!

> > Seems you can remove out here and just do a return earlier instead of goto.
> 
> Yes, this was just the smallest change. I'll do it properly with an
> early return in the proper patch.

OK

Regards,

Tony

  reply	other threads:[~2023-06-01 10:57 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230601110030eucas1p2eed547c326a51a6110100fb50799d136@eucas1p2.samsung.com>
2023-05-25 11:30 ` [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM Tony Lindgren
2023-05-27  8:25   ` Andy Shevchenko
2023-05-30 14:43   ` Greg Kroah-Hartman
2023-06-01 10:04   ` Steven Price
2023-06-01 10:44     ` Tony Lindgren
2023-06-01 10:53       ` Steven Price
2023-06-01 10:57         ` Tony Lindgren [this message]
2023-06-01 11:00   ` Marek Szyprowski
2023-06-01 11:11     ` Tony Lindgren
2023-06-01 13:20       ` Tony Lindgren
2023-06-01 14:16         ` Marek Szyprowski
2023-06-01 14:20           ` Tony Lindgren
2023-06-02  8:33   ` Chen-Yu Tsai
2023-06-02  9:27     ` Tony Lindgren
2023-06-02 10:13     ` John Ogness
2023-06-03  5:41       ` Tony Lindgren
2023-06-03  6:35         ` Tony Lindgren
2023-06-05  6:15           ` Tony Lindgren
2023-06-05 11:28             ` Andy Shevchenko
2023-06-05 12:25               ` Tony Lindgren
2023-06-05 11:34             ` Chen-Yu Tsai
2023-06-05 12:24               ` Tony Lindgren
2023-06-05 13:01                 ` Chen-Yu Tsai
2023-06-05 13:18                   ` Tony Lindgren
2023-06-06  9:16                     ` Chen-Yu Tsai
2023-06-06 12:20                       ` Tony Lindgren
2023-06-07  4:46                         ` Chen-Yu Tsai
2023-06-07  7:17                           ` AngeloGioacchino Del Regno
2023-06-07 20:20                           ` Andy Shevchenko
2023-06-03 21:57         ` Sebastian Reichel
2023-06-04  6:04           ` Tony Lindgren
2023-06-05  3:04       ` Chen-Yu Tsai
2023-10-03 11:57   ` Maximilian Luz
2023-10-03 12:14     ` Tony Lindgren
2023-10-03 12:21       ` Tony Lindgren
2023-10-03 22:09         ` Maximilian Luz
2023-10-04  6:17           ` Tony Lindgren
2023-10-04  7:14             ` Johan Hovold
2023-10-04  9:03               ` Tony Lindgren
2023-10-04  9:14                 ` Johan Hovold
2023-10-04 10:01                   ` Tony Lindgren
2023-10-04 18:44                     ` Maximilian Luz
2023-10-04  7:39             ` Maximilian Luz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230601105716.GY14287@atomide.com \
    --to=tony@atomide.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=d-gole@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=steven.price@arm.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.