From: Tony Lindgren <tony@atomide.com>
To: Steven Price <steven.price@arm.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
linux-omap@vger.kernel.org,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dhruva Gole" <d-gole@ti.com>
Subject: Re: [PATCH] serial: core: Don't drop port_mutex in serial_core_remove_one_port
Date: Thu, 1 Jun 2023 13:58:25 +0300 [thread overview]
Message-ID: <20230601105825.GZ14287@atomide.com> (raw)
In-Reply-To: <20230601105548.29965-1-steven.price@arm.com>
* Steven Price <steven.price@arm.com> [230601 10:56]:
> Commit 84a9582fd203 ("serial: core: Start managing serial controllers to
> enable runtime PM") required the caller to hold port_mutex rather than
> taking it locally. However the mutex_unlock() call wasn't removed
> causing the mutex to be dropped unexpectly. Remove the call to
> mutex_unlock() (and fix up the early return) to restore correct
> behaviour.
>
> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
Reviewed-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2023-06-01 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 10:55 [PATCH] serial: core: Don't drop port_mutex in serial_core_remove_one_port Steven Price
2023-06-01 10:58 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601105825.GZ14287@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.