From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] generic: add a test for device removal with dirty data
Date: Thu, 1 Jun 2023 17:27:40 +0200 [thread overview]
Message-ID: <20230601152740.GA31938@lst.de> (raw)
In-Reply-To: <20230601152536.GA16856@frogsfrogsfrogs>
On Thu, Jun 01, 2023 at 08:25:36AM -0700, Darrick J. Wong wrote:
> > +_require_scsi_debug
> > +
> > +physical=`blockdev --getpbsz $SCRATCH_DEV`
> > +logical=`blockdev --getss $SCRATCH_DEV`
>
> These two tests need to _notrun if SCRATCH_DEV is not a blockdev or if
> SCRATCH_MNT is not a directory. Normally _require_scratch_nocheck takes
> care of that.
>
> Other than that they look ok.
Can SCRATCH_MNT be not a directory?
But yeah, these tests should simply grow a
_require_block_device $SCRATCH_DEV
next prev parent reply other threads:[~2023-06-01 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 9:42 add device removal test Christoph Hellwig
2023-06-01 9:42 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-06-01 15:25 ` Darrick J. Wong
2023-06-01 15:27 ` Christoph Hellwig [this message]
2023-06-01 16:04 ` Darrick J. Wong
2023-06-02 4:13 ` Christoph Hellwig
2023-06-02 10:58 ` Zorro Lang
2023-06-01 9:42 ` [PATCH 2/2] generic: add a test for device removal without " Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2023-07-11 10:09 add device removal test v2 Christoph Hellwig
2023-07-11 10:09 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-07-18 10:34 ` Zorro Lang
2023-07-24 15:29 add device removal test v3 Christoph Hellwig
2023-07-24 15:29 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-07-24 18:23 ` Andrey Albershteyn
2023-07-24 19:52 ` Christoph Hellwig
2023-07-25 9:44 ` Andrey Albershteyn
2023-07-25 15:33 ` Darrick J. Wong
2023-08-06 14:11 ` Zorro Lang
2023-08-07 11:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601152740.GA31938@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.