From: arjan@linux.intel.com
To: linux-pm@vger.kernel.org
Cc: artem.bityutskiy@linux.intel.com, rafael@kernel.org,
Arjan van de Ven <arjan.van.de.ven@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: [PATCH 5/7] intel_idle: Add a way to skip the mwait check on all states
Date: Thu, 1 Jun 2023 18:27:59 +0000 [thread overview]
Message-ID: <20230601182801.2622044-6-arjan@linux.intel.com> (raw)
In-Reply-To: <20230601182801.2622044-1-arjan@linux.intel.com>
From: Arjan van de Ven <arjan.van.de.ven@intel.com>
Currently, intel_idle verifies that the cpuid instruction enumerates
that the mwait value for a state is actually supported by the CPU.
Going forward, when running in a VM guest, that check will not work
and we're going to need a way to turn it off.
Add a global bool for this, and uses this in the check
function to short circuit this cpuid check.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
drivers/idle/intel_idle.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index 66d262fd267e..55c3e6ece3dd 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -69,6 +69,7 @@ static int max_cstate = CPUIDLE_STATE_MAX - 1;
static unsigned int disabled_states_mask __read_mostly;
static unsigned int preferred_states_mask __read_mostly;
static bool force_irq_on __read_mostly;
+static bool skip_mwait_check __read_mostly;
static struct cpuidle_device __percpu *intel_idle_cpuidle_devices;
@@ -1866,6 +1867,9 @@ static bool __init intel_idle_verify_cstate(unsigned int mwait_hint)
unsigned int num_substates = (mwait_substates >> mwait_cstate * 4) &
MWAIT_SUBSTATE_MASK;
+ if (skip_mwait_check)
+ return true;
+
/* Ignore the C-state if there are NO sub-states in CPUID for it. */
if (num_substates == 0)
return false;
--
2.40.1
next prev parent reply other threads:[~2023-06-01 18:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 18:27 [PATCH 00/7 Add support for running in VM guests to intel_idle arjan
2023-06-01 18:27 ` [PATCH 1/7] intel_idle: refactor state->enter manipulation into its own function arjan
2023-06-01 18:27 ` [PATCH 2/7] intel_idle: clean up the (new) state_update_enter_method function arjan
2023-06-04 15:34 ` Rafael J. Wysocki
2023-06-04 22:35 ` Van De Ven, Arjan
2023-06-01 18:27 ` [PATCH 3/7] intel_idle: Add a sanity check in the new " arjan
2023-06-04 15:43 ` Rafael J. Wysocki
2023-06-01 18:27 ` [PATCH 4/7] intel_idle: Add helper functions to support 'hlt' as idle state arjan
2023-06-04 15:46 ` Rafael J. Wysocki
2023-06-01 18:27 ` arjan [this message]
2023-06-04 15:54 ` [PATCH 5/7] intel_idle: Add a way to skip the mwait check on all states Rafael J. Wysocki
2023-06-05 15:24 ` Arjan van de Ven
2023-06-01 18:28 ` [PATCH 6/7] intel_idle: Add support for using intel_idle in a VM guest using just hlt arjan
2023-06-04 15:59 ` Rafael J. Wysocki
2023-06-04 22:34 ` Van De Ven, Arjan
2023-06-01 18:28 ` [PATCH 7/7] intel_idle: Add a "Long HLT" C1 state for the VM guest mode arjan
2023-06-04 15:01 ` [PATCH 00/7 Add support for running in VM guests to intel_idle Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601182801.2622044-6-arjan@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.