From: "Marek Behún" <kabel@kernel.org>
To: msmulski2@gmail.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, simon.horman@corigine.com,
Michal Smulski <michal.smulski@ooma.com>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x
Date: Fri, 2 Jun 2023 09:53:49 +0200 [thread overview]
Message-ID: <20230602095349.2ab53919@dellmb> (raw)
In-Reply-To: <20230602001705.2747-2-msmulski2@gmail.com>
On Thu, 1 Jun 2023 17:17:04 -0700
msmulski2@gmail.com wrote:
> config->mac_capabilities |= MAC_5000FD |
> MAC_10000FD;
> }
> - /* FIXME: USXGMII is not supported yet */
> - /* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */
> + __set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
> }
> }
The set_bit() should go into the if statement above, since 6361 does not support usxgmii:
/* 6361 only supports up to 2500BaseX */
if (!is_6361) {
__set_bit(PHY_INTERFACE_MODE_5GBASER, supported);
__set_bit(PHY_INTERFACE_MODE_10GBASER, supported);
+ __set_bit(PHY_INTERFACE_MODE_USXGMII, supported);
config->mac_capabilities |= MAC_5000FD |
MAC_10000FD;
}
-/* FIXME: USXGMII is not supported yet */
-/* __set_bit(PHY_INTERFACE_MODE_USXGMII, supported); */
Marek
next prev parent reply other threads:[~2023-06-02 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 0:17 [PATCH net-next v6 0/1] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x msmulski2
2023-06-02 0:17 ` [PATCH net-next v6 1/1] " msmulski2
2023-06-02 7:53 ` Marek Behún [this message]
2023-06-03 4:32 ` Michal Smulski
2023-06-02 10:30 ` Russell King (Oracle)
2023-06-02 11:28 ` Ioana Ciornei
2023-06-02 13:11 ` Russell King (Oracle)
2023-06-02 14:31 ` Ioana Ciornei
2023-06-03 5:27 ` Michal Smulski
2023-06-03 4:56 ` Michal Smulski
2023-06-02 11:08 ` Russell King (Oracle)
2023-06-03 4:59 ` Michal Smulski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602095349.2ab53919@dellmb \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.smulski@ooma.com \
--cc=msmulski2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.