From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, bingbu.cao@intel.com
Subject: Re: [PATCH v3 1/1] media: pci: ipu3-cio2: Obtain remote pad from endpoint
Date: Fri, 2 Jun 2023 17:23:03 +0300 [thread overview]
Message-ID: <20230602142303.GD24855@pendragon.ideasonboard.com> (raw)
In-Reply-To: <ZHn5MH3o1l0lBhqS@kekkonen.localdomain>
Hi Sakari,
On Fri, Jun 02, 2023 at 02:14:08PM +0000, Sakari Ailus wrote:
> On Fri, Jun 02, 2023 at 12:12:12PM +0300, Laurent Pinchart wrote:
> > On Mon, May 15, 2023 at 03:21:27PM +0300, Sakari Ailus wrote:
> > > Use the endpoint fwnode to find out the remote pad, instead of using the
> > > first source pad found. Also improve error messages.
> >
> > The commit message should explain *why*. Once I know why, I'll review
> > the patch :-)
>
> I thought it'd be trivial. :-)
It may appear trivial as a patch author, but reviewers don't have the
context, so they shouldn't be expected to guess the intent.
> Using framework functions instead of open coding this in drivers, and using
> the pad related to the endpoint fwnode instead of just the first pad found.
>
> I'll add this to the commit message.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-06-02 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 12:21 [PATCH v3 1/1] media: pci: ipu3-cio2: Obtain remote pad from endpoint Sakari Ailus
2023-05-16 10:19 ` Bingbu Cao
2023-06-02 9:12 ` Laurent Pinchart
2023-06-02 14:14 ` Sakari Ailus
2023-06-02 14:23 ` Laurent Pinchart [this message]
2023-06-02 14:27 ` Sakari Ailus
2023-06-08 9:27 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602142303.GD24855@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.